App\Http\Controllers\Customers\CustomerDetailsController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	154
Duplicated Lines	0 %

Test Coverage

Coverage

46%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	25	1
A	details()	0	40	4
A	__construct()	0	3	1
A	destroy()	0	2	1
A	store()	0	30	1
A	show()	0	13	2
A	create()	0	6	1

<?php

namespace App\Http\Controllers\Customers;

use App\Customers;
use App\CustomerFavs;
use App\PhoneNumberType;
use App\CustomerFileTypes;
use Illuminate\Http\Request;
use App\Http\Traits\SystemsTrait;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Route;

class CustomerDetailsController extends Controller
{
    use SystemsTrait;

The trait App\Http\Traits\SystemsTrait requires some properties which are not provided by App\Http\Controllers\Customers\CustomerDetailsController: $cat_name, $sys_id, $name

    public function __construct()
    {
        $this->middleware('auth');
    }

    //  New Customer Form
    public function create()
    {
        $this->authorize('hasAccess', 'add_customer');

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        return view('customer.newCustomer');
    }

    //  Submit the new customer form
    public function store(Request $request)
    {
        $this->authorize('hasAccess', 'add_customer');

        $request->validate([
            'cust_id'  => 'required|numeric|unique:customers,cust_id',
            'name'     => 'required', // |unique:customers,name',
            'dba_name' => 'nullable',
            'address'  => 'required',
            'city'     => 'required',
            'zip'      => 'required|numeric'
        ]);

        //  Remove any forward slash (/) from the Customer name field
        $request->merge(['name' => str_replace('/', '-', $request->name)]);

        Customers::create([
            'cust_id'  => $request->cust_id,
            'name'     => $request->name,
            'dba_name' => $request->dba_name,
            'address'  => $request->address,
            'city'     => $request->city,
            'state'    => $request->selectedState,
            'zip'      => $request->zip,
        ]);

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        Log::notice('New Customer ID-'.$request->custID.' created by User ID-'.Auth::user()->user_id);

        return response()->json(['success' => true ]);
    }







    //  Show the customer details
    public function details($id, $name)

The parameter $name is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        echo 'customer details';
        die();

Using exit here is not recommended.

        $custDetails = Customers::find($id);

$custDetails = App\Customers::find($id) is not reachable.

        $allSystems  = $this->getAllSystems();

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        if(empty($custDetails))
        {
            Log::info('User ID-'.Auth::user()->user_id.' visited invalid customer ID-'.$id.'-'.$name);
            return view('err.customerNotFound');
        }

        //  Determine if the customer is one of the users bookmarks
        $custFav = CustomerFavs::where('user_id', Auth::user()->user_id)->where('cust_id', $custDetails->cust_id)->first();
        //  Get the types of phone numbers that can be assigned to a customer contact
        $pTypes = PhoneNumberType::all();
        $phoneTypes = [];
        foreach($pTypes as $type)
        {
            $phoneTypes[] = [
                'value' => $type->phone_type_id,
                'text'  => $type->description,
                'icon'  => $type->icon_class
            ];
        }

        //  Get the types of files that can be attached to a file
        $fileTypes = CustomerFileTypes::select('file_type_id as value', 'description as text')->get();

        Log::debug('Customer Details', $custDetails->toArray());
        return view('customer.details', [
            'details'    => $custDetails,
            'isFav'      => empty($custFav) ? false : true,
            'sysList'    => $allSystems,
            'phoneTypes' => $phoneTypes,
            'fileTypes'  => $fileTypes
        ]);
    }

    //  Get the basic details of the customer
    public function show($id)
    {
        $details = Customers::find($id);

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        if(empty($details))
        {
            Log::info('User ID-'.Auth::user()->user_id.' visited invalid customer ID-'.$id);
            return response()->json(['error' => 'Customer Not Found']);
        }

        Log::debug('Customer Details', $details->toArray());
        return response()->json($details);
    }

    //  Update the customer details
    public function update(Request $request, $id)
    {
        $request->validate([
            'name'     => 'required',
            'dba_name' => 'nullable',
            'address'  => 'required',
            'city'     => 'required',
            'state'    => 'required',
            'zip'      => 'required|numeric'
        ]);

        Customers::find($id)->update([
            'name'     => $request->name,
            'dba_name' => $request->dba_name,
            'address'  => $request->address,
            'city'     => $request->city,
            'state'    => $request->state,
            'zip'      => $request->zip
        ]);

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        Log::notice('Customer Details Updated for Customer ID-'.$id.' by User ID-'.Auth::user()->user_id);
        Log::debug('Customer Details Submitted - ', $request->toArray());
        return response()->json([
            'success' => true
        ]);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

The parameter $id is not used and could be removed.

    {
        //
    }
}