App\Http\Controllers\Customers\CustomerFileController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	109
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	23	3
A	restore()	0	8	1
A	forceDelete()	0	10	1
A	destroy()	0	10	1
A	store()	0	28	3

<?php

namespace App\Http\Controllers\Customers;

use App\Traits\FileTrait;
use Illuminate\Http\Request;

use App\Models\Customer;
use App\Models\CustomerFile;
use App\Models\CustomerFileType;

use App\Http\Controllers\Controller;
use App\Http\Requests\Customers\CustomerFileRequest;

use App\Events\Customers\Files\CustomerFileAddedEvent;
use App\Events\Customers\Files\CustomerFileDeletedEvent;
use App\Events\Customers\Files\CustomerFileForceDeletedEvent;
use App\Events\Customers\Files\CustomerFileRestoredEvent;
use App\Events\Customers\Files\CustomerFileUpdatedEvent;

class CustomerFileController extends Controller
{
    use FileTrait;

The trait App\Traits\FileTrait requires the property $username which is not provided by App\Http\Controllers\Customers\CustomerFileController.

    /**
     * Store a file for a specific customer
     */
    public function store(CustomerFileRequest $request)
    {
        //  Make sure that the file information was stored in the users session
        $this->checkForFile();
        $fileData = $request->session()->pull('new-file-upload');

        $cust    = Customer::findOrFail($request->cust_id);
        $cust_id = $cust->cust_id;

        //  If the equipment is shared, it must be assigned to the parent site
        if($request->shared && $cust->parent_id > 0)
        {
            $cust_id = $cust->parent_id;
        }

        $newFile = CustomerFile::create([
            'file_id'      => $fileData[0]->file_id,
            'file_type_id' => CustomerFileType::where('description', $request->type)->first()->file_type_id,
            'cust_id'      => $cust_id,
            'user_id'      => $request->user()->user_id,
            'shared'       => $request->shared,
            'name'         => $request->name,
        ]);

        event(new CustomerFileAddedEvent(Customer::find($request->cust_id), $newFile));

It seems like App\Models\Customer::find($request->cust_id) can also be of type null; however, parameter $cust of App\Events\Customers\Files\CustomerFileAddedEvent::__construct() does only seem to accept App\Models\Customer, maybe add an additional type check?

        return back()->with([
            'message' => 'File Added',
            'type'    => 'success',
        ]);
    }

    /**
     * Update the details for a customer uploaded file - not the file itself
     */
    public function update(CustomerFileRequest $request, $id)
    {
        $cust    = Customer::findOrFail($request->cust_id);
        $cust_id = $cust->cust_id;

        //  If the equipment is shared, it must be assigned to the parent site
        if($request->shared && $cust->parent_id > 0)
        {
            $cust_id = $cust->parent_id;
        }

        $fileData = CustomerFile::find($id);
        $fileData->update([
            'file_type_id' => CustomerFileType::where('description', $request->type)->first()->file_type_id,
            'cust_id'      => $cust_id,
            'shared'       => $request->shared,
            'name'         => $request->name,
        ]);

        event(new CustomerFileUpdatedEvent($cust, $fileData));

It seems like $fileData can also be of type null; however, parameter $file of App\Events\Customers\Files\CustomerFileUpdatedEvent::__construct() does only seem to accept App\Models\CustomerFile, maybe add an additional type check?

        return back()->with([
            'message' => 'File Information Updated',
            'type'    => 'success'
        ]);
    }

    /**
     * Delete a customer file
     */
    public function destroy($id)
    {
        $this->authorize('delete', CustomerFile::class);
        $file = CustomerFile::find($id);
        $file->delete();

        event(new CustomerFileDeletedEvent(Customer::find($file->cust_id), $file));

It seems like $file can also be of type null; however, parameter $file of App\Events\Customers\Files\CustomerFileDeletedEvent::__construct() does only seem to accept App\Models\CustomerFile, maybe add an additional type check?

It seems like App\Models\Customer::find($file->cust_id) can also be of type null; however, parameter $cust of App\Events\Customers\Files\CustomerFileDeletedEvent::__construct() does only seem to accept App\Models\Customer, maybe add an additional type check?

        return back()->with([
            'message' => 'File Deleted',
            'type'    => 'danger',
        ]);
    }

    /*
    *   Restore a deleted file
    */
    public function restore($id)
    {
        $this->authorize('restore', CustomerFile::class);
        $file = CustomerFile::withTrashed()->where('cust_file_id', $id)->first();
        $file->restore();

        event(new CustomerFileRestoredEvent(Customer::find($file->cust_id), $file));

It seems like App\Models\Customer::find($file->cust_id) can also be of type null; however, parameter $cust of App\Events\Customers\Files\CustomerFileRestoredEvent::__construct() does only seem to accept App\Models\Customer, maybe add an additional type check?

        return back()->with(['message' => 'Customer File restored', 'type' => 'success']);
    }

    /*
    *   Permanently delete a file
    */
    public function forceDelete($id)
    {
        $this->authorize('forceDelete', CustomerFile::class);

        $file = CustomerFile::withTrashed()->where('cust_file_id', $id)->first();
        $file->forceDelete();
        $this->deleteFile($file->file_id);

        event(new CustomerFileForceDeletedEvent(Customer::find($file->cust_id), $file));

It seems like App\Models\Customer::find($file->cust_id) can also be of type null; however, parameter $cust of App\Events\Customers\Files\CustomerFileForceDeletedEvent::__construct() does only seem to accept App\Models\Customer, maybe add an additional type check?

        return back()->with(['message' => 'File permanently deleted', 'type' => 'danger']);
    }
}