SetEquipment::updateEquipment() - Code Metrics - Inspection of "Updated Equipment Types Administration" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5a ( 668142...386e30 )

by Ron

created 2020-06-01 03:11 UTC

SetEquipment::updateEquipment() A

↳ Parent: SetEquipment

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	9
c	1
b	0
f	0
nc	2
nop	2
dl	0
loc	16
ccs	10
cts	10
cp	1
crap	2
rs	9.9666

<?php

namespace App\Domains\Equipment;

use App\SystemTypes;

use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Log;


class SetEquipment extends SetEquipmentDataFields
{
    public function createEquipment($request)
    {
        $newEquip = SystemTypes::create([
            'cat_id' => $request->cat_id,
            'name' => $request->name,
            'folder_location' => $request->name,
        ]);
        $this->createEquipmentFields($request->system_data_fields, $newEquip->sys_id);

        return true;
    }

    public function updateEquipment($request, $sysID)
    {
        $equip = SystemTypes::findOrFail($sysID);
        DB::beginTransaction();

        $equip->update([
            'name'   => $request->name,
        ]);
        $success = $this->updateEquipFields($request->system_data_fields, $sysID);
        if(is_array($success))
        {
            DB::rollBack();
            // abort(428, 'Unable to remove Field '.$success[0]['data_field_name'].' - it is still in use by some customers');
        }
        DB::commit();
        return $success;
    }

    public function deleteEquipment($sysID)
    {
        try
        {
            SystemTypes::find($sysID)->delete();
        }
        catch(\Illuminate\Database\QueryException $e)
        {
            Log::error('Unable to delete Equipment ID '.$this->sysID.'.  Reason - ', array($e));
            return false;
        }

        return true;
    }
}


1		<?php
2
3		namespace App\Domains\Equipment;
4
5		use App\SystemTypes;
6
7		use Illuminate\Support\Facades\DB;
8		use Illuminate\Support\Facades\Log;
9
10
11		class SetEquipment extends SetEquipmentDataFields
12		{
13	3	public function createEquipment($request)
14		{
15	3	$newEquip = SystemTypes::create([
16	3	'cat_id' => $request->cat_id,
17	3	'name' => $request->name,
18	3	'folder_location' => $request->name,
19		]);
20	3	$this->createEquipmentFields($request->system_data_fields, $newEquip->sys_id);
21
22	3	return true;
23		}
24
25	8	public function updateEquipment($request, $sysID)
26		{
27	8	$equip = SystemTypes::findOrFail($sysID);
28	8	DB::beginTransaction();
29
30	8	$equip->update([
31	8	'name' => $request->name,
32		]);
33	8	$success = $this->updateEquipFields($request->system_data_fields, $sysID);
34	8	if(is_array($success))
35		{
36	4	DB::rollBack();
37		// abort(428, 'Unable to remove Field '.$success[0]['data_field_name'].' - it is still in use by some customers');
38		}
39	8	DB::commit();
40	8	return $success;
41		}
42
43	8	public function deleteEquipment($sysID)
44		{
45		try
46		{
47	8	SystemTypes::find($sysID)->delete();
48		}
49	4	catch(\Illuminate\Database\QueryException $e)
50		{
51	4	Log::error('Unable to delete Equipment ID '.$this->sysID.'. Reason - ', array($e));
52	4	return false;
53		}
54
55	4	return true;
56		}
57		}
58

butcherman / Tech_Bench

Push — dev5a ( 668142...386e30 )

SetEquipment::updateEquipment() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like