Conditions | 1 |
Paths | 1 |
Total Lines | 320 |
Code Lines | 265 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
13 | public function run() |
||
14 | { |
||
15 | // Test Data |
||
16 | $field = new SystemCustDataFields(); |
||
17 | $field->sys_id = 1; |
||
1 ignored issue
–
show
|
|||
18 | $field->data_type_id = 1; |
||
1 ignored issue
–
show
|
|||
19 | $field->order = 0; |
||
1 ignored issue
–
show
|
|||
20 | $field->save(); |
||
21 | |||
22 | $field = new SystemCustDataFields(); |
||
23 | $field->sys_id = 2; |
||
24 | $field->data_type_id = 2; |
||
25 | $field->order = 0; |
||
26 | $field->save(); |
||
27 | |||
28 | $field = new SystemCustDataFields(); |
||
29 | $field->sys_id = 2; |
||
30 | $field->data_type_id = 1; |
||
31 | $field->order = 1; |
||
32 | $field->save(); |
||
33 | |||
34 | $field = new SystemCustDataFields(); |
||
35 | $field->sys_id = 2; |
||
36 | $field->data_type_id = 5; |
||
37 | $field->order = 2; |
||
38 | $field->save(); |
||
39 | |||
40 | $field = new SystemCustDataFields(); |
||
41 | $field->sys_id = 3; |
||
42 | $field->data_type_id = 2; |
||
43 | $field->order = 0; |
||
44 | $field->save(); |
||
45 | |||
46 | $field = new SystemCustDataFields(); |
||
47 | $field->sys_id = 3; |
||
48 | $field->data_type_id = 1; |
||
49 | $field->order = 1; |
||
50 | $field->save(); |
||
51 | |||
52 | $field = new SystemCustDataFields(); |
||
53 | $field->sys_id = 3; |
||
54 | $field->data_type_id = 5; |
||
55 | $field->order = 2; |
||
56 | $field->save(); |
||
57 | |||
58 | $field = new SystemCustDataFields(); |
||
59 | $field->sys_id = 4; |
||
60 | $field->data_type_id = 2; |
||
61 | $field->order = 0; |
||
62 | $field->save(); |
||
63 | |||
64 | $field = new SystemCustDataFields(); |
||
65 | $field->sys_id = 4; |
||
66 | $field->data_type_id = 1; |
||
67 | $field->order = 1; |
||
68 | $field->save(); |
||
69 | |||
70 | $field = new SystemCustDataFields(); |
||
71 | $field->sys_id = 4; |
||
72 | $field->data_type_id = 5; |
||
73 | $field->order = 2; |
||
74 | $field->save(); |
||
75 | |||
76 | $field = new SystemCustDataFields(); |
||
77 | $field->sys_id = 5; |
||
78 | $field->data_type_id = 2; |
||
79 | $field->order = 0; |
||
80 | $field->save(); |
||
81 | |||
82 | $field = new SystemCustDataFields(); |
||
83 | $field->sys_id = 6; |
||
84 | $field->data_type_id = 2; |
||
85 | $field->order = 0; |
||
86 | $field->save(); |
||
87 | |||
88 | $field = new SystemCustDataFields(); |
||
89 | $field->sys_id = 7; |
||
90 | $field->data_type_id = 2; |
||
91 | $field->order = 0; |
||
92 | $field->save(); |
||
93 | |||
94 | $field = new SystemCustDataFields(); |
||
95 | $field->sys_id = 7; |
||
96 | $field->data_type_id = 1; |
||
97 | $field->order = 1; |
||
98 | $field->save(); |
||
99 | |||
100 | $field = new SystemCustDataFields(); |
||
101 | $field->sys_id = 7; |
||
102 | $field->data_type_id = 6; |
||
103 | $field->order = 2; |
||
104 | $field->save(); |
||
105 | |||
106 | $field = new SystemCustDataFields(); |
||
107 | $field->sys_id = 7; |
||
108 | $field->data_type_id = 7; |
||
109 | $field->order = 3; |
||
110 | $field->save(); |
||
111 | |||
112 | $field = new SystemCustDataFields(); |
||
113 | $field->sys_id = 7; |
||
114 | $field->data_type_id = 3; |
||
115 | $field->order = 4; |
||
116 | $field->save(); |
||
117 | |||
118 | $field = new SystemCustDataFields(); |
||
119 | $field->sys_id = 7; |
||
120 | $field->data_type_id = 4; |
||
121 | $field->order = 5; |
||
122 | $field->save(); |
||
123 | |||
124 | $field = new SystemCustDataFields(); |
||
125 | $field->sys_id = 8; |
||
126 | $field->data_type_id = 2; |
||
127 | $field->order = 0; |
||
128 | $field->save(); |
||
129 | |||
130 | $field = new SystemCustDataFields(); |
||
131 | $field->sys_id = 8; |
||
132 | $field->data_type_id = 1; |
||
133 | $field->order = 1; |
||
134 | $field->save(); |
||
135 | |||
136 | $field = new SystemCustDataFields(); |
||
137 | $field->sys_id = 8; |
||
138 | $field->data_type_id = 6; |
||
139 | $field->order = 2; |
||
140 | $field->save(); |
||
141 | |||
142 | $field = new SystemCustDataFields(); |
||
143 | $field->sys_id = 8; |
||
144 | $field->data_type_id = 7; |
||
145 | $field->order = 3; |
||
146 | $field->save(); |
||
147 | |||
148 | $field = new SystemCustDataFields(); |
||
149 | $field->sys_id = 8; |
||
150 | $field->data_type_id = 3; |
||
151 | $field->order = 4; |
||
152 | $field->save(); |
||
153 | |||
154 | $field = new SystemCustDataFields(); |
||
155 | $field->sys_id = 8; |
||
156 | $field->data_type_id = 4; |
||
157 | $field->order = 5; |
||
158 | $field->save(); |
||
159 | |||
160 | $field = new SystemCustDataFields(); |
||
161 | $field->sys_id = 9; |
||
162 | $field->data_type_id = 2; |
||
163 | $field->order = 0; |
||
164 | $field->save(); |
||
165 | |||
166 | $field = new SystemCustDataFields(); |
||
167 | $field->sys_id = 10; |
||
168 | $field->data_type_id = 2; |
||
169 | $field->order = 0; |
||
170 | $field->save(); |
||
171 | |||
172 | $field = new SystemCustDataFields(); |
||
173 | $field->sys_id = 10; |
||
174 | $field->data_type_id = 1; |
||
175 | $field->order = 1; |
||
176 | $field->save(); |
||
177 | |||
178 | $field = new SystemCustDataFields(); |
||
179 | $field->sys_id = 10; |
||
180 | $field->data_type_id = 6; |
||
181 | $field->order = 2; |
||
182 | $field->save(); |
||
183 | |||
184 | $field = new SystemCustDataFields(); |
||
185 | $field->sys_id = 10; |
||
186 | $field->data_type_id = 7; |
||
187 | $field->order = 3; |
||
188 | $field->save(); |
||
189 | |||
190 | $field = new SystemCustDataFields(); |
||
191 | $field->sys_id = 11; |
||
192 | $field->data_type_id = 2; |
||
193 | $field->order = 0; |
||
194 | $field->save(); |
||
195 | |||
196 | $field = new SystemCustDataFields(); |
||
197 | $field->sys_id = 11; |
||
198 | $field->data_type_id = 1; |
||
199 | $field->order = 1; |
||
200 | $field->save(); |
||
201 | |||
202 | $field = new SystemCustDataFields(); |
||
203 | $field->sys_id = 11; |
||
204 | $field->data_type_id = 6; |
||
205 | $field->order = 2; |
||
206 | $field->save(); |
||
207 | |||
208 | $field = new SystemCustDataFields(); |
||
209 | $field->sys_id = 11; |
||
210 | $field->data_type_id = 7; |
||
211 | $field->order = 3; |
||
212 | $field->save(); |
||
213 | |||
214 | $field = new SystemCustDataFields(); |
||
215 | $field->sys_id = 12; |
||
216 | $field->data_type_id = 2; |
||
217 | $field->order = 0; |
||
218 | $field->save(); |
||
219 | |||
220 | $field = new SystemCustDataFields(); |
||
221 | $field->sys_id = 12; |
||
222 | $field->data_type_id = 1; |
||
223 | $field->order = 1; |
||
224 | $field->save(); |
||
225 | |||
226 | $field = new SystemCustDataFields(); |
||
227 | $field->sys_id = 12; |
||
228 | $field->data_type_id = 6; |
||
229 | $field->order = 2; |
||
230 | $field->save(); |
||
231 | |||
232 | $field = new SystemCustDataFields(); |
||
233 | $field->sys_id = 12; |
||
234 | $field->data_type_id = 7; |
||
235 | $field->order = 3; |
||
236 | $field->save(); |
||
237 | |||
238 | $field = new SystemCustDataFields(); |
||
239 | $field->sys_id = 13; |
||
240 | $field->data_type_id = 2; |
||
241 | $field->order = 0; |
||
242 | $field->save(); |
||
243 | |||
244 | $field = new SystemCustDataFields(); |
||
245 | $field->sys_id = 13; |
||
246 | $field->data_type_id = 1; |
||
247 | $field->order = 1; |
||
248 | $field->save(); |
||
249 | |||
250 | $field = new SystemCustDataFields(); |
||
251 | $field->sys_id = 13; |
||
252 | $field->data_type_id = 6; |
||
253 | $field->order = 2; |
||
254 | $field->save(); |
||
255 | |||
256 | $field = new SystemCustDataFields(); |
||
257 | $field->sys_id = 13; |
||
258 | $field->data_type_id = 7; |
||
259 | $field->order = 3; |
||
260 | $field->save(); |
||
261 | |||
262 | $field = new SystemCustDataFields(); |
||
263 | $field->sys_id = 14; |
||
264 | $field->data_type_id = 2; |
||
265 | $field->order = 0; |
||
266 | $field->save(); |
||
267 | |||
268 | $field = new SystemCustDataFields(); |
||
269 | $field->sys_id = 14; |
||
270 | $field->data_type_id = 1; |
||
271 | $field->order = 1; |
||
272 | $field->save(); |
||
273 | |||
274 | $field = new SystemCustDataFields(); |
||
275 | $field->sys_id = 14; |
||
276 | $field->data_type_id = 6; |
||
277 | $field->order = 2; |
||
278 | $field->save(); |
||
279 | |||
280 | $field = new SystemCustDataFields(); |
||
281 | $field->sys_id = 14; |
||
282 | $field->data_type_id = 7; |
||
283 | $field->order = 3; |
||
284 | $field->save(); |
||
285 | |||
286 | $field = new SystemCustDataFields(); |
||
287 | $field->sys_id = 15; |
||
288 | $field->data_type_id = 2; |
||
289 | $field->order = 0; |
||
290 | $field->save(); |
||
291 | |||
292 | $field = new SystemCustDataFields(); |
||
293 | $field->sys_id = 15; |
||
294 | $field->data_type_id = 1; |
||
295 | $field->order = 1; |
||
296 | $field->save(); |
||
297 | |||
298 | $field = new SystemCustDataFields(); |
||
299 | $field->sys_id = 15; |
||
300 | $field->data_type_id = 6; |
||
301 | $field->order = 2; |
||
302 | $field->save(); |
||
303 | |||
304 | $field = new SystemCustDataFields(); |
||
305 | $field->sys_id = 15; |
||
306 | $field->data_type_id = 7; |
||
307 | $field->order = 3; |
||
308 | $field->save(); |
||
309 | |||
310 | $field = new SystemCustDataFields(); |
||
311 | $field->sys_id = 16; |
||
312 | $field->data_type_id = 2; |
||
313 | $field->order = 0; |
||
314 | $field->save(); |
||
315 | |||
316 | $field = new SystemCustDataFields(); |
||
317 | $field->sys_id = 16; |
||
318 | $field->data_type_id = 1; |
||
319 | $field->order = 1; |
||
320 | $field->save(); |
||
321 | |||
322 | $field = new SystemCustDataFields(); |
||
323 | $field->sys_id = 16; |
||
324 | $field->data_type_id = 6; |
||
325 | $field->order = 2; |
||
326 | $field->save(); |
||
327 | |||
328 | $field = new SystemCustDataFields(); |
||
329 | $field->sys_id = 16; |
||
330 | $field->data_type_id = 7; |
||
331 | $field->order = 3; |
||
332 | $field->save(); |
||
333 | } |
||
335 |
Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct.