SetCustomerNotes::createNewNote() - Code Metrics - Inspection of "Updated Customer Notes Section" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Push — dev5a ( 276986...e86993 )

by Ron

created 2020-06-21 19:00 UTC

SetCustomerNotes::createNewNote() A

↳ Parent: SetCustomerNotes

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	12
c	1
b	0
f	0
nc	3
nop	3
dl	0
loc	21
rs	9.8666

<?php

namespace App\Domains\Customers;

use App\CustomerNotes;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Log;


class SetCustomerNotes extends GetCustomerDetails
{
    public function createNewNote($request, $custID, $userID)
    {
        if($request->shared)
        {
            $parent = $this->getParentID($custID);
            if($parent)
            {
                $custID = $parent;
            }
        }

        CustomerNotes::create([
            'cust_id'     => $custID,
            'user_id'     => $userID,
            'shared'      => $request->shared,
            'urgent'      => $request->urgent,
            'subject'     => $request->subject,
            'description' => $request->description,
        ]);

        return true;
    }

    public function updateNote($request, $custID, $noteID)
    {
        if($request->shared)
        {
            $parent = $this->getParentID($custID);
            if($parent)
            {
                $custID = $parent;
            }
        }

        CustomerNotes::find($noteID)->update([
            'cust_id'     => $custID,
            'shared'      => $request->shared,
            'urgent'      => $request->urgent,
            'subject'     => $request->subject,
            'description' => $request->description,
        ]);

        return true;
    }

    public function deleteNote($noteID)
    {
        CustomerNotes::find($noteID)->delete();
        return true;
    }
}


1			<?php
2
3			namespace App\Domains\Customers;
4
5			use App\CustomerNotes;
6			use Illuminate\Support\Facades\Auth;
7			use Illuminate\Support\Facades\Log;
8
9
10			class SetCustomerNotes extends GetCustomerDetails
11			{
12			public function createNewNote($request, $custID, $userID)
13			{
14			if($request->shared)
15			{
16			$parent = $this->getParentID($custID);
17			if($parent)
18			{
19			$custID = $parent;
20			}
21			}
22
23			CustomerNotes::create([
24			'cust_id' => $custID,
25			'user_id' => $userID,
26			'shared' => $request->shared,
27			'urgent' => $request->urgent,
28			'subject' => $request->subject,
29			'description' => $request->description,
30			]);
31
32			return true;
33			}
34
35			public function updateNote($request, $custID, $noteID)
36			{
37			if($request->shared)
38			{
39			$parent = $this->getParentID($custID);
40			if($parent)
41			{
42			$custID = $parent;
43			}
44			}
45
46			CustomerNotes::find($noteID)->update([
47			'cust_id' => $custID,
48			'shared' => $request->shared,
49			'urgent' => $request->urgent,
50			'subject' => $request->subject,
51			'description' => $request->description,
52			]);
53
54			return true;
55			}
56
57			public function deleteNote($noteID)
58			{
59			CustomerNotes::find($noteID)->delete();
60			return true;
61			}
62			}
63

butcherman / Tech_Bench

Push — dev5a ( 276986...e86993 )

SetCustomerNotes::createNewNote() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like