UserNotifications::deleteNotification() - Code Metrics - Inspection of "Removed Feature Tests - Rewriting for Unit Tests" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5 ( 125e24...928bc2 )

by Ron

created 2020-05-15 23:42 UTC

UserNotifications::deleteNotification() A

↳ Parent: UserNotifications

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	4
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	7
ccs	0
cts	5
cp	0
crap	2
rs	10

<?php

namespace App\Domains\Users;

use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;

class UserNotifications
{
    public function markNotificationRead($id)
    {
        $notification = Auth::user()->notifications()->where('id', $id)->where('notifiable_id', Auth::user()->user_id)->first();
        Log::debug('Marked user notification as read for '.Auth::user()->full_name.'. Data - ', array($notification));
        $notification->markAsRead();

        return true;
    }

    public function deleteNotification($id)
    {
        $notification = Auth::user()->notifications()->where('id', $id)->where('notifiable_id', Auth::user()->user_id)->first();
        Log::debug('Deleted user notification for '.Auth::user()->full_name.'. Data - ', array($notification));
        $notification->delete();

        return true;
    }

}


1			<?php
2
3			namespace App\Domains\Users;
4
5			use Illuminate\Support\Facades\Log;
6			use Illuminate\Support\Facades\Auth;
7
8			class UserNotifications
9			{
10			public function markNotificationRead($id)
11			{
12			$notification = Auth::user()->notifications()->where('id', $id)->where('notifiable_id', Auth::user()->user_id)->first();
13			Log::debug('Marked user notification as read for '.Auth::user()->full_name.'. Data - ', array($notification));
14			$notification->markAsRead();
15
16			return true;
17			}
18
19			public function deleteNotification($id)
20			{
21			$notification = Auth::user()->notifications()->where('id', $id)->where('notifiable_id', Auth::user()->user_id)->first();
22			Log::debug('Deleted user notification for '.Auth::user()->full_name.'. Data - ', array($notification));
23			$notification->delete();
24
25			return true;
26			}
27
28			}
29

butcherman / Tech_Bench

Push — dev5 ( 125e24...928bc2 )

UserNotifications::deleteNotification() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like