CustomerDetailsController::details() - Code Metrics - Inspection of "Updated CustomerAdminController.php" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5 ( 1140b1...da16e0 )

by Ron

created 2020-04-09 02:26 UTC

CustomerDetailsController::details() B

↳ Parent: CustomerDetailsController

Complexity

Conditions	6
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	18
cts	18
cp	1
rs	8.8817
c	0
b	0
f	0
cc	6
nc	3
nop	2
crap	6

<?php

namespace App\Http\Controllers\Customers;

use App\Customers;
use App\CustomerFavs;
use App\PhoneNumberTypes;
use App\CustomerFileTypes;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Route;
use App\Http\Resources\PhoneNumberTypesCollection;
use App\Http\Resources\CustomerFileTypesCollection;

class CustomerDetailsController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }

    //  New Customer Form
    public function create()

    {
        $this->authorize('hasAccess', 'Add Customer');

        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        return view('customer.newCustomer');
    }

    //  Submit the new customer form
    public function store(Request $request)
    {
        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name.'. Submitted Data - ', $request->toArray());
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->authorize('hasAccess', 'Add Customer');

        $request->validate([

            'cust_id'   => 'nullable|numeric|unique:customers,cust_id',
            'parent_id' => 'nullable|numeric|exists:customers,cust_id',
            'name'      => 'required',
            'dba_name'  => 'nullable',
            'address'   => 'required',
            'city'      => 'required',
            'zip'       => 'required|numeric'
        ]);

        //  Remove any forward slash (/) from the Customer name field
        $request->merge(['name' => str_replace('/', '-', $request->name)]);

        //  Check if the parent ID noted, has a parent of its own
        if($request->parent_id)
        {
            $parentsParent = Customers::find($request->parent_id);

            if($parentsParent->parent_id)
            {
                $request->parent_id = $parentsParent->parent_id;
            }
        }

        $custData = Customers::create([

            'cust_id'   => $request->cust_id,
            'parent_id' => $request->parent_id,
            'name'      => $request->name,
            'dba_name'  => $request->dba_name,
            'address'   => $request->address,
            'city'      => $request->city,
            'state'     => $request->selectedState,
            'zip'       => $request->zip,
        ]);

        Log::notice('New Customer ID-'.$request->custID.' created by '.Auth::user()->full_name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        return response()->json(['success' => true, 'cust_id' => $custData->cust_id]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    //  Show the customer details
    public function details($id, $name)
    {
        $custDetails = Customers::find($id);

        if($custDetails === null)
        {
            Log::info('User - '.Auth::user()->user_id.' visited invalid customer ID - '.$id.' - '.$name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return view('customer.customerNotFound');
        }

        $custFav   = CustomerFavs::where('user_id', Auth::user()->user_id)->where('cust_id', $custDetails->cust_id)->first();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $numTypes  = new PhoneNumberTypesCollection(PhoneNumberTypes::all());
        $fileTypes = new CustomerFileTypesCollection(CustomerFileTypes::all());
        $parent    = $custDetails->parent_id ? Customers::find($custDetails->parent_id)->name : null;

        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        return view('customer.details', [
            'cust_id'     => $custDetails->cust_id,
            'details'     => $custDetails->toJson(),
            'isFav'       => empty($custFav) ? 'false' : 'true',
            'numberTypes' => $numTypes,
            'fileTypes'   => $fileTypes,
            'parent'      => $parent,
            'linked'      => $custDetails->child_count || $parent ? 'true' : 'false',
        ]);
    }

    //  Update the customer details
    public function update(Request $request, $id)
    {
        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name.'. Submitted Data - ', $request->toArray());
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $request->validate([

            'name'     => 'required',
            'dba_name' => 'nullable',
            'address'  => 'required',
            'city'     => 'required',
            'state'    => 'required',
            'zip'      => 'required|numeric'
        ]);

        Customers::find($id)->update([
            'name'     => $request->name,
            'dba_name' => $request->dba_name,
            'address'  => $request->address,
            'city'     => $request->city,
            'state'    => $request->state,
            'zip'      => $request->zip
        ]);

        Log::info('Customer Details Updated for Customer ID-'.$id.' by User ID-'.Auth::user()->user_id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'success' => true
        ]);
    }

    //  Link a site to a parent site
    public function linkParent(Request $request)
    {
        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name.'. Submitted Data - ', $request->toArray());
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $request->validate([

            'parent_id' => 'required|numeric|exists:customers,cust_id',
            'cust_id'   => 'required|numeric|exists:customers,cust_id'
        ]);

        $parentsParent = Customers::find($request->parent_id);

        if($parentsParent->parent_id)
        {
            $request->parent_id = $parentsParent->parent_id;
        }

        Customers::find($request->cust_id)->update([
            'parent_id' => $request->parent_id,
        ]);

        Log::info('Customer ID '.$request->cust_id.' was linked to parent ID '.$request->parent_id.' by '.Auth::user()->full_name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        return response()->json(['success' => true]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }


    public function removeParent($id)
    {
        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        Customers::find($id)->update(['parent_id' => null]);
        Log::info('Parent Customer ID was removed for Customer ID '.$id.' by '.Auth::user()->full_name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    //  Deactivate a customer - note this will not remove it from the database, but make it inaccessable
    public function destroy($id)
    {
        Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->authorize('hasAccess', 'Deactivate Customer');

        //  Remove the customer from any users favorites
        CustomerFavs::where('cust_id', $id)->delete();

        //  Disable the tip
        Customers::destroy($id);

        Log::notice('User - '.Auth::user()->full_name.' has deactivated Customer ID '.$id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }
}


Push — dev5 ( 1140b1...da16e0 )

CustomerDetailsController::details() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Http\Controllers\Customers;
4
5			use App\Customers;
6			use App\CustomerFavs;
7			use App\PhoneNumberTypes;
8			use App\CustomerFileTypes;
9			use Illuminate\Http\Request;
10			use Illuminate\Support\Facades\Log;
11			use Illuminate\Support\Facades\Auth;
12			use App\Http\Controllers\Controller;
13			use Illuminate\Support\Facades\Route;
14			use App\Http\Resources\PhoneNumberTypesCollection;
15			use App\Http\Resources\CustomerFileTypesCollection;
16
17			class CustomerDetailsController extends Controller
18			{
19	44		public function __construct()
20			{
21	44		$this->middleware('auth');
22	44		}
23
24			// New Customer Form
25	4	View Code Duplication	public function create()
			0 ignored issues – show Duplication introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26			{
27	4		$this->authorize('hasAccess', 'Add Customer');
28
29	2		Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name);
			0 ignored issues – show Bug introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report Accessing `full_name` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
30	2		return view('customer.newCustomer');
31			}
32
33			// Submit the new customer form
34	10		public function store(Request $request)
35			{
36	10		Log::debug('Route '.Route::currentRouteName().' visited by '.Auth::user()->full_name.'. Submitted Data - ', $request->toArray());
			0 ignored issues – show Bug introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report Accessing `full_name` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37	10		$this->authorize('hasAccess', 'Add Customer');

butcherman / Tech_Bench

Push — dev5 ( 1140b1...da16e0 )

CustomerDetailsController::details() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like