Customers - Code Metrics - Inspection of "Updated CustomerAdminController.php" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5 ( 1140b1...da16e0 )

by Ron

created 2020-04-09 02:26 UTC

Customers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	2
dl	0
loc	22
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	CustomerSystems()	0	4	1
A	getChildCountAttribute()	0	4	1

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;

class Customers extends Model
{
    use SoftDeletes;

    protected $primaryKey = 'cust_id';
    protected $fillable   = ['cust_id', 'parent_id', 'name', 'dba_name', 'address', 'city', 'state', 'zip', 'active'];
    protected $hidden     = ['created_at', 'deleted_at', 'updated_at'];
    protected $appends    = ['child_count'];
    protected $casts      = [
        'deleted_at' => 'datetime:M d, Y',
    ];

    public function CustomerSystems()
    {
        return $this->hasMany('App\CustomerSystems', 'cust_id', 'cust_id');
    }

    public function getChildCountAttribute()
    {
        return Customers::where('parent_id', $this->cust_id)->count();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1		<?php
2
3		namespace App;
4
5		use Illuminate\Database\Eloquent\Model;
6		use Illuminate\Database\Eloquent\SoftDeletes;
7
8		class Customers extends Model
9		{
10		use SoftDeletes;
11
12		protected $primaryKey = 'cust_id';
13		protected $fillable = ['cust_id', 'parent_id', 'name', 'dba_name', 'address', 'city', 'state', 'zip', 'active'];
14		protected $hidden = ['created_at', 'deleted_at', 'updated_at'];
15		protected $appends = ['child_count'];
16		protected $casts = [
17		'deleted_at' => 'datetime:M d, Y',
18		];
19
20	16	public function CustomerSystems()
21		{
22	16	return $this->hasMany('App\CustomerSystems', 'cust_id', 'cust_id');
23		}
24
25	18	public function getChildCountAttribute()
26		{
27	18	return Customers::where('parent_id', $this->cust_id)->count();
		0 ignored issues – show Documentation introduced 2020-04-09 02:35 UTC by Report Bug Copy Issue Report The property `cust_id` does not exist on `object<App\Customers>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28		}
29		}
30

butcherman / Tech_Bench

Push — dev5 ( 1140b1...da16e0 )

Customers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like