App\Http\Controllers\DownloadController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	14	3
A	downloadFile()	0	26	2

<?php

namespace App\Http\Controllers;

use App\Domains\Files\GetFiles;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Log;

class DownloadController extends Controller
{
    public function index($fileID, $fileName)
    {
        $fileObj = new GetFiles;
        if(!$path = $fileObj->validateFile($fileID, $fileName))
        {
            abort(404, 'The file you are looking for cannot be found');
        }

        if(!$fileObj->canUserDownload($fileID, Auth::check()))
        {
            abort(403, 'You do not have permission to download this file');
        }

        $this->downloadFile(config('filesystems.disks.local.root').DIRECTORY_SEPARATOR.$path);

Are you sure $path of type false|string can be used in concatenation?

    }

    //  Download the file in chunks to allow for large file download
    protected function downloadFile($path)
    {
        $fileName = basename($path);

        //  Prepare header information for file download
        header('Content-Description:  File Transfer');
        // header('Content-Type:  '.$fileData->mime_type);
        header('Content-Type: application/octet-stream');
        header('Content-Disposition: attachment; filename='.basename($fileName));
        header('Content-Transfer-Encoding:  binary');
        header('Expires:  0');
        header('Cache-Control:  must-revalidate, post-check=0, pre-check=0');
        header('Pragma:  public');
        header('Content-Length:  '.filesize($path));

        //  Begin the file download.  File is broken into sections to better be handled by browser
        set_time_limit(0);
        $file = fopen($path, "rb");
        while(!feof($file))

It seems like $file can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

        {
            print(@fread($file, 1024 * 8));

It seems like $file can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

            ob_flush();
            flush();
        }

        return true;
    }
}