DownloadContactController::__invoke() - Code Metrics - Inspection of "Updated Customer Contacts" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev6 ( 98cfbc...9c7079 )

by Ron

created 2021-09-11 18:29 UTC

DownloadContactController::__invoke() A

↳ Parent: DownloadContactController

Complexity

Conditions	4
Paths	3

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	14
c	2
b	0
f	0
dl	0
loc	25
ccs	0
cts	13
cp	0
rs	9.7998
cc	4
nc	3
nop	1
crap	20

<?php

namespace App\Http\Controllers\Customers;

use JeroenDesloovere\VCard\VCard;

use App\Models\Customer;
use App\Models\CustomerContact;
use App\Http\Controllers\Controller;
use App\Events\Customers\CustomerContactDownloadedEvent;

class DownloadContactController extends Controller
{
    /**
     * Download a customer contact in v-card format
     */
    public function __invoke($contID)
    {
        $contact  = CustomerContact::findOrFail($contID);
        $customer = Customer::find($contact->cust_id);
        $name     = explode(' ', $contact->name);

        //  Build the VCard
        $vcard = new VCard();
        $vcard->addName(isset($name[1]) ? $name[1] : null, $name[0]);
        $vcard->addCompany($customer->name);
        $vcard->addAddress(null, null, $customer->address, $customer->city, $customer->state, $customer->zip, null);

        //  Add phone numbers to the VCard
        foreach($contact->CustomerContactPhone as $phone)
        {
            $number = $phone->readable;
            if($phone->extension)
            {
                $number .= ', '.$phone->extension;
            }
            $vcard->addPhoneNumber($number, $phone->type_name);
        }

        event(new CustomerContactDownloadedEvent($customer, $contact));
        return $vcard->download();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Customers;
4
5			use JeroenDesloovere\VCard\VCard;
6
7			use App\Models\Customer;
8			use App\Models\CustomerContact;
9			use App\Http\Controllers\Controller;
10			use App\Events\Customers\CustomerContactDownloadedEvent;
11
12			class DownloadContactController extends Controller
13			{
14			/**
15			* Download a customer contact in v-card format
16			*/
17			public function __invoke($contID)
18			{
19			$contact = CustomerContact::findOrFail($contID);
20			$customer = Customer::find($contact->cust_id);
21			$name = explode(' ', $contact->name);
22
23			// Build the VCard
24			$vcard = new VCard();
25			$vcard->addName(isset($name[1]) ? $name[1] : null, $name[0]);
26			$vcard->addCompany($customer->name);
27			$vcard->addAddress(null, null, $customer->address, $customer->city, $customer->state, $customer->zip, null);
28
29			// Add phone numbers to the VCard
30			foreach($contact->CustomerContactPhone as $phone)
31			{
32			$number = $phone->readable;
33			if($phone->extension)
34			{
35			$number .= ', '.$phone->extension;
36			}
37			$vcard->addPhoneNumber($number, $phone->type_name);
38			}
39
40			event(new CustomerContactDownloadedEvent($customer, $contact));
41			return $vcard->download();
			1 ignored issue – show Bug introduced 2021-09-11 18:49 UTC by Report Bug Copy Issue Report Are you sure the usage of `$vcard->download()` targeting `JeroenDesloovere\VCard\VCard::download()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
42			}
43			}
44

butcherman / Tech_Bench

Push — dev6 ( 98cfbc...9c7079 )

DownloadContactController::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like