butcherman / Tech_Bench

database/factories/NotificationsFactory.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 // use App\Model;
 use Faker\Generator as Faker;
 
-$factory->define(Illuminate\Notifications\DatabaseNotification::class, function (Faker $faker) {
+$factory->define(Illuminate\Notifications\DatabaseNotification::class, function(Faker $faker) {
     return [
         //
         'id' => $faker->uuid,

database/migrations/2019_11_29_232604_create_failed_jobs_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('failed_jobs', function (Blueprint $table) {
+        Schema::create('failed_jobs', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->text('connection');
             $table->text('queue');

app/Http/Controllers/TechTips/TechTipsController.php

Spacing +23 added lines, -23 removed lines

@@ -51,7 +51,7 @@ 
         Log::debug('request Data -> ', $request->toArray());
 
         //  See if there are any search paramaters entered
-        if (!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType'])) {
+        if(!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType'])) {
             //  No search paramaters, send all tech tips
             $tips = new TechTipsCollection(
                 TechTips::orderBy('created_at', 'DESC')
@@ -60,21 +60,21 @@ 
             );
         } else {
             $article = isset($request->search['articleType']) ? true : false;
-            $system  = isset($request->search['systemType'])  ? true : false;
+            $system  = isset($request->search['systemType']) ? true : false;
             //  Search paramaters, filter results
             $tips = new TechTipsCollection(
                 TechTips::orderBy('created_at', 'DESC')
                     //  Search by id or a phrase in the title or description
-                    ->where(function ($query) use ($request) {
-                        $query->where('subject', 'like', '%' . $request->search['searchText'] . '%')
-                            ->orWhere('tip_id', 'like', '%' . $request->search['searchText'] . '%')
-                            ->orWhere('description', 'like', '%' . $request->search['searchText'] . '%');
+                    ->where(function($query) use ($request) {
+                        $query->where('subject', 'like', '%'.$request->search['searchText'].'%')
+                            ->orWhere('tip_id', 'like', '%'.$request->search['searchText'].'%')
+                            ->orWhere('description', 'like', '%'.$request->search['searchText'].'%');
                     })
-                    ->when($article, function ($query) use ($request) {
+                    ->when($article, function($query) use ($request) {
                         $query->whereIn('tip_type_id', $request->search['articleType']);
                     })
-                    ->when($system, function ($query) use ($request) {
-                        $query->whereHas('SystemTypes', function ($query) use ($request) {
+                    ->when($system, function($query) use ($request) {
+                        $query->whereHas('SystemTypes', function($query) use ($request) {
                             $query->whereIn('system_types.sys_id', $request->search['systemType']);
                         });
                     })
@@ -146,7 +146,7 @@ 
         $save = $receiver->receive();
 
         //  See if the uploade has finished
-        if ($save->isFinished()) {
+        if($save->isFinished()) {
             $this->saveFile($save->getFile());
 
             return 'uploaded successfully';
@@ -155,8 +155,8 @@ 
         //  Get the current progress
         $handler = $save->handler();
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
-        Log::debug('File being uploaded.  Percentage done - ' . $handler->getPercentageDone());
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
+        Log::debug('File being uploaded.  Percentage done - '.$handler->getPercentageDone());
         return response()->json([
             'done'   => $handler->getPercentageDone(),
             'status' => true
@@ -195,7 +195,7 @@ 
         }
 
         //  Log stored file
-        Log::info('File Stored', ['file_id' => $fileID, 'file_path' => $filePath . DIRECTORY_SEPARATOR . $fileName]);
+        Log::info('File Stored', ['file_id' => $fileID, 'file_path' => $filePath.DIRECTORY_SEPARATOR.$fileName]);
         return $fileID;
     }
 
@@ -263,7 +263,7 @@ 
     //  Details controller - will move to the show controller with just the tech tip id
     public function details($id, $subject)
     {
-        if (session()->has('newTipFile')) {
+        if(session()->has('newTipFile')) {
             session()->forget('newTipFile');
         }
 
@@ -293,7 +293,7 @@ 
     //  Add or remove this tip as a favorite of the user
     public function toggleFav($action, $id)
     {
-        switch ($action) {
+        switch($action) {
             case 'add':
                 TechTipFavs::create([
                     'user_id' => Auth::user()->user_id,
@@ -306,7 +306,7 @@ 
                 break;
         }
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         Log::debug('Tech Tip Bookmark Updated.', [
             'user_id' => Auth::user()->user_id,
             'tip_id' => $id,
@@ -321,7 +321,7 @@ 
         $this->authorize('hasAccess', 'Edit Tech Tip');
         $tipData = TechTips::where('tip_id', $id)->with('User')->with('SystemTypes')->with('TechTipTypes')->first();
 
-        if (!$tipData) {
+        if(!$tipData) {
             return view('tips.tipNotFound');
         }
 
@@ -329,7 +329,7 @@ 
         $systemsArr = new SystemCategoriesCollection(SystemCategories::with('SystemTypes')->get());
         $files = TechTipFiles::where('tip_id', $id)->with('Files')->get();
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         return view('tips.editTip', [
             'tipTypes' => $typesArr,
             'sysTypes' => $systemsArr,
@@ -353,9 +353,9 @@ 
         $receiver = new FileReceiver('file', $request, HandlerFactory::classFromRequest($request));
 
         //  Verify if there is a file to be processed or not
-        if ($receiver->isUploaded() === false || $request->_completed) {
+        if($receiver->isUploaded() === false || $request->_completed) {
             $this->storeUpdatedTip($request, $id);
-            Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+            Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
             return response()->json(['tip_id' => $id]);
         }
 
@@ -363,7 +363,7 @@ 
         $save = $receiver->receive();
 
         //  See if the uploade has finished
-        if ($save->isFinished()) {
+        if($save->isFinished()) {
             $this->saveFile($save->getFile(), $id);
 
             return 'uploaded successfully';
@@ -372,8 +372,8 @@ 
         //  Get the current progress
         $handler = $save->handler();
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
-        Log::debug('File being uploaded.  Percentage done - ' . $handler->getPercentageDone());
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
+        Log::debug('File being uploaded.  Percentage done - '.$handler->getPercentageDone());
         return response()->json([
             'done'   => $handler->getPercentageDone(),
             'status' => true

Braces +18 added lines, -10 removed lines

@@ -51,14 +51,17 @@ 
         Log::debug('request Data -> ', $request->toArray());
 
         //  See if there are any search paramaters entered
-        if (!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType'])) {
+        if (!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType']))
+        {
             //  No search paramaters, send all tech tips
             $tips = new TechTipsCollection(
                 TechTips::orderBy('created_at', 'DESC')
                     ->with('SystemTypes')
                     ->paginate($request->pagination['perPage'])
             );
-        } else {
+        }
+        else
+        {
             $article = isset($request->search['articleType']) ? true : false;
             $system  = isset($request->search['systemType'])  ? true : false;
             //  Search paramaters, filter results
@@ -146,7 +149,8 @@ 
         $save = $receiver->receive();
 
         //  See if the uploade has finished
-        if ($save->isFinished()) {
+        if ($save->isFinished())
+        {
             $this->saveFile($save->getFile());
 
             return 'uploaded successfully';
@@ -248,8 +252,7 @@ 
         if(!$tipData->supressEmail)
         {
             $details = TechTips::find($tipID);
-            $users = User::whereHas('UserSettings', function($query)
-            {
+            $users = User::whereHas('UserSettings', function($query) {
                 $query->where('em_tech_tip', 1);
             })->get();
 
@@ -263,7 +266,8 @@ 
     //  Details controller - will move to the show controller with just the tech tip id
     public function details($id, $subject)
     {
-        if (session()->has('newTipFile')) {
+        if (session()->has('newTipFile'))
+        {
             session()->forget('newTipFile');
         }
 
@@ -293,7 +297,8 @@ 
     //  Add or remove this tip as a favorite of the user
     public function toggleFav($action, $id)
     {
-        switch ($action) {
+        switch ($action)
+        {
             case 'add':
                 TechTipFavs::create([
                     'user_id' => Auth::user()->user_id,
@@ -321,7 +326,8 @@ 
         $this->authorize('hasAccess', 'Edit Tech Tip');
         $tipData = TechTips::where('tip_id', $id)->with('User')->with('SystemTypes')->with('TechTipTypes')->first();
 
-        if (!$tipData) {
+        if (!$tipData)
+        {
             return view('tips.tipNotFound');
         }
 
@@ -353,7 +359,8 @@ 
         $receiver = new FileReceiver('file', $request, HandlerFactory::classFromRequest($request));
 
         //  Verify if there is a file to be processed or not
-        if ($receiver->isUploaded() === false || $request->_completed) {
+        if ($receiver->isUploaded() === false || $request->_completed)
+        {
             $this->storeUpdatedTip($request, $id);
             Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
             return response()->json(['tip_id' => $id]);
@@ -363,7 +370,8 @@ 
         $save = $receiver->receive();
 
         //  See if the uploade has finished
-        if ($save->isFinished()) {
+        if ($save->isFinished())
+        {
             $this->saveFile($save->getFile(), $id);
 
             return 'uploaded successfully';

database/factories/UserRoleTypeFactory.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 use App\UserRoleType;
 use Faker\Generator as Faker;
 
-$factory->define(UserRoleType::class, function (Faker $faker) {
+$factory->define(UserRoleType::class, function(Faker $faker) {
     return [
         //
         'name'        => $faker->words(2, true),

database/migrations/2019_11_30_195059_create_user_role_permissions_table.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
      */
     public function up()
     {
-        Schema::create('user_role_permissions', function (Blueprint $table) {
+        Schema::create('user_role_permissions', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('role_id')->unsigned();
             $table->integer('perm_type_id')->unsigned();

database/migrations/2019_11_30_195012_create_user_role_types_table.php

Spacing +5 added lines, -5 removed lines

@@ -16,7 +16,7 @@ 
      */
     public function up()
     {
-        Schema::create('user_role_types', function (Blueprint $table) {
+        Schema::create('user_role_types', function(Blueprint $table) {
             $table->increments('role_id');
             $table->text('name');
             $table->text('description');
@@ -26,10 +26,10 @@ 
 
         //  Insert default data
         DB::table('user_role_types')->insert([
-            ['role_id' => 1, 'name' => 'Installer',     'description' => 'All Access Administrator',    'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['role_id' => 2, 'name' => 'Administrator', 'description' => 'System Administrator',        'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['role_id' => 3, 'name' => 'Reports',       'description' => 'User who can run reports',    'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['role_id' => 4, 'name' => 'Tech',          'description' => 'Standard User',               'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['role_id' => 1, 'name' => 'Installer', 'description' => 'All Access Administrator', 'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['role_id' => 2, 'name' => 'Administrator', 'description' => 'System Administrator', 'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['role_id' => 3, 'name' => 'Reports', 'description' => 'User who can run reports', 'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['role_id' => 4, 'name' => 'Tech', 'description' => 'Standard User', 'allow_edit' => 0, 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
         ]);
 
         //  Update the users table to include the 'user_role' column

Braces +1 added lines, -2 removed lines

@@ -35,8 +35,7 @@
         //  Update the users table to include the 'user_role' column
         if(!Schema::hasColumn('users', 'role_id'))
         {
-            Schema::table('users', function(Blueprint $table)
-            {
+            Schema::table('users', function(Blueprint $table) {
                 $table->integer('role_id')->unsigned()->after('user_id')->default(4);
                 $table->foreign('role_id')->references('role_id')->on('user_role_types')->onUpdate('cascade');
             });

database/migrations/2019_11_30_195040_create_user_role_permission_types_table.php

Spacing +12 added lines, -12 removed lines

@@ -15,7 +15,7 @@ 
      */
     public function up()
     {
-        Schema::create('user_role_permission_types', function (Blueprint $table) {
+        Schema::create('user_role_permission_types', function(Blueprint $table) {
             $table->increments('perm_type_id');
             $table->text('description');
             $table->timestamps();
@@ -23,17 +23,17 @@ 
 
         //  Insert default data
         DB::table('user_role_permission_types')->insert([
-            ['perm_type_id' => 1,  'description' => 'Manage Users',        'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 2,  'description' => 'Manage User Roles',   'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 3,  'description' => 'Run Reports',         'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 4,  'description' => 'Add Customer',        'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 5,  'description' => 'Manage Customers',    'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 6,  'description' => 'Deactivate Customer', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 7,  'description' => 'Use File Links',      'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 8,  'description' => 'Create Tech Tip',     'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 9,  'description' => 'Edit Tech Tip',       'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 10, 'description' => 'Delete Tech Tip',     'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
-            ['perm_type_id' => 11, 'description' => 'Manage Equipment',    'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 1, 'description' => 'Manage Users', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 2, 'description' => 'Manage User Roles', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 3, 'description' => 'Run Reports', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 4, 'description' => 'Add Customer', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 5, 'description' => 'Manage Customers', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 6, 'description' => 'Deactivate Customer', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 7, 'description' => 'Use File Links', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 8, 'description' => 'Create Tech Tip', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 9, 'description' => 'Edit Tech Tip', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 10, 'description' => 'Delete Tech Tip', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
+            ['perm_type_id' => 11, 'description' => 'Manage Equipment', 'created_at' => Carbon::now(), 'updated_at' => Carbon::now()],
         ]);
     }
 

app/Http/Controllers/Admin/UserController.php

Braces +16 added lines, -7 removed lines

@@ -181,12 +181,18 @@ 
 
         //  Good to go - update user password
         $roleArr = [];
-        foreach ($roles as $role) {
-            if ($role->role_id == 1 && Auth::user()->role_id != 1) {
+        foreach ($roles as $role)
+        {
+            if ($role->role_id == 1 && Auth::user()->role_id != 1)
+            {
                 continue;
-            } else if ($role->role_id == 2 && Auth::user()->role_id > 1) {
+            }
+            else if ($role->role_id == 2 && Auth::user()->role_id > 1)
+            {
                 continue;
-            } else {
+            }
+            else
+            {
                 // $roleArr[$role->role_id] = $role->name;
                 $roleArr[] = [
                     'value' => $role->role_id,
@@ -275,17 +281,20 @@ 
         $user = User::find($request->user_id);
 
         //  Verify this is a valid user ID
-        if (!$user) {
+        if (!$user)
+        {
             $success = false;
             $reason  = 'Cannot find user with this ID';
         }
         //  Make sure that the user is not trying to deactivate someone with more permissions
-        else if ($user->role_id < Auth::user()->role_id) {
+        else if ($user->role_id < Auth::user()->role_id)
+        {
             $success = false;
             $reason  = 'You cannot change password for a user with higher permissions that you.  If this user has locked themselves out, have then use the reset link on the login page.';
         }
         //  Good to go - update user password
-        else {
+        else
+        {
             //  Update the user data
             $user->update(
             [

Spacing +13 added lines, -13 removed lines

@@ -29,7 +29,7 @@ 
     public function __construct()
     {
         $this->middleware('auth')->except('initializeUser', 'submitInitializeUser');
-        $this->middleware(function ($request, $next) {
+        $this->middleware(function($request, $next) {
             $this->authorize('hasAccess', 'Manage Users');
             return $next($request);
         });
@@ -144,7 +144,7 @@ 
     //  List all inactive users
     public function show($type)
     {
-        $route    = '';
+        $route = '';
 
         if($type !== 'inactive')
         {
@@ -168,17 +168,17 @@ 
         $user  = new UserResource(User::findOrFail($id));
 
         //  Make sure that the user is not trying to deactivate someone with more permissions
-        if ($user->role_id < Auth::user()->role_id)
+        if($user->role_id < Auth::user()->role_id)
         {
             return abort(403);
         }
 
         //  Good to go - update user password
         $roleArr = [];
-        foreach ($roles as $role) {
-            if ($role->role_id == 1 && Auth::user()->role_id != 1) {
+        foreach($roles as $role) {
+            if($role->role_id == 1 && Auth::user()->role_id != 1) {
                 continue;
-            } else if ($role->role_id == 2 && Auth::user()->role_id > 1) {
+            } else if($role->role_id == 2 && Auth::user()->role_id > 1) {
                 continue;
             } else {
                 // $roleArr[$role->role_id] = $role->name;
@@ -189,7 +189,7 @@ 
             }
         }
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
         return view('admin.userEdit', [
             'roles' => $roleArr,
             'user'  => $user->
@@ -228,7 +228,7 @@ 
         //  Update the user data
         $user = User::findOrFail($id);
 
-        if ($user->role_id < Auth::user()->role_id)
+        if($user->role_id < Auth::user()->role_id)
         {
             return abort(403);
         }
@@ -271,12 +271,12 @@ 
         $user = User::find($request->user_id);
 
         //  Verify this is a valid user ID
-        if (!$user) {
+        if(!$user) {
             $success = false;
             $reason  = 'Cannot find user with this ID';
         }
         //  Make sure that the user is not trying to deactivate someone with more permissions
-        else if ($user->role_id < Auth::user()->role_id) {
+        else if($user->role_id < Auth::user()->role_id) {
             $success = false;
             $reason  = 'You cannot change password for a user with higher permissions that you.  If this user has locked themselves out, have then use the reset link on the login page.';
         }
@@ -289,11 +289,11 @@ 
                 'password_expires' => $nextChange
             ]);
             $success = true;
-            $reason  = 'Password for ' . $user->full_name . ' successfully reset.';
+            $reason  = 'Password for '.$user->full_name.' successfully reset.';
         }
 
-        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
-        Log::notice('User ID-' . $request->user_id . ' password chagned by ' . Auth::user()->user_id, [
+        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
+        Log::notice('User ID-'.$request->user_id.' password chagned by '.Auth::user()->user_id, [
             'success' => $success,
             'reason'  => $reason,
         ]);

app/Http/Controllers/Installer/CategoriesController.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
     public function __construct()
     {
         $this->middleware('auth');
-        $this->middleware(function ($request, $next) {
+        $this->middleware(function($request, $next) {
             $this->authorize('hasAccess', 'Manage Equipment');
             return $next($request);
         });
@@ -121,7 +121,7 @@ 
             SystemCategories::find($id)->delete();
             return response()->json(['success' => true, 'reason' => 'Category Successfully Deleted']);
         }
-        catch (\Illuminate\Database\QueryException $e)
+        catch(\Illuminate\Database\QueryException $e)
         {
             return response()->json(['success' => false, 'reason' => 'Category still in use.  You must delete all systems attached to this category first.']);
         }

Braces +2 added lines, -1 removed lines

@@ -77,7 +77,8 @@
     //  Delete an existing category - note this will fail if the category has systems assigned to it
     public function destroy($id)
     {
-        try {
+        try
+        {
             SystemCategories::find($id)->delete();
             return response()->json(['success' => true, 'reason' => 'Category Successfully Deleted']);
         }