GetEquipmentData::getAllEquipmentNoCat() - Code Metrics - Inspection of "Dev5" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#83)

by Ron

created 2020-04-28 00:59 UTC

GetEquipmentData::getAllEquipmentNoCat() A

↳ Parent: GetEquipmentData

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	5
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	11
ccs	5
cts	6
cp	0.8333
crap	2.0185
rs	10

<?php

namespace App\Domains\Equipment;

use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;

use App\SystemTypes;
use App\SystemCategories;
use App\Http\Resources\SystemTypesCollection;


class GetEquipmentData
{
    //  Get a list of all equipment, but exclude the category name
    public function getAllEquipmentNoCat($collection = false)
    {
        $sysList = SystemTypes::orderBy('cat_id', 'ASC')->orderBy('name', 'ASC')->get();
        Log::debug('Equipment list gathered without category list.  Data Gathered - ', array($sysList));

        if($collection)
        {
            return new SystemTypesCollection($sysList);
        }

        return $sysList;
    }

    //  Get a list of all equipment along with possible data fields
    public function getAllEquipmentWithDataList()
    {
        $equipList = SystemCategories::with('SystemTypes')->with('SystemTypes.SystemDataFields')->get();
        Log::debug('Equipment list gathered with Data Fields.  Data Gathered - ', array($equipList));

        return $equipList->forget('system_data_field_types');
    }
}


1		<?php
2
3		namespace App\Domains\Equipment;
4
5		use Illuminate\Support\Facades\Log;
6		use Illuminate\Support\Facades\Auth;
7
8		use App\SystemTypes;
9		use App\SystemCategories;
10		use App\Http\Resources\SystemTypesCollection;
11
12
13		class GetEquipmentData
14		{
15		// Get a list of all equipment, but exclude the category name
16	2	public function getAllEquipmentNoCat($collection = false)
17		{
18	2	$sysList = SystemTypes::orderBy('cat_id', 'ASC')->orderBy('name', 'ASC')->get();
19	2	Log::debug('Equipment list gathered without category list. Data Gathered - ', array($sysList));
20
21	2	if($collection)
22		{
23	2	return new SystemTypesCollection($sysList);
24		}
25
26		return $sysList;
27		}
28
29		// Get a list of all equipment along with possible data fields
30	8	public function getAllEquipmentWithDataList()
31		{
32	8	$equipList = SystemCategories::with('SystemTypes')->with('SystemTypes.SystemDataFields')->get();
33	8	Log::debug('Equipment list gathered with Data Fields. Data Gathered - ', array($equipList));
34
35	8	return $equipList->forget('system_data_field_types');
36		}
37		}
38

butcherman / Tech_Bench

Pull Request — master (#83)

GetEquipmentData::getAllEquipmentNoCat() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like