SetUserFavorites::toggleCustomerFavorite() - Code Metrics - Inspection of "Updated Tech Tip Details Page" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev5a ( 915c64...c2cba2 )

by Ron

created 2020-07-06 02:18 UTC

SetUserFavorites::toggleCustomerFavorite() A

↳ Parent: SetUserFavorites

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	10
nc	2
nop	2
dl	0
loc	17
ccs	11
cts	11
cp	1
crap	2
rs	9.9332
c	1
b	0
f	0

<?php

namespace App\Domains\User;

use App\CustomerFavs;
use App\TechTipFavs;
use Illuminate\Support\Facades\Log;

class SetUserFavorites
{
    public function toggleCustomerFavorite($custID, $userID)
    {
        $favData = CustomerFavs::where('cust_id', $custID)->where('user_id', $userID)->first();

        if($favData)
        {
            Log::info('Customer Favorite Removed.  Data - ', ['user_id' => $userID, 'cust_id' => $custID]);
            $favData->delete();
            return false;
        }

        Log::info('Customer Favorite Added.  Data - ', ['user_id' => $userID, 'cust_id' => $custID]);
        CustomerFavs::create([
            'user_id' => $userID,
            'cust_id' => $custID,
        ]);
        return true;
    }

    public function toggleTechTipFavorite($tipID, $userID)
    {
        $favData = TechTipFavs::where('tip_id', $tipID)->where('user_id', $userID)->first();

        if($favData)
        {
            Log::info('Tech Tip Favorite Removed.  Data - ', ['user_id' => $userID, 'tip_id' => $tipID]);
            $favData->delete();
            return false;
        }

        Log::info('Tech Tip Favorite Added.  Data - ', ['user_id' => $userID, 'tip_id' => $tipID]);
        TechTipFavs::create([
            'user_id' => $userID,
            'tip_id' => $tipID,
        ]);
        return true;
    }
}


1		<?php
2
3		namespace App\Domains\User;
4
5		use App\CustomerFavs;
6		use App\TechTipFavs;
7		use Illuminate\Support\Facades\Log;
8
9		class SetUserFavorites
10		{
11	6	public function toggleCustomerFavorite($custID, $userID)
12		{
13	6	$favData = CustomerFavs::where('cust_id', $custID)->where('user_id', $userID)->first();
14
15	6	if($favData)
16		{
17	4	Log::info('Customer Favorite Removed. Data - ', ['user_id' => $userID, 'cust_id' => $custID]);
18	4	$favData->delete();
19	4	return false;
20		}
21
22	4	Log::info('Customer Favorite Added. Data - ', ['user_id' => $userID, 'cust_id' => $custID]);
23	4	CustomerFavs::create([
24	4	'user_id' => $userID,
25	4	'cust_id' => $custID,
26		]);
27	4	return true;
28		}
29
30	6	public function toggleTechTipFavorite($tipID, $userID)
31		{
32	6	$favData = TechTipFavs::where('tip_id', $tipID)->where('user_id', $userID)->first();
33
34	6	if($favData)
35		{
36	4	Log::info('Tech Tip Favorite Removed. Data - ', ['user_id' => $userID, 'tip_id' => $tipID]);
37	4	$favData->delete();
38	4	return false;
39		}
40
41	4	Log::info('Tech Tip Favorite Added. Data - ', ['user_id' => $userID, 'tip_id' => $tipID]);
42	4	TechTipFavs::create([
43	4	'user_id' => $userID,
44	4	'tip_id' => $tipID,
45		]);
46	4	return true;
47		}
48		}
49

butcherman / Tech_Bench

Push — dev5a ( 915c64...c2cba2 )

SetUserFavorites::toggleCustomerFavorite() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like