Passed
Push — dev5 ( df64bd...8206b9 )
by Ron
07:37
created
app/Http/Controllers/Admin/AdminController.php 1 patch
Braces   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -37,8 +37,7 @@  discard block
 block discarded – undo
37 37
         $userLinks = new UserCollection(
38 38
                         User::withCount([
39 39
                                 'FileLinks',
40
-                                'FileLinks as expired_file_links_count' => function($query)
41
-                                {
40
+                                'FileLinks as expired_file_links_count' => function($query) {
42 41
                                     $query->where('expire', '<', Carbon::now());
43 42
                                 }
44 43
                             ])
@@ -84,13 +83,15 @@  discard block
 block discarded – undo
84 83
 
85 84
         //  Determine if the password expires field is updated
86 85
         $oldExpire = config('users.passExpires');
87
-        if ($request->passExpire != $oldExpire) {
86
+        if ($request->passExpire != $oldExpire)
87
+        {
88 88
             //  Update the setting in the database
89 89
             Settings::where('key', 'users.passExpires')->update([
90 90
                 'value' => $request->passExpire
91 91
             ]);
92 92
             //  If the setting is changing from never to xx days, update all users
93
-            if ($request->passExpire == 0) {
93
+            if ($request->passExpire == 0)
94
+            {
94 95
                 User::whereNotNull('password_expires')->update([
95 96
                     'password_expires' => null
96 97
                 ]);
@@ -113,8 +114,7 @@  discard block
 block discarded – undo
113 114
     public function roleSettings()
114 115
     {
115 116
         $this->authorize('hasAccess', 'Manage User Roles');
116
-        $roles = UserRoleType::with(['UserRolePermissions' => function($query)
117
-        {
117
+        $roles = UserRoleType::with(['UserRolePermissions' => function($query) {
118 118
             $query->join('user_role_permission_types', 'user_role_permission_types.perm_type_id', '=', 'user_role_permissions.perm_type_id');
119 119
         }])->get();
120 120
         $perms = UserRolePermissionTypes::all();
Please login to merge, or discard this patch.
app/Http/Controllers/Admin/UserController.php 1 patch
Braces   +16 added lines, -7 removed lines patch added patch discarded remove patch
@@ -181,12 +181,18 @@  discard block
 block discarded – undo
181 181
 
182 182
         //  Good to go - update user password
183 183
         $roleArr = [];
184
-        foreach ($roles as $role) {
185
-            if ($role->role_id == 1 && Auth::user()->role_id != 1) {
184
+        foreach ($roles as $role)
185
+        {
186
+            if ($role->role_id == 1 && Auth::user()->role_id != 1)
187
+            {
186 188
                 continue;
187
-            } else if ($role->role_id == 2 && Auth::user()->role_id > 1) {
189
+            }
190
+            else if ($role->role_id == 2 && Auth::user()->role_id > 1)
191
+            {
188 192
                 continue;
189
-            } else {
193
+            }
194
+            else
195
+            {
190 196
                 // $roleArr[$role->role_id] = $role->name;
191 197
                 $roleArr[] = [
192 198
                     'value' => $role->role_id,
@@ -275,17 +281,20 @@  discard block
 block discarded – undo
275 281
         $user = User::find($request->user_id);
276 282
 
277 283
         //  Verify this is a valid user ID
278
-        if (!$user) {
284
+        if (!$user)
285
+        {
279 286
             $success = false;
280 287
             $reason  = 'Cannot find user with this ID';
281 288
         }
282 289
         //  Make sure that the user is not trying to deactivate someone with more permissions
283
-        else if ($user->role_id < Auth::user()->role_id) {
290
+        else if ($user->role_id < Auth::user()->role_id)
291
+        {
284 292
             $success = false;
285 293
             $reason  = 'You cannot change password for a user with higher permissions that you.  If this user has locked themselves out, have then use the reset link on the login page.';
286 294
         }
287 295
         //  Good to go - update user password
288
-        else {
296
+        else
297
+        {
289 298
             //  Update the user data
290 299
             $user->update(
291 300
             [
Please login to merge, or discard this patch.
app/Http/Controllers/Installer/CategoriesController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,8 @@
 block discarded – undo
117 117
      */
118 118
     public function destroy($id)
119 119
     {
120
-        try {
120
+        try
121
+        {
121 122
             SystemCategories::find($id)->delete();
122 123
             return response()->json(['success' => true, 'reason' => 'Category Successfully Deleted']);
123 124
         }
Please login to merge, or discard this patch.
app/Http/Controllers/TechTips/TechTipsController.php 1 patch
Braces   +18 added lines, -10 removed lines patch added patch discarded remove patch
@@ -51,14 +51,17 @@  discard block
 block discarded – undo
51 51
         Log::debug('request Data -> ', $request->toArray());
52 52
 
53 53
         //  See if there are any search paramaters entered
54
-        if (!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType'])) {
54
+        if (!$request->search['searchText'] && !isset($request->search['articleType']) && !isset($request->search['systemType']))
55
+        {
55 56
             //  No search paramaters, send all tech tips
56 57
             $tips = new TechTipsCollection(
57 58
                 TechTips::orderBy('created_at', 'DESC')
58 59
                     ->with('SystemTypes')
59 60
                     ->paginate($request->pagination['perPage'])
60 61
             );
61
-        } else {
62
+        }
63
+        else
64
+        {
62 65
             $article = isset($request->search['articleType']) ? true : false;
63 66
             $system  = isset($request->search['systemType'])  ? true : false;
64 67
             //  Search paramaters, filter results
@@ -146,7 +149,8 @@  discard block
 block discarded – undo
146 149
         $save = $receiver->receive();
147 150
 
148 151
         //  See if the uploade has finished
149
-        if ($save->isFinished()) {
152
+        if ($save->isFinished())
153
+        {
150 154
             $this->saveFile($save->getFile());
151 155
 
152 156
             return 'uploaded successfully';
@@ -248,8 +252,7 @@  discard block
 block discarded – undo
248 252
         if(!$tipData->supressEmail)
249 253
         {
250 254
             $details = TechTips::find($tipID);
251
-            $users = User::whereHas('UserSettings', function($query)
252
-            {
255
+            $users = User::whereHas('UserSettings', function($query) {
253 256
                 $query->where('em_tech_tip', 1);
254 257
             })->get();
255 258
 
@@ -263,7 +266,8 @@  discard block
 block discarded – undo
263 266
     //  Details controller - will move to the show controller with just the tech tip id
264 267
     public function details($id, $subject)
265 268
     {
266
-        if (session()->has('newTipFile')) {
269
+        if (session()->has('newTipFile'))
270
+        {
267 271
             session()->forget('newTipFile');
268 272
         }
269 273
 
@@ -293,7 +297,8 @@  discard block
 block discarded – undo
293 297
     //  Add or remove this tip as a favorite of the user
294 298
     public function toggleFav($action, $id)
295 299
     {
296
-        switch ($action) {
300
+        switch ($action)
301
+        {
297 302
             case 'add':
298 303
                 TechTipFavs::create([
299 304
                     'user_id' => Auth::user()->user_id,
@@ -321,7 +326,8 @@  discard block
 block discarded – undo
321 326
         $this->authorize('hasAccess', 'Edit Tech Tip');
322 327
         $tipData = TechTips::where('tip_id', $id)->with('User')->with('SystemTypes')->with('TechTipTypes')->first();
323 328
 
324
-        if (!$tipData) {
329
+        if (!$tipData)
330
+        {
325 331
             return view('tips.tipNotFound');
326 332
         }
327 333
 
@@ -353,7 +359,8 @@  discard block
 block discarded – undo
353 359
         $receiver = new FileReceiver('file', $request, HandlerFactory::classFromRequest($request));
354 360
 
355 361
         //  Verify if there is a file to be processed or not
356
-        if ($receiver->isUploaded() === false || $request->_completed) {
362
+        if ($receiver->isUploaded() === false || $request->_completed)
363
+        {
357 364
             $this->storeUpdatedTip($request, $id);
358 365
             Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
359 366
             return response()->json(['tip_id' => $id]);
@@ -363,7 +370,8 @@  discard block
 block discarded – undo
363 370
         $save = $receiver->receive();
364 371
 
365 372
         //  See if the uploade has finished
366
-        if ($save->isFinished()) {
373
+        if ($save->isFinished())
374
+        {
367 375
             $this->saveFile($save->getFile(), $id);
368 376
 
369 377
             return 'uploaded successfully';
Please login to merge, or discard this patch.
database/migrations/2019_11_30_215206_updates_for_version_5_0.php 1 patch
Braces   +23 added lines, -13 removed lines patch added patch discarded remove patch
@@ -82,7 +82,8 @@  discard block
 block discarded – undo
82 82
     //  Added the ability to set an expiration date for user passwords - will force them to change after this expires
83 83
     private function addPasswordExpiresColumn()
84 84
     {
85
-        if(!Schema::hasColumn('users', 'password_expires')) {
85
+        if(!Schema::hasColumn('users', 'password_expires'))
86
+        {
86 87
             Schema::table('users', function(Blueprint $table) {
87 88
                 $table->timestamp('password_expires')
88 89
                     ->nullable()
@@ -118,7 +119,8 @@  discard block
 block discarded – undo
118 119
     //  Added a 'hidden' attribute to system customer data types to allow passwords to not be viewed unless clicked or focus
119 120
     private function addHiddenColumn()
120 121
     {
121
-        if(!Schema::hasColumn('system_data_field_types', 'hidden')) {
122
+        if(!Schema::hasColumn('system_data_field_types', 'hidden'))
123
+        {
122 124
             Schema::table('system_cust_data_types', function(Blueprint $table) {
123 125
                 $table->boolean('hidden')
124 126
                     ->default(0)
@@ -130,7 +132,8 @@  discard block
 block discarded – undo
130 132
     //  Update the File links table - add cust_id and note column
131 133
     private function addColumnsToFileLinksTable()
132 134
     {
133
-        if(!Schema::hasColumn('file_links', 'cust_id')) {
135
+        if(!Schema::hasColumn('file_links', 'cust_id'))
136
+        {
134 137
             Schema::table('file_links', function(Blueprint $table) {
135 138
                 $table->integer('cust_id')
136 139
                     ->unsigned()
@@ -139,7 +142,8 @@  discard block
 block discarded – undo
139 142
                 $table->foreign('cust_id')->references('cust_id')->on('customers')->onUpdate('cascade')->onDelete('cascade');
140 143
             });
141 144
         }
142
-        if(!Schema::hasColumn('file_links', 'note')) {
145
+        if(!Schema::hasColumn('file_links', 'note'))
146
+        {
143 147
             Schema::table('file_links', function(Blueprint $table) {
144 148
                 $table->longText('note')
145 149
                     ->nullable()
@@ -147,7 +151,8 @@  discard block
 block discarded – undo
147 151
             });
148 152
             //  Migrate the instructions from the old table to the new column
149 153
             $instructions = DB::select('SELECT * FROM `file_link_instructions`');
150
-            foreach($instructions as $ins) {
154
+            foreach($instructions as $ins)
155
+            {
151 156
                 FileLinks::find($ins->link_id)->update([
152 157
                     'note' => $ins->instruction
153 158
                 ]);
@@ -158,7 +163,8 @@  discard block
 block discarded – undo
158 163
     //  Add Notes column to the file links files table
159 164
     private function addNotesColumnToFileLinkFiles()
160 165
     {
161
-        if(!Schema::hasColumn('file_link_files', 'note')) {
166
+        if(!Schema::hasColumn('file_link_files', 'note'))
167
+        {
162 168
             Schema::table('file_link_files', function(Blueprint $table) {
163 169
                 $table->longText('note')
164 170
                     ->nullable()
@@ -166,7 +172,8 @@  discard block
 block discarded – undo
166 172
             });
167 173
             //  Migrate the existing notes to the new table
168 174
             $notes = DB::select('SELECT * FROM `file_link_notes`');
169
-            foreach($notes as $note) {
175
+            foreach($notes as $note)
176
+            {
170 177
                 FileLinkFiles::where('file_id', $note->file_id)->update([
171 178
                     'note' => $note->note
172 179
                 ]);
@@ -177,7 +184,8 @@  discard block
 block discarded – undo
177 184
     //  Add the documentation column to the tech tips table
178 185
     private function migrateSystemDocumentation()
179 186
     {
180
-        if(!Schema::hasColumn('tech_tips', 'tip_type_id')) {
187
+        if(!Schema::hasColumn('tech_tips', 'tip_type_id'))
188
+        {
181 189
             Schema::table('tech_tips', function(Blueprint $table) {
182 190
                 $table->bigInteger('tip_type_id')->unsigned()->after('public')->default(1);
183 191
                 $table->foreign('tip_type_id')->references('tip_type_id')->on('tech_tip_types')->onUpdate('cascade');
@@ -185,7 +193,8 @@  discard block
 block discarded – undo
185 193
 
186 194
             //  Move all of the system files over to the tech tips table
187 195
             $sysFiles = DB::select('SELECT * FROM `system_files`');
188
-            foreach($sysFiles as $sysFile) {
196
+            foreach($sysFiles as $sysFile)
197
+            {
189 198
                 $newTip = TechTips::create([
190 199
                     'user_id'       => $sysFile->user_id,
191 200
                     'public'        => 0,
@@ -279,7 +288,8 @@  discard block
 block discarded – undo
279 288
     //  Remove the system files and system file types table
280 289
     private function removeSystemFilesTables()
281 290
     {
282
-        if(Schema::hasTable('system_files')) {
291
+        if(Schema::hasTable('system_files'))
292
+        {
283 293
             Schema::table('system_files', function(Blueprint $table) {
284 294
                 $table->dropForeign(['sys_id']);
285 295
                 $table->dropForeign(['type_id']);
@@ -325,7 +335,8 @@  discard block
 block discarded – undo
325 335
     //  Add soft deletes to tech tips table to prevent accidental deletes
326 336
     private function addSoftDeleteToTechTips()
327 337
     {
328
-        if (!Schema::hasColumn('tech_tips', 'deleted_at')) {
338
+        if (!Schema::hasColumn('tech_tips', 'deleted_at'))
339
+        {
329 340
             Schema::table('tech_tips', function (Blueprint $table) {
330 341
                 $table->softDeletes()->after('description');
331 342
             });
@@ -337,8 +348,7 @@  discard block
 block discarded – undo
337 348
     {
338 349
         if(!Schema::hasColumn('users', 'deleted_at'))
339 350
         {
340
-            Schema::table('users', function(Blueprint $table)
341
-            {
351
+            Schema::table('users', function(Blueprint $table) {
342 352
                 $table->softDeletes()->after('password_expires');
343 353
             });
344 354
             //  Migrate over all deactivated users
Please login to merge, or discard this patch.