AccountController::submitInitializeUser() - Code Metrics - Inspection of "Updated new User Page" - butcherman/Tech_Bench - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed
Retried Inspection
Push — dev5 ( e927b9...4863c0 )

by Ron
created 2019-12-03 06:40 UTC
AccountController::submitInitializeUser() A

↳ Parent: Project
Complexity

Conditions	3
Paths	3
Size

Total Lines	43
Code Lines	21
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	12
Importance

Changes
Metric	Value
cc	3
eloc	21
c	0
b	0
f	0
nc	3
nop	2
dl	0
loc	43
ccs	0
cts	0
cp	0
crap	12
rs	9.584
<?php

namespace App\Http\Controllers;

use App\Rules\ValidatePassword;
use App\User;
use Carbon\Carbon;
use App\UserSettings;
use Illuminate\Http\Request;
use Illuminate\Validation\Rule;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Route;

class AccountController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }

    //  Index page is the change user settings form
    public function index()
    {
        $userData = User::find(Auth::user()->user_id);
        $userSett = UserSettings::where('user_id', Auth::user()->user_id)->first();

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        return view('account.index', [
            'userData'     => $userData,
            'userSettings' => $userSett,
            'userID'       => Auth::user()->user_id
        ]);
    }

    //  Submit the new user settings
    public function submit(Request $request)
    {
        $request->validate([
            'username'   => 'required',
            'first_name' => 'required',
            'last_name'  => 'required',
            'email'      => [
                'required',
                Rule::unique('users')->ignore(Auth::user())
            ],
        ]);

        $userID = Auth::user()->user_id;
        User::find($userID)->update(
        [
            'first_name' => $request->first_name,
            'last_name'  => $request->last_name,
            'email'      => $request->email
        ]);

        session()->flash('success', 'User Settings Updated');

        Log::notice('User Settings Updated', ['user_id' => Auth::user()->user_id]);
        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        Log::debug('Submitted Data - ', $request->toArray());
        return redirect(route('account'));
    }

    //  Submit the user notification settings
    public function notifications(Request $request)
    {
        UserSettings::where('user_id', Auth::user()->user_id)->update(
        [
            'em_tech_tip'     => $request->em_tech_tip === 'on' ? true : false,
            'em_file_link'    => $request->em_file_link === 'on' ? true : false,
            'em_notification' => $request->em_notification === 'on' ? true : false,
            'auto_del_link'   => $request->auto_del_link === 'on' ? true : false,
        ]);

        session()->flash('success', 'User Notifications Updated');

        Log::notice('User Notifications Updated', ['user_id' => Auth::user()->user_id]);
        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        Log::debug('Submitted Data - ', $request->toArray());
        return redirect(route('account'));
    }

    //  Bring up the change password form
    public function changePassword()
    {
        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        return view('account.changePassword');
    }

    //  Submit the change password form
    public function submitPassword(Request $request)
    {
        //  Validate form data
        $request->validate([
            'oldPass' => ['required', new ValidatePassword],
            'newPass' => 'required|string|min:6|confirmed|different:oldPass'
        ]);

        //  Determine if there is a new password expire's date
        $newExpire = config('users.passExpires') != null ? Carbon::now()->addDays(config('users.passExpires')) : null;

        //  Change the password
        $user = Auth::user();
        $user->password = bcrypt($request->newPass);
        $user->password_expires = $newExpire;
        $user->save();

        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.Auth::user()->user_id);
        Log::info('User Changed Password', ['user_id' => Auth::user()->user_id]);

        return redirect(route('account'))->with('success', 'Password Changed Successfully');
    }











//  TODO - use the initialize form to finish setting up an account



    //  Bring up the "Finish User Setup" form
    public function initializeUser($hash)
    {
        $this->middleware('guest');

        //  Validate the hash token
        $user = UserInitialize::where('token', $hash)->get();
filter:
    dependency_paths: ["lib/*"]

        if ($user->isEmpty()) {
            Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
            Log::warning('Visitor at IP Address ' . \Request::ip() . ' tried to access invalid initialize hash - ' . $hash);
            return abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        Log::debug('Route ' . Route::currentRouteName() . ' visited.');
        Log::debug('Link Hash -' . $hash);
        return view('account.initializeUser', ['hash' => $hash]);
    }

    //  Submit the initialize user form
    public function submitInitializeUser(Request $request, $hash)
    {
        //  Verify that the link matches the assigned email address
        $valid = UserInitialize::where('token', $hash)->first();
        if (empty($valid)) {
            Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
            Log::warning('Visitor at IP Address ' . \Request::ip() . ' tried to submit an invalid User Initialization link - ' . $hash);
            return abort(404);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        //  Validate the form
        $request->validate([
            'username' => [
                'required',
                Rule::in([$valid->username]),
            ],
            'newPass'  => 'required|string|min:6|confirmed'
        ]);

        //  Get the users information
        $userData = User::where('username', $valid->username)->first();

        $nextChange = config('users.passExpires') != null ? Carbon::now()->addDays(config('users.passExpires')) : null;

        //  Update the password
        User::find($userData->user_id)->update(
            [
                'password'         => bcrypt($request->newPass),
                'password_expires' => $nextChange
            ]
        );

        //  Remove the initialize instance
        UserInitialize::find($valid->id)->delete();

        //  Log in the user
        Auth::loginUsingID($userData->user_id);

        //  Redirect the user to the dashboard
        Log::debug('Route ' . Route::currentRouteName() . ' visited by User ID-' . Auth::user()->user_id);
        Log::debug('Initialize Data - ' . $request->toArray());
        Log::debug('Initialize Data - ' . /** @scrutinizer ignore-type */ $request->toArray());
        Log::notice('User has setup account', ['user_id' => $userData->user_id]);
        return redirect(route('dashboard'));
    }
}

butcherman / Tech_Bench

Push — dev5 ( e927b9...4863c0 )

AccountController::submitInitializeUser() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
