View GitHub Repository Tech_Bench

Schedule Inspection
Subscribe

Code Duplication    Length = 5-5 lines in 2 locations

app/Http/Controllers/FileLinks/GuestLinksController.php 2 locations

@@ 42-46 (lines=5) @@
39 
            return view('links.guestBadLink');
40 
        }
41 
        //  Verify that the link has not expired
42 
        else if($details->expire <= date('Y-m-d'))
43 
        {
44 
            Log::warning('Visitor '.\Request::ip().' visited expired link Hash - '.$id);
45 
            return view('links.guestExpiredLink');
46 
        }
47 

                                

                                                            

                                    48
                                    
                                    
        //  Link is valid - determine if the link has files that can be downloaded

                                

                                                            

                                    49
                                    
                                    
        $files = FileLinkFiles::where('link_id', $details->link_id)

                                

                                                                                

                                
                                
                                    @@ 53-57 (lines=5) @@
                                
                            


                                                            

                                    50
                                    
                                    
            ->where('upload', false)

                                

                                                            

                                    51
                                    
                                    
            ->count();

                                

                                                            

                                    52
                                    
                                    

                                

                                                            

                                    53
                                    
                                    
        if($files == 0 && $details->allow_upload === 'No')

                                

                                                            

                                    54
                                    
                                    
        {

                                

                                                            

                                    55
                                    
                                    
            Log::warning('Visitor ' . \Request::ip() . ' visited a link that they cannot do anything with.  Hash - ' . $id);

                                

                                                            

                                    56
                                    
                                    
            return view('links.guestDeadLink');

                                

                                                            

                                    57
                                    
                                    
        }

                                

                                                            

                                    58
                                    
                                    

                                

                                                            

                                    59
                                    
                                    
        Log::debug('Route '.Route::currentRouteName().' visited by User ID-'.\Request::ip());

                                

                                                            

                                    60
                                    
                                    
        Log::debug('Link Hash-'.$id);