Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class DropboxAdapterFactory extends AbstractAdapterFactory |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * @inheritdoc |
||
| 15 | */ |
||
| 16 | 1 | View Code Duplication | public function doCreateService(ServiceLocatorInterface $serviceLocator) |
| 17 | { |
||
| 18 | if (!class_exists(\League\Flysystem\Dropbox\DropboxAdapter::class)) { |
||
| 19 | throw new RequirementsException( |
||
| 20 | ['league/flysystem-dropbox'], |
||
| 21 | 'Dropbox' |
||
| 22 | ); |
||
| 23 | } |
||
| 24 | |||
| 25 | 1 | $client = new \Dropbox\Client( |
|
| 26 | 1 | $this->options['access_token'], |
|
| 27 | 1 | $this->options['client_identifier'], |
|
| 28 | 1 | $this->options['user_locale'] |
|
| 29 | ); |
||
| 30 | |||
| 31 | 1 | $adapter = new Adapter($client, $this->options['prefix']); |
|
| 32 | |||
| 33 | 1 | return $adapter; |
|
| 34 | } |
||
| 35 | |||
| 36 | /** |
||
| 37 | * @inheritdoc |
||
| 38 | */ |
||
| 39 | protected function validateConfig() |
||
| 57 | } |
||
| 58 |