PaginationService::__construct() - Code Metrics - Inspection of "Merge branch 'master' of github.com:burzum/cakephp..." - burzum/cakephp-service-layer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8361b2...989824 )

by Florian

created 2018-03-28 14:34 UTC

PaginationService::__construct() A

↳ Parent: PaginationService

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	7
cts	7
cp	1
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	1
crap	1

<?php
/**
 * Copyright (c) Florian Krämer
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @copyright     Copyright (c) Florian Krämer
 * @link          https://github.com/burzum/cakephp-service-layer
 * @since         1.0.0
 * @license       https://opensource.org/licenses/mit-license.php MIT License
 */
declare(strict_types = 1);

namespace Burzum\Cake\Service;

use Cake\Http\ServerRequest;

/**
 * Pagination Service
 */
class PaginationService {

    use ServicePaginatorTrait;

    /**
     * Server Request Object
     *
     * @var \Cake\Http\ServerRequest|null $request Server Request
     */
    protected $request;

    /**
     * Constructor
     *
     * @param \Cake\Http\ServerRequest $request Server Request
     */
    public function __construct(ServerRequest $request)
    {
        $this->request = $request;

        $_this = $this;
        $this->getEventManager()->on('Service.afterPaginate', function() use ($_this) {
            $_this->addPagingParamToRequest($_this->request);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        });
    }
}


1		<?php
2		/**
3		* Copyright (c) Florian Krämer
4		*
5		* Licensed under The MIT License
6		* For full copyright and license information, please see the LICENSE.txt
7		* Redistributions of files must retain the above copyright notice.
8		*
9		* @copyright Copyright (c) Florian Krämer
10		* @link https://github.com/burzum/cakephp-service-layer
11		* @since 1.0.0
12		* @license https://opensource.org/licenses/mit-license.php MIT License
13		*/
14		declare(strict_types = 1);
15
16		namespace Burzum\Cake\Service;
17
18		use Cake\Http\ServerRequest;
19
20		/**
21		* Pagination Service
22		*/
23		class PaginationService {
24
25		use ServicePaginatorTrait;
26
27		/**
28		* Server Request Object
29		*
30		* @var \Cake\Http\ServerRequest\|null $request Server Request
31		*/
32		protected $request;
33
34		/**
35		* Constructor
36		*
37		* @param \Cake\Http\ServerRequest $request Server Request
38		*/
39	1	public function __construct(ServerRequest $request)
40		{
41	1	$this->request = $request;
42
43	1	$_this = $this;
44	1	$this->getEventManager()->on('Service.afterPaginate', function() use ($_this) {
45	1	$_this->addPagingParamToRequest($_this->request);
		0 ignored issues – show Bug introduced 2018-03-28 14:42 UTC by Report Bug Copy Issue Report It seems like `$_this->request` can be `null`; however, `addPagingParamToRequest()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
46	1	});
47	1	}
48		}
49

burzum / cakephp-service-layer

Push — master ( 8361b2...989824 )

PaginationService::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like