Omnipay\Paystation\Message\HasCardFields

Complexity

Total Complexity

12

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getCardNumber()	0	4	1
A	getCardExpiryYear()	0	5	1
A	getCardExpiryMonth()	0	5	1
A	getCardholderName()	0	4	1
A	getCardType()	0	8	2
A	getResponseField()	0	8	4
A	convertExpiryDate()	0	8	2

<?php

namespace Omnipay\Paystation\Message;

/**
 * Provide additional information to look up card fields on a response object
 */
trait HasCardFields
{
    /** @var string|null  The property of $this->data to look up response fields by, or null if directly on $this->data */
    protected $lookupField;

    public function getCardNumber()
    {
        return $this->getResponseField('CardNo');
    }

    public function getCardExpiryYear()
    {
        $expiry = $this->convertExpiryDate($this->getResponseField('CardExpiry'));
        return $expiry[0];
    }

    public function getCardExpiryMonth()
    {
        $expiry = $this->convertExpiryDate($this->getResponseField('CardExpiry'));
        return $expiry[1];
    }

    public function getCardholderName()
    {
        return $this->getResponseField('CardholderName');
    }

    public function getCardType()
    {
        $type = $this->getResponseField('CardType');
        if ($type === null) {
            $type = $this->getResponseField('Cardtype');
        }
        return $type;
    }

    protected function getResponseField($key)
    {
        if (!$this->isSuccessful()) {

It seems like isSuccessful() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return null;
        }
        $lookup = $this->lookupField === null ? $this->data : $this->data->{$this->lookupField};

The property data does not exist. Did you maybe forget to declare it?

        return isset($lookup->$key) ? (string) $lookup->$key : null;
    }

    protected function convertExpiryDate($yymm)
    {
        if (preg_match('/([0-9]{2})([0-9]{2})/', $yymm, $match)) {
            return array((int) $match[1], (int) $match[2]);
        } else {
            return array(null, null);
        }
    }
}