GLL::getLatitude() - Code Metrics - bulton-fr/nmea-parser - Measure and Improve Code Quality continuously with Scrutinizer

GLL::getLatitude() A
last analyzed 2019-05-26 12:34 UTC

↳ Parent: GLL

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	1
cts	1
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

namespace BultonFr\NMEA\Frames;

use \DateTime;
use \DateTimeZone;

/**
 * Define the parser system for GLL frame type
 * 
 * @package BultonFr\NMEA
 * @author Vermeulen Maxime <[email protected]>
 * @link http://www.gpsinformation.org/dale/nmea.htm#GLL
 * @link http://aprs.gids.nl/nmea/#gll
 */
class GLL extends \BultonFr\NMEA\Frame
{
    /**
     * {@inheritdoc}
     */
    protected $frameType = 'GLL';

    /**
     * Format : ----GLL,lll.ll,a,yyyyy.yy,a,hhmmss.ss,A
     * {@inheritdoc}
     */
    protected $frameRegex = '/^'
        .'([A-Z]{2}[A-Z]{3}),' //Equipment and trame type
        .'([0-9\.]+),' //Latitude
        .'(N|S),' //N or S (North or South)
        .'([0-9\.]+),' //Longitude
        .'(E|W),' //E or W (East or West)
        .'(\d{6})(\.\d{2,3})?,' //Time (UTC)
        .'(A|V)' //Status A=active or V=Void
        .'(,(A|D|E|N|S)?)?' //Mode indicator (NMEA >= 2.3)
        .'$/m';

    /**
     * @var string $latitude Latitude
     */
    protected $latitude;

    /**
     * @var string $latitudeDirection N or S (North or South)
     */
    protected $latitudeDirection;

    /**
     * @var string $longitude Longitude
     */
    protected $longitude;

    /**
     * @var string $longitudeDirection E or W (East or West)
     */
    protected $longitudeDirection;

    /**
     * @var \DateTime $utcTime Time of the line (UTC)
     */
    protected $utcTime;
    
    /**
     * @var string $status Status A=active or V=Void
     */
    protected $status;
    
    /**
     * @var string $mode Mode indicator (NMEA >= 2.3)
     * * A : autonomous
     * * D : differential
     * * E : Estimated
     * * N : not valid
     * * S : Simulator
     */
    protected $mode;

    /**
     * Getter to property latitude
     * 
     * @return string
     */
    public function getLatitude()
    {
        return $this->latitude;
    }

    /**
     * Getter to property latitudeDirection
     * 
     * @return string
     */
    public function getLatitudeDirection()
    {
        return $this->latitudeDirection;
    }

    /**
     * Getter to property longitude
     * 
     * @return string
     */
    public function getLongitude()
    {
        return $this->longitude;
    }

    /**
     * Getter to property longitudeDirection
     * 
     * @return string
     */
    public function getLongitudeDirection()
    {
        return $this->longitudeDirection;
    }

    /**
     * Getter to property utcTime
     * 
     * @return \DateTime
     */
    public function getUtcTime()
    {
        return $this->utcTime;
    }
    
    /**
     * Getter to property status
     * 
     * @return float
     */
    public function getStatus()
    {
        return $this->status;

    }

    /**
     * Getter to property mode
     * 
     * @return string
     */
    public function getMode()
    {
        return $this->mode;
    }
    
    /**
     * {@inheritdoc}
     */
    protected function decodeFrame($msgParts)
    {
        $this->latitude           = (string) $msgParts[2];
        $this->latitudeDirection  = (string) $msgParts[3];
        $this->longitude          = (string) $msgParts[4];
        $this->longitudeDirection = (string) $msgParts[5];
        
        $this->utcTime = DateTime::createFromFormat(
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            'His',
            $msgParts[6],
            new DateTimeZone('UTC')
        );
        
        $this->status = (string) $msgParts[8];
        
        if (isset($msgParts[10])) {
            $this->mode = (string) $msgParts[10];
        }
    }
}


1		<?php
2
3		namespace BultonFr\NMEA\Frames;
4
5		use \DateTime;
6		use \DateTimeZone;
7
8		/**
9		* Define the parser system for GLL frame type
10		*
11		* @package BultonFr\NMEA
12		* @author Vermeulen Maxime <[email protected]>
13		* @link http://www.gpsinformation.org/dale/nmea.htm#GLL
14		* @link http://aprs.gids.nl/nmea/#gll
15		*/
16		class GLL extends \BultonFr\NMEA\Frame
17		{
18		/**
19		* {@inheritdoc}
20		*/
21		protected $frameType = 'GLL';
22
23		/**
24		* Format : ----GLL,lll.ll,a,yyyyy.yy,a,hhmmss.ss,A
25		* {@inheritdoc}
26		*/
27		protected $frameRegex = '/^'
28		.'([A-Z]{2}[A-Z]{3}),' //Equipment and trame type
29		.'([0-9\.]+),' //Latitude
30		.'(N\|S),' //N or S (North or South)
31		.'([0-9\.]+),' //Longitude
32		.'(E\|W),' //E or W (East or West)
33		.'(\d{6})(\.\d{2,3})?,' //Time (UTC)
34		.'(A\|V)' //Status A=active or V=Void
35		.'(,(A\|D\|E\|N\|S)?)?' //Mode indicator (NMEA >= 2.3)
36		.'$/m';
37
38		/**
39		* @var string $latitude Latitude
40		*/
41		protected $latitude;
42
43		/**
44		* @var string $latitudeDirection N or S (North or South)
45		*/
46		protected $latitudeDirection;
47
48		/**
49		* @var string $longitude Longitude
50		*/
51		protected $longitude;
52
53		/**
54		* @var string $longitudeDirection E or W (East or West)
55		*/
56		protected $longitudeDirection;
57
58		/**
59		* @var \DateTime $utcTime Time of the line (UTC)
60		*/
61		protected $utcTime;
62
63		/**
64		* @var string $status Status A=active or V=Void
65		*/
66		protected $status;
67
68		/**
69		* @var string $mode Mode indicator (NMEA >= 2.3)
70		* * A : autonomous
71		* * D : differential
72		* * E : Estimated
73		* * N : not valid
74		* * S : Simulator
75		*/
76		protected $mode;
77
78		/**
79		* Getter to property latitude
80		*
81		* @return string
82		*/
83		public function getLatitude()
84		{
85	1	return $this->latitude;
86		}
87
88		/**
89		* Getter to property latitudeDirection
90		*
91		* @return string
92		*/
93		public function getLatitudeDirection()
94		{
95	1	return $this->latitudeDirection;
96		}
97
98		/**
99		* Getter to property longitude
100		*
101		* @return string
102		*/
103		public function getLongitude()
104		{
105	1	return $this->longitude;
106		}
107
108		/**
109		* Getter to property longitudeDirection
110		*
111		* @return string
112		*/
113		public function getLongitudeDirection()
114		{
115	1	return $this->longitudeDirection;
116		}
117
118		/**
119		* Getter to property utcTime
120		*
121		* @return \DateTime
122		*/
123		public function getUtcTime()
124		{
125	1	return $this->utcTime;
126		}
127
128		/**
129		* Getter to property status
130		*
131		* @return float
132		*/
133		public function getStatus()
134		{
135	1	return $this->status;
		0 ignored issues – show Bug Best Practice introduced 2019-05-26 12:12 UTC by Report Bug Copy Issue Report The expression `return $this->status` returns the type `string` which is incompatible with the documented return type `double`. Loading history...
136		}
137
138		/**
139		* Getter to property mode
140		*
141		* @return string
142		*/
143		public function getMode()
144		{
145	1	return $this->mode;
146		}
147
148		/**
149		* {@inheritdoc}
150		*/
151		protected function decodeFrame($msgParts)
152		{
153	1	$this->latitude = (string) $msgParts[2];
154	1	$this->latitudeDirection = (string) $msgParts[3];
155	1	$this->longitude = (string) $msgParts[4];
156	1	$this->longitudeDirection = (string) $msgParts[5];
157
158	1	$this->utcTime = DateTime::createFromFormat(
		0 ignored issues – show Documentation Bug introduced 2019-05-26 12:12 UTC by Report Bug Copy Issue Report It seems like `DateTime::createFromForm...ew DateTimeZone('UTC'))` can also be of type `false`. However, the property `$utcTime` is declared as type `DateTime`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
159	1	'His',
160	1	$msgParts[6],
161	1	new DateTimeZone('UTC')
162		);
163
164	1	$this->status = (string) $msgParts[8];
165
166	1	if (isset($msgParts[10])) {
167	1	$this->mode = (string) $msgParts[10];
168		}
169	1	}
170		}
171

bulton-fr / nmea-parser

GitHub Access Token became invalid

GLL::getLatitude() A last analyzed 2019-05-26 12:34 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

GLL::getLatitude() A
last analyzed 2019-05-26 12:34 UTC