Join::generate() - Code Metrics - Inspection of "Queries\JoinTrait::createJoin : Not define "*" for..." - bulton-fr/bfw-sql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 1160ec...acba87 )

by Vermeulen

created 2018-08-13 14:26 UTC

Join::generate() A

↳ Parent: Join

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
c	0
b	0
f	0
rs	9.9
cc	2
nc	2
nop	0

<?php

namespace BfwSql\Queries\Parts;

class Join extends Table
{
    /**
     * @var string $on The on condition used for a join
     */
    protected $on = '';
    
    /**
     * Getter accessor to property on
     * 
     * @return string
     */
    public function getOn(): string
    {
        return $this->on;
    }
    
    /**
     * Magic method __invoke, used when the user call object like a function
     * @link http://php.net/manual/en/language.oop5.magic.php#object.invoke
     * 
     * @param string|array $nameInfos The name (and shortcut) of the table
     * @param string|array|null $columns Columns of this table to use
     *  into the request
     * @param string $on The ON condition used by the join
     * 
     * @return void
     */
    public function __invoke($nameInfos, $columns = null, string $on = '')
    {
        parent::__invoke($nameInfos, $columns);
        $this->on = $on;
    }
    
    /**
     * {@inheritdoc}
     */
    public function generate(): string

    {
        $partQuery = '`'.$this->name.'`';
        if ($this->shortcut !== null) {
            $partQuery .= ' AS `'.$this->shortcut.'`';
        }
        
        $partQuery .= ' ON '.$this->on;
        
        return $partQuery;
    }
}


1		<?php
2
3		namespace BfwSql\Queries\Parts;
4
5		class Join extends Table
6		{
7		/**
8		* @var string $on The on condition used for a join
9		*/
10		protected $on = '';
11
12		/**
13		* Getter accessor to property on
14		*
15		* @return string
16		*/
17		public function getOn(): string
18		{
19		return $this->on;
20		}
21
22		/**
23		* Magic method __invoke, used when the user call object like a function
24		* @link http://php.net/manual/en/language.oop5.magic.php#object.invoke
25		*
26		* @param string\|array $nameInfos The name (and shortcut) of the table
27		* @param string\|array\|null $columns Columns of this table to use
28		* into the request
29		* @param string $on The ON condition used by the join
30		*
31		* @return void
32		*/
33		public function __invoke($nameInfos, $columns = null, string $on = '')
34		{
35		parent::__invoke($nameInfos, $columns);
36		$this->on = $on;
37		}
38
39		/**
40		* {@inheritdoc}
41		*/
42	View Code Duplication	public function generate(): string
		0 ignored issues – show Duplication introduced 2018-08-13 14:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$partQuery = '`'.$this->name.'`';
45		if ($this->shortcut !== null) {
46		$partQuery .= ' AS `'.$this->shortcut.'`';
47		}
48
49		$partQuery .= ' ON '.$this->on;
50
51		return $partQuery;
52		}
53		}
54

bulton-fr / bfw-sql

Push — 2.0 ( 1160ec...acba87 )

Join::generate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like