Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class OrderList extends AbstractList |
|
|
|||
6 | { |
||
7 | /** |
||
8 | * {@inheritdoc} |
||
9 | */ |
||
10 | protected $partPrefix = 'ORDER BY'; |
||
11 | |||
12 | /** |
||
13 | * {@inheritdoc} |
||
14 | */ |
||
15 | protected $separator = ','; |
||
16 | |||
17 | /** |
||
18 | * Magic method __invoke, used when the user call object like a function |
||
19 | * @link http://php.net/manual/en/language.oop5.magic.php#object.invoke |
||
20 | * |
||
21 | * @param string $expr The expression to use into the order |
||
22 | * @param string $sort The sort order : ASC or DESC |
||
23 | * |
||
24 | * @return void |
||
25 | */ |
||
26 | public function __invoke(string $expr, $sort = 'ASC') |
||
30 | |||
31 | /** |
||
32 | * {@inheritdoc} |
||
33 | */ |
||
34 | public function generate(): string |
||
48 | } |
||
49 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.