Ajax - Code Metrics - Inspection of "Update generate feature image and tooptip" - buiquangduc/WP_Default_Feature_Image - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#52)

by Bui Quang

created 2017-12-26 14:42 UTC

Ajax A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	83
rs	10
c	0
b	0
f	0
wmc	8
lcom	0
cbo	1

7 Methods

Rating	Name	Size	Complexity
A	initializes()	4	1
A	hooks()	9	2
A	get_related_layout()	4	1
A	get_default_layout()	4	1
A	get_post_types()	4	1
A	get_terms()	4	1
A	generate_feature_image()	9	1

<?php

namespace WPDFI;

/**
 * This class handle all ajax actions of this plugin
 * 
 * @author Duc Bui Quang <[email protected]>
 * @since 1.0.0
 */

use WPDFI\Traits\Singleton;

final class Ajax
{
	use Singleton;

	/**
	 * @traitDoc
	 */
	public function initializes()
	{
		$this->hooks();
	}

	/**
	 * All ajax action of this plugin come here
	 *
	 * @since 1.0.0
	 * @return void
	 */
	public function hooks() {
		$actions = ['get_post_types', 'get_terms', 'get_image_size_names_and_dimensions', 
					'get_default_layout', 'get_related_layout', 'generate_feature_image'];

		foreach($actions as $action) {
			\add_action('wp_ajax_wpdfi_'. $action, [$this, $action]);
			\add_action('wp_ajax_nopriv_wpdfi'. $action, [$this, $action]);
		}
	}

	/**
	 * Get related layout with post type value, related layout include taxonomies, image upload and image size
	 *
	 * @since 1.0.0
	 * @return void
	 */
	public function get_related_layout() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		echo json_encode(\wpdfi()->layout->get_related_layout($_POST['section_index'], $_POST['post_type']));
		exit;

	}

	/**
	 * Get default layout of single section in admin
	 *
	 * @since 1.0.0
	 * @return void
	 */
	public function get_default_layout() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		echo json_encode(\wpdfi()->layout->get_default_layout($_POST['index'], $_POST['include_delete']));
		exit;

	}

	/**
	 * Ajax action to get all post types which support thumbnail feature
	 *
	 * @since 1.0.0
	 * @return array
	 */
	public function get_post_types() {
		echo json_encode(\wpdfi()->post_type->get_id_and_text());
		exit;

	}

	/**
	 * Ajax action to get all terms by given taxonomy
	 * 
	 * @since 1.0.0
	 * @return array
	 */
	public function get_terms() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		echo json_encode(\wpdfi()->term->get($_POST['taxonomy']));
		exit;

	}


	public function generate_feature_image() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		/* security check. */
		\check_ajax_referer( 'wpdfi-ajax-nonce', 'security' );
		$update_fimage = \wpdfi()->post_type->update_fimage($_POST['post_id']);
		$post_type = \get_post_type($_POST['post_id']);
		$post_type_name = \wpdfi()->post_type->get_singular_name($post_type);
		echo json_encode(['status' => $update_fimage, 'namePT' => $post_type_name, 'postId' => $_POST['post_id']]);
		exit;

	}
}

1			<?php
2
3			namespace WPDFI;
4
5			/**
6			* This class handle all ajax actions of this plugin
7			*
8			* @author Duc Bui Quang <[email protected]>
9			* @since 1.0.0
10			*/
11
12			use WPDFI\Traits\Singleton;
13
14			final class Ajax
15			{
16			use Singleton;
17
18			/**
19			* @traitDoc
20			*/
21			public function initializes()
22			{
23			$this->hooks();
24			}
25
26			/**
27			* All ajax action of this plugin come here
28			*
29			* @since 1.0.0
30			* @return void
31			*/
32			public function hooks() {
33			$actions = ['get_post_types', 'get_terms', 'get_image_size_names_and_dimensions',
34			'get_default_layout', 'get_related_layout', 'generate_feature_image'];
35
36			foreach($actions as $action) {
37			\add_action('wp_ajax_wpdfi_'. $action, [$this, $action]);
38			\add_action('wp_ajax_nopriv_wpdfi'. $action, [$this, $action]);
39			}
40			}
41
42			/**
43			* Get related layout with post type value, related layout include taxonomies, image upload and image size
44			*
45			* @since 1.0.0
46			* @return void
47			*/
48			public function get_related_layout() {
			0 ignored issues – show Coding Style introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report `get_related_layout` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
49			echo json_encode(\wpdfi()->layout->get_related_layout($_POST['section_index'], $_POST['post_type']));
50			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report The method `get_related_layout()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
51			}
52
53			/**
54			* Get default layout of single section in admin
55			*
56			* @since 1.0.0
57			* @return void
58			*/
59			public function get_default_layout() {
			0 ignored issues – show Coding Style introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report `get_default_layout` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
60			echo json_encode(\wpdfi()->layout->get_default_layout($_POST['index'], $_POST['include_delete']));
61			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report The method `get_default_layout()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
62			}
63
64			/**
65			* Ajax action to get all post types which support thumbnail feature
66			*
67			* @since 1.0.0
68			* @return array
69			*/
70			public function get_post_types() {
71			echo json_encode(\wpdfi()->post_type->get_id_and_text());
72			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report The method `get_post_types()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
73			}
74
75			/**
76			* Ajax action to get all terms by given taxonomy
77			*
78			* @since 1.0.0
79			* @return array
80			*/
81			public function get_terms() {
			0 ignored issues – show Coding Style introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report `get_terms` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
82			echo json_encode(\wpdfi()->term->get($_POST['taxonomy']));
83			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report The method `get_terms()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
84			}
85
86
87			public function generate_feature_image() {
			0 ignored issues – show Coding Style introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report `generate_feature_image` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
88			/* security check. */
89			\check_ajax_referer( 'wpdfi-ajax-nonce', 'security' );
90			$update_fimage = \wpdfi()->post_type->update_fimage($_POST['post_id']);
91			$post_type = \get_post_type($_POST['post_id']);
92			$post_type_name = \wpdfi()->post_type->get_singular_name($post_type);
93			echo json_encode(['status' => $update_fimage, 'namePT' => $post_type_name, 'postId' => $_POST['post_id']]);
94			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2017-12-26 09:07 UTC by Report Bug Copy Issue Report The method `generate_feature_image()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
95			}
96			}

buiquangduc / WP_Default_Feature_Image

Pull Request — master (#52)

Ajax A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like