KeyDerivationTest::testKeyDerivation() - Code Metrics - Inspection of "Documentation, phpdoc, and tidyup" - btccom/justencrypt-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by thomas

created 2017-01-23 13:26 UTC

KeyDerivationTest::testKeyDerivation() A

↳ Parent: KeyDerivationTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	4

<?php

namespace Btccom\JustEncrypt\Test;

use BitWasp\Buffertools\Buffer;
use BitWasp\Buffertools\BufferInterface;
use Btccom\JustEncrypt\HeaderBlob;
use Btccom\JustEncrypt\KeyDerivation;

class KeyDerivationTest extends AbstractTestCase
{
    /**
     * @return array
     */
    public function getKeyDerivationVectors()
    {
        return array_map(function (array $row) {
            if (isset($row['password_utf8'])) {
                $password = new Buffer($row['password_utf8']);
            } else {
                $password = Buffer::hex($row['password']);
            }
            return [$password, Buffer::hex($row['salt']), $row['iterations'], Buffer::hex($row['output'])];
        }, $this->getTestVectors()['keyderivation']);
    }

    /**
     * @param BufferInterface $password
     * @param BufferInterface $salt
     * @param BufferInterface $expectedOutput
     * @param int $iterations
     * @dataProvider getKeyDerivationVectors
     */
    public function testKeyDerivation(BufferInterface $password, BufferInterface $salt, $iterations, BufferInterface $expectedOutput)
    {
        $output = KeyDerivation::compute($password, $salt, $iterations);
        $this->assertTrue($expectedOutput->equals($output), 'key derivation produces same output');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Btccom\JustEncrypt\Test;
4
5			use BitWasp\Buffertools\Buffer;
6			use BitWasp\Buffertools\BufferInterface;
7			use Btccom\JustEncrypt\HeaderBlob;
8			use Btccom\JustEncrypt\KeyDerivation;
9
10			class KeyDerivationTest extends AbstractTestCase
11			{
12			/**
13			* @return array
14			*/
15			public function getKeyDerivationVectors()
16			{
17			return array_map(function (array $row) {
18			if (isset($row['password_utf8'])) {
19			$password = new Buffer($row['password_utf8']);
20			} else {
21			$password = Buffer::hex($row['password']);
22			}
23			return [$password, Buffer::hex($row['salt']), $row['iterations'], Buffer::hex($row['output'])];
24			}, $this->getTestVectors()['keyderivation']);
25			}
26
27			/**
28			* @param BufferInterface $password
29			* @param BufferInterface $salt
30			* @param BufferInterface $expectedOutput
31			* @param int $iterations
32			* @dataProvider getKeyDerivationVectors
33			*/
34			public function testKeyDerivation(BufferInterface $password, BufferInterface $salt, $iterations, BufferInterface $expectedOutput)
35			{
36			$output = KeyDerivation::compute($password, $salt, $iterations);
37			$this->assertTrue($expectedOutput->equals($output), 'key derivation produces same output');
			0 ignored issues – show Documentation introduced 2017-01-23 14:38 UTC by Report Bug Copy Issue Report `$output` is of type `object<BitWasp\Buffertools\BufferInterface>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38			}
39			}
40

btccom / justencrypt-php

Pull Request — master (#2)

KeyDerivationTest::testKeyDerivation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like