Someshwer\WorldCountries\Utils\Continents

Complexity

Total Complexity

6

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Test Coverage

Coverage

86.96%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	optimizeContinentsData()	0	9	1
A	getOptimizedContinentsData()	0	6	1
A	formatContinents()	0	8	2
A	continents()	0	6	1
A	__construct()	0	3	1

<?php

namespace Someshwer\WorldCountries\Utils;

use Illuminate\Encryption\Encrypter;
use Someshwer\WorldCountries\Data\DataRepository;
use Illuminate\Support\Str;

/**
 * Author: Someshwer Bandapally
 * Date: 14-07-2018.
 *
 * This class gives the list of continents names
 *
 * Class Continents
 */
trait Continents
{
    /**
     * @var DataRepository
     */
    private $data;

    /**
     * @var string
     */
    private $en_key = 'Someshwer1@2#BandapallySomeshwer';

    /**
     * @var string
     */
    private $cipher = 'AES-256-CBC';

    /**
     * Continents constructor.
     *
     * @param DataRepository $dataRepository
     */
    public function __construct(DataRepository $dataRepository)
    {
        $this->data = $dataRepository;
    }

    /**
     * Get optimized continents data.
     *
     * @return string
     */
    private function getOptimizedContinentsData()
    {
        $all_continents_data = $this->data->continents();
        $continents_data = $this->optimizeContinentsData($all_continents_data);
        // return $continents_data = json_decode($continents_data, true);
        return $continents_data;
    }

    /**
     * Optimize continents data.
     *
     * @param $all_continents_data
     *
     * @return string
     */
    private function optimizeContinentsData($all_continents_data)
    {
        $str_length = strlen($all_continents_data) - 4;
        $all_continents_trimmed_data = substr($all_continents_data, 0, 2).substr($all_continents_data, 3, $str_length);
        // $hash = new Encrypter($this->en_key, Config::get('app.cipher'));
        $hash = new Encrypter($this->en_key, $this->cipher);
        $all_continents = $hash->decrypt($all_continents_trimmed_data);

        return $all_continents;
    }

    /**
     * Format continents.
     *
     * @param $continents
     *
     * @return $this
     */
    private function formatContinents($continents)
    {
        return collect($continents)->transform(function ($item) {

The expression return collect($continents)->transform(function(...) { /* ... */ }) returns the type Illuminate\Support\Collection which is incompatible with the documented return type Someshwer\WorldCountries\Utils\Continents.

            $data['name'] = $item;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data['display_name'] = str_replace('_', ' ', Str::title($item));
            $data['also_called_as'] = ($item == 'australia') ? 'Oceania' : null;

            return $data;
        });
    }

    /**
     * Get list of continents names.
     *
     * @return array
     */
    public function continents()
    {
        $continents = $this->getOptimizedContinentsData();
        $formatted_continents = $this->formatContinents($continents);

        return ['continents' => $formatted_continents];
    }
}