Issues in home.page.php - Failed Issues - Inspection of "Add option to disable lures" - brusselopole/Worldopole - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#347)

by Florian

created 2018-01-21 01:12 UTC

pages/home.page.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<header id="single-header">
	<div class="row">
		<div class="col-md-12 text-center">
			<h1>
				<?= $config->infos->site_title ?>
				<br>
				<small><?= sprintf($config->infos->site_claim, $config->infos->city); ?></small>
			</h1>

		</div>
	</div>
</header>

<div class="flex-container row area">

	<div class="flex-item-homepage big-data"> <!-- LIVEMON -->
		<a href="pokemon">
			<img src="core/img/pokeball.png" alt="Visit the <?= $config->infos->site_name ?> Pokedex" width=50 class="big-icon">
			<p><big><strong class="total-pkm-js">0</strong> Pokémon</big><br>
			<?= sprintf($locales->WIDGET_POKEMON_SUB, $config->infos->city); ?></p>
		</a>
	</div>

	<div class="flex-item-homepage big-data"> <!-- GYMS -->
		<a href="gym">
			<img src="core/img/rocket.png" alt="Discover the <?= $config->infos->site_name ?> Gyms" width=50 class="big-icon">
			<p><big><strong class="total-gym-js">0</strong> <?= $locales->GYMS ?></big><br>
			<?= $locales->WIDGET_GYM_SUB ?></p>
		</a>

	</div>

    <?php
    if (!$config->system->no_lures === true) {
        ?>
        <div class="flex-item-homepage big-data"> <!-- POKESTOPS -->
            <a href="pokestops">
                <img src="core/img/lure-module.png" alt="Discover the <?= $config->infos->site_name ?> Pokéstops" width=50 class="big-icon">
                <p><big><strong class="total-lure-js">0</strong> <?= $locales->LURES ?></big><br>
                    <?= sprintf($locales->WIDGET_LURES_SUB, $config->infos->city); ?></p>
            </a>
        </div>
        <?php
    }
    if ($config->system->homepage_raids === true) {
        ?>
        <div class="flex-item-homepage flex-item-homepage-homepage big-data"> <!-- RAIDS -->
            <a href="raids">
                <img src="core/img/raid.png" alt="Discover the <?= $config->infos->site_name ?> Raids" width=50
                     class="big-icon">
                <p><big><strong class="total-raids-js">0</strong> <?= $locales->RAIDS ?></big><br>
                    <?= sprintf($locales->WIDGET_LURES_SUB, $config->infos->city); ?></p>
            </a>
        </div>
        <?php
        }

    ?>

	<div class="flex-item-homepage big-data">
		<a href="<?= $config->homewidget->url ?>" target="_blank">
			<img src="<?= $config->homewidget->image ?>" alt="<?= $config->homewidget->image_alt ?>" width=50 class="big-icon">
			<p><?= $config->homewidget->text ?></p>
		</a>
	</div>

</div>


<div class="row area big-padding">
	<div class="col-md-12 text-center">
		<h2 class="text-center sub-title">
			<?php 
			if ($config->system->recents_filter) { ?>
				<?= $locales->RECENT_MYTHIC_SPAWNS ?>
			<?php 
			} else { ?>
				<?= $locales->RECENT_SPAWNS ?>
			<?php 
			} ?>
		</h2>
		<div class="last-mon-js">
		<?php
		foreach ($recents as $key => $pokemon) {
			$id = $pokemon->id;
			$uid = $pokemon->uid; ?>
			<div class="col-md-1 col-xs-4 pokemon-single" data-pokeid="<?= $id ?>" data-pokeuid="<?= $uid ?>" >
				<a href="pokemon/<?= $id ?>"><img src="<?= $pokemons->pokemon->$id->img ?>" alt="<?= $pokemons->pokemon->$id->name ?>" class="img-responsive"></a>
				<a href="pokemon/<?= $id ?>"><p class="pkmn-name"><?= $pokemons->pokemon->$id->name ?></p></a>
				<a href="<?= $pokemon->location_link ?>" target="_blank">
					<small class="pokemon-timer">00:00:00</small>
				</a>
				<?php
				if ($config->system->recents_encounter_details) {
					if ($pokemon->encdetails->available) {
						if ($config->system->iv_numbers) { ?>
							<div class="progress" style="height: 15px; margin-bottom: 0">
								<div title="Attack IV: <?= $pokemon->encdetails->attack ?>" class="progress-bar progress-bar-danger" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->attack ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3)  ?>%; line-height: 16px">
									<span class="sr-only"><?= $locales->ATTACK ?> IV: <?= $pokemon->encdetails->attack ?></span><?= $pokemon->encdetails->attack ?>
								</div>
								<div title="Defense IV: <?= $pokemon->encdetails->defense ?>" class="progress-bar progress-bar-info" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->defense ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3)  ?>%; line-height: 16px">
									<span class="sr-only"><?= $locales->DEFENSE ?> IV: <?= $pokemon->encdetails->defense ?></span><?= $pokemon->encdetails->defense ?>
								</div>
								<div title="Stamina IV: <?= $pokemon->encdetails->stamina ?>" class="progress-bar progress-bar-success" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->stamina ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
									<span class="sr-only"><?= $locales->STAMINA ?> IV: <?= $pokemon->encdetails->stamina ?></span><?= $pokemon->encdetails->stamina ?>
								</div>
							</div>
						<?php 
						} else { ?>
							<div class="progress" style="height: 6px; width: 80%; margin: 5px auto 0 auto;">
								<div title="Attack IV: <?= $pokemon->encdetails->attack ?>" class="progress-bar progress-bar-danger" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->attack ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= ((100 / 15) * $pokemon->encdetails->attack) / 3 ?>%">
									<span class="sr-only"><?= $locales->ATTACK ?> IV: <?= $pokemon->encdetails->attack ?></span>
								</div>
								<div title="Defense IV: <?= $pokemon->encdetails->defense ?>" class="progress-bar progress-bar-info" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->defense ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= ((100 / 15) * $pokemon->encdetails->defense) / 3 ?>%">
									<span class="sr-only"><?= $locales->DEFENSE ?> IV: <?= $pokemon->encdetails->defense ?></span>
								</div>
								<div title="Stamina IV: <?= $pokemon->encdetails->stamina ?>" class="progress-bar progress-bar-success" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->stamina ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= ((100 / 15) * $pokemon->encdetails->stamina) / 3 ?>%">
									<span class="sr-only"><?= $locales->STAMINA ?> IV: <?= $pokemon->encdetails->stamina ?></span>
								</div>
							</div>
					<?php
						} ?>
						<small><?= $pokemon->encdetails->cp ?></small>
					<?php
					} else {
						if ($config->system->iv_numbers) { ?>
							<div class="progress" style="height: 15px; margin-bottom: 0">
								<div title="Attack IV: not available" class="progress-bar progress-bar-danger" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->attack ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3)  ?>%; line-height: 16px">
									<span class="sr-only"><?= $locales->ATTACK ?> IV: <?= $locales->NOT_AVAILABLE ?></span>?
								</div>
								<div title="Defense IV: not available" class="progress-bar progress-bar-info" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->defense ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3)  ?>%; line-height: 16px">
									<span class="sr-only"><?= $locales->DEFENSE ?> IV: <?= $locales->NOT_AVAILABLE ?></span>?
								</div>
								<div title="Stamina IV: not available" class="progress-bar progress-bar-success" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->stamina ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
									<span class="sr-only"><?= $locales->STAMINA ?> IV: <?= $locales->NOT_AVAILABLE ?></span>?
								</div>
							</div>
						<?php 
						} else { ?>
						<div class="progress" style="height: 6px; width: 80%; margin: 5px auto 0 auto;">
							<div title="IV not available" class="progress-bar" role="progressbar" style="width: 100%; background-color: rgb(210,210,210)" aria-valuenow="1" aria-valuemin="0" aria-valuemax="1">
								<span class="sr-only">IV <?= $locales->NOT_AVAILABLE ?></span>
							</div>
						</div>
					<?php
						} ?>
						<small>???</small>
					<?php
					}
				} ?>
				</div>
			<?php
			// Array with ids and countdowns to start at the end of this file
			$timers[$uid] = $pokemon->last_seen - time();
		} ?>
		</div>
	</div>
</div>


<div class="row big padding">
	<h2 class="text-center sub-title"><?= $locales->FIGHT_TITLE ?></h2>

		<?php 
			foreach ($home->teams as $team => $total) {
				if ($home->teams->rocket) { ?>

					<div class="col-md-3 col-sm-6 col-sm-12 team">
						<div class="row">
							<div class="col-xs-12 col-sm-12">
								<p style="margin-top:0.5em;text-align:center;"><img src="core/img/<?= $team ?>.png" alt="Team <?= $team ?>" class="img-responsive" style="display:inline-block" width=80> <strong class="total-<?= $team ?>-js">0</strong> <?= $locales->GYMS ?></p>

				<?php
				} else { ?>

					<div class="col-md-4 col-sm-6 col-sm-12 team">
						<div class="row">
							<div class="col-xs-12 col-sm-12">
								<?php
									if ($team != 'rocket') { ?>
										<p style="margin-top:0.5em;text-align:center;"><img src="core/img/<?= $team ?>.png" alt="Team <?= $team ?>" class="img-responsive" style="display:inline-block" width=80> <strong class="total-<?= $team ?>-js">0</strong> <?= $locales->GYMS ?></p>
										<?php
									}
				} ?>
							</div>
						</div>
					</div>					
				<?php
			} ?>
</div>


<script>
	document.addEventListener('DOMContentLoaded', function() {
		<?php
		foreach (array_reverse($timers, true) as $id => $countdown) { ?>
			startTimer(<?= $countdown ?>,"<?= $id ?>");
		<?php
		} ?>
	}, false);
</script>


1		<header id="single-header">
2		<div class="row">
3		<div class="col-md-12 text-center">
4		<h1>
5		<?= $config->infos->site_title ?>
6		<br>
7		<small><?= sprintf($config->infos->site_claim, $config->infos->city); ?></small>
8		</h1>
9
10		</div>
11		</div>
12		</header>
13
14		<div class="flex-container row area">
15
16		<div class="flex-item-homepage big-data"> <!-- LIVEMON -->
17		<a href="pokemon">
18		<img src="core/img/pokeball.png" alt="Visit the <?= $config->infos->site_name ?> Pokedex" width=50 class="big-icon">
19		<p><big><strong class="total-pkm-js">0</strong> Pokémon</big><br>
20		<?= sprintf($locales->WIDGET_POKEMON_SUB, $config->infos->city); ?></p>
21		</a>
22		</div>
23
24		<div class="flex-item-homepage big-data"> <!-- GYMS -->
25		<a href="gym">
26		<img src="core/img/rocket.png" alt="Discover the <?= $config->infos->site_name ?> Gyms" width=50 class="big-icon">
27		<p><big><strong class="total-gym-js">0</strong> <?= $locales->GYMS ?></big><br>
28		<?= $locales->WIDGET_GYM_SUB ?></p>
29		</a>
30
31		</div>
32
33		<?php
34	View Code Duplication	if (!$config->system->no_lures === true) {
35		?>
36		<div class="flex-item-homepage big-data"> <!-- POKESTOPS -->
37		<a href="pokestops">
38		<img src="core/img/lure-module.png" alt="Discover the <?= $config->infos->site_name ?> Pokéstops" width=50 class="big-icon">
39		<p><big><strong class="total-lure-js">0</strong> <?= $locales->LURES ?></big><br>
40		<?= sprintf($locales->WIDGET_LURES_SUB, $config->infos->city); ?></p>
41		</a>
42		</div>
43		<?php
44		}
45	View Code Duplication	if ($config->system->homepage_raids === true) {
46		?>
47		<div class="flex-item-homepage flex-item-homepage-homepage big-data"> <!-- RAIDS -->
48		<a href="raids">
49		<img src="core/img/raid.png" alt="Discover the <?= $config->infos->site_name ?> Raids" width=50
50		class="big-icon">
51		<p><big><strong class="total-raids-js">0</strong> <?= $locales->RAIDS ?></big><br>
52		<?= sprintf($locales->WIDGET_LURES_SUB, $config->infos->city); ?></p>
53		</a>
54		</div>
55		<?php
56		}
		0 ignored issues – show Coding Style introduced 2018-01-21 01:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Closing brace indented incorrectly; expected 4 spaces, found 8 Loading history...
57		?>
58
59		<div class="flex-item-homepage big-data">
60		<a href="<?= $config->homewidget->url ?>" target="_blank">
61		<img src="<?= $config->homewidget->image ?>" alt="<?= $config->homewidget->image_alt ?>" width=50 class="big-icon">
62		<p><?= $config->homewidget->text ?></p>
63		</a>
64		</div>
65
66		</div>
67
68
69		<div class="row area big-padding">
70		<div class="col-md-12 text-center">
71		<h2 class="text-center sub-title">
72		<?php
73		if ($config->system->recents_filter) { ?>
74		<?= $locales->RECENT_MYTHIC_SPAWNS ?>
75		<?php
76		} else { ?>
77		<?= $locales->RECENT_SPAWNS ?>
78		<?php
79		} ?>
80		</h2>
81		<div class="last-mon-js">
82		<?php
83		foreach ($recents as $key => $pokemon) {
84		$id = $pokemon->id;
85		$uid = $pokemon->uid; ?>
86		<div class="col-md-1 col-xs-4 pokemon-single" data-pokeid="<?= $id ?>" data-pokeuid="<?= $uid ?>" >
87		<a href="pokemon/<?= $id ?>"><img src="<?= $pokemons->pokemon->$id->img ?>" alt="<?= $pokemons->pokemon->$id->name ?>" class="img-responsive"></a>
88		<a href="pokemon/<?= $id ?>"><p class="pkmn-name"><?= $pokemons->pokemon->$id->name ?></p></a>
89		<a href="<?= $pokemon->location_link ?>" target="_blank">
90		<small class="pokemon-timer">00:00:00</small>
91		</a>
92		<?php
93		if ($config->system->recents_encounter_details) {
94		if ($pokemon->encdetails->available) {
95		if ($config->system->iv_numbers) { ?>
96		<div class="progress" style="height: 15px; margin-bottom: 0">
97		<div title="Attack IV: <?= $pokemon->encdetails->attack ?>" class="progress-bar progress-bar-danger" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->attack ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
98		<span class="sr-only"><?= $locales->ATTACK ?> IV: <?= $pokemon->encdetails->attack ?></span><?= $pokemon->encdetails->attack ?>
99		</div>
100		<div title="Defense IV: <?= $pokemon->encdetails->defense ?>" class="progress-bar progress-bar-info" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->defense ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
101		<span class="sr-only"><?= $locales->DEFENSE ?> IV: <?= $pokemon->encdetails->defense ?></span><?= $pokemon->encdetails->defense ?>
102		</div>
103		<div title="Stamina IV: <?= $pokemon->encdetails->stamina ?>" class="progress-bar progress-bar-success" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->stamina ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
104		<span class="sr-only"><?= $locales->STAMINA ?> IV: <?= $pokemon->encdetails->stamina ?></span><?= $pokemon->encdetails->stamina ?>
105		</div>
106		</div>
107		<?php
108		} else { ?>
109		<div class="progress" style="height: 6px; width: 80%; margin: 5px auto 0 auto;">
110		<div title="Attack IV: <?= $pokemon->encdetails->attack ?>" class="progress-bar progress-bar-danger" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->attack ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= ((100 / 15) * $pokemon->encdetails->attack) / 3 ?>%">
111		<span class="sr-only"><?= $locales->ATTACK ?> IV: <?= $pokemon->encdetails->attack ?></span>
112		</div>
113		<div title="Defense IV: <?= $pokemon->encdetails->defense ?>" class="progress-bar progress-bar-info" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->defense ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= ((100 / 15) * $pokemon->encdetails->defense) / 3 ?>%">
114		<span class="sr-only"><?= $locales->DEFENSE ?> IV: <?= $pokemon->encdetails->defense ?></span>
115		</div>
116		<div title="Stamina IV: <?= $pokemon->encdetails->stamina ?>" class="progress-bar progress-bar-success" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->stamina ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= ((100 / 15) * $pokemon->encdetails->stamina) / 3 ?>%">
117		<span class="sr-only"><?= $locales->STAMINA ?> IV: <?= $pokemon->encdetails->stamina ?></span>
118		</div>
119		</div>
120		<?php
121		} ?>
122		<small><?= $pokemon->encdetails->cp ?></small>
123		<?php
124		} else {
125		if ($config->system->iv_numbers) { ?>
126		<div class="progress" style="height: 15px; margin-bottom: 0">
127		<div title="Attack IV: not available" class="progress-bar progress-bar-danger" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->attack ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
128		<span class="sr-only"><?= $locales->ATTACK ?> IV: <?= $locales->NOT_AVAILABLE ?></span>?
129		</div>
130		<div title="Defense IV: not available" class="progress-bar progress-bar-info" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->defense ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
131		<span class="sr-only"><?= $locales->DEFENSE ?> IV: <?= $locales->NOT_AVAILABLE ?></span>?
132		</div>
133		<div title="Stamina IV: not available" class="progress-bar progress-bar-success" role="progressbar" aria-valuenow="<?= $pokemon->encdetails->stamina ?>" aria-valuemin="0" aria-valuemax="45" style="width: <?= (100 / 3) ?>%; line-height: 16px">
134		<span class="sr-only"><?= $locales->STAMINA ?> IV: <?= $locales->NOT_AVAILABLE ?></span>?
135		</div>
136		</div>
137		<?php
138		} else { ?>
139		<div class="progress" style="height: 6px; width: 80%; margin: 5px auto 0 auto;">
140		<div title="IV not available" class="progress-bar" role="progressbar" style="width: 100%; background-color: rgb(210,210,210)" aria-valuenow="1" aria-valuemin="0" aria-valuemax="1">
141		<span class="sr-only">IV <?= $locales->NOT_AVAILABLE ?></span>
142		</div>
143		</div>
144		<?php
145		} ?>
146		<small>???</small>
147		<?php
148		}
149		} ?>
150		</div>
151		<?php
152		// Array with ids and countdowns to start at the end of this file
153		$timers[$uid] = $pokemon->last_seen - time();
154		} ?>
155		</div>
156		</div>
157		</div>
158
159
160		<div class="row big padding">
161		<h2 class="text-center sub-title"><?= $locales->FIGHT_TITLE ?></h2>
162
163		<?php
164		foreach ($home->teams as $team => $total) {
165		if ($home->teams->rocket) { ?>
166
167		<div class="col-md-3 col-sm-6 col-sm-12 team">
168		<div class="row">
169		<div class="col-xs-12 col-sm-12">
170		<p style="margin-top:0.5em;text-align:center;"><img src="core/img/<?= $team ?>.png" alt="Team <?= $team ?>" class="img-responsive" style="display:inline-block" width=80> <strong class="total-<?= $team ?>-js">0</strong> <?= $locales->GYMS ?></p>
171
172		<?php
173		} else { ?>
174
175		<div class="col-md-4 col-sm-6 col-sm-12 team">
176		<div class="row">
177		<div class="col-xs-12 col-sm-12">
178		<?php
179		if ($team != 'rocket') { ?>
180		<p style="margin-top:0.5em;text-align:center;"><img src="core/img/<?= $team ?>.png" alt="Team <?= $team ?>" class="img-responsive" style="display:inline-block" width=80> <strong class="total-<?= $team ?>-js">0</strong> <?= $locales->GYMS ?></p>
181		<?php
182		}
183		} ?>
184		</div>
185		</div>
186		</div>
187		<?php
188		} ?>
189		</div>
190
191
192		<script>
193		document.addEventListener('DOMContentLoaded', function() {
194		<?php
195		foreach (array_reverse($timers, true) as $id => $countdown) { ?>
196		startTimer(<?= $countdown ?>,"<?= $id ?>");
197		<?php
198		} ?>
199		}, false);
200		</script>
201

brusselopole / Worldopole

Pull Request — master (#347)

pages/home.page.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like