functions.php ➔ gym_level() - Code Metrics - Inspection of "Fix loading of gyms without details (fix #219)" - brusselopole/Worldopole - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#273)

by Markus

created 2017-04-23 14:05 UTC

functions.php ➔ gym_level() D

↳ Parent: Project

Complexity

Conditions	10
Paths	10

Size

Total Lines	28
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	23
nc	10
nop	1
dl	0
loc	28
rs	4.8196
c	0
b	0
f	0

How to fix Complexity

<?php

########################################################################
// Human Time Ago
// @param $timestamp	=> timestamp (mandatory)
// @param $locales	=> locales (mandatory)
//
// Return time ago at human format (eg: 2 hours ago)
########################################################################

function time_ago($timestamp, $locales)
{

	// Set up our variables.
	$minute_in_seconds = 60;
	$hour_in_seconds   = $minute_in_seconds * 60;
	$day_in_seconds	   = $hour_in_seconds * 24;
	$week_in_seconds   = $day_in_seconds * 7;
	$month_in_seconds  = $day_in_seconds * 30;
	$year_in_seconds   = $day_in_seconds * 365;

	// current time
	$now = time();

	// Calculate the time difference between the current time reference point and the timestamp we're comparing.
	// The difference is defined negative, when in the future.
	$time_difference = $now - $timestamp;

	// Calculate the time ago using the smallest applicable unit.
	if ($time_difference < $hour_in_seconds) {
		$difference_value = abs(round($time_difference / $minute_in_seconds));
		$difference_label = 'MINUTE';
	} elseif ($time_difference < $day_in_seconds) {
		$difference_value = abs(round($time_difference / $hour_in_seconds));
		$difference_label = 'HOUR';
	} elseif ($time_difference < $week_in_seconds) {
		$difference_value = abs(round($time_difference / $day_in_seconds));
		$difference_label = 'DAY';
	} elseif ($time_difference < $month_in_seconds) {
		$difference_value = abs(round($time_difference / $week_in_seconds));
		$difference_label = 'WEEK';
	} elseif ($time_difference < $year_in_seconds) {
		$difference_value = abs(round($time_difference / $month_in_seconds));
		$difference_label = 'MONTH';
	} else {
		$difference_value = abs(round($time_difference / $year_in_seconds));
		$difference_label = 'YEAR';
	}

	// plural
	if ($difference_value != 1) {
		$difference_label = $difference_label.'S';
	}

	if ($time_difference <= 0) {
		// Present
		return sprintf($locales->TIME_LEFT, $difference_value.' '.$locales->$difference_label);
	} else {
		// Past
		return sprintf($locales->TIME_AGO, $difference_value.' '.$locales->$difference_label);
	}
}


########################################################################
// Percent calculator
// @param $val		=> int (mandatory)
// @param $val_total	=> int (mandatory)
//
// Return pourcent from total
########################################################################

function percent($val, $val_total)
{
	$count1 = $val_total / $val;
	$count2 = $count1 * 100;

	$count = number_format($count2, 0);

	return $count;
}


########################################################################
// File version (unix timestamp)
// @param $url		=> string (mandatory)
//
// Return $url with last_modified unix timestamp before suffix
########################################################################

function auto_ver($url)
{
	$path = pathinfo($url);
	$ver = '.'.filemtime(SYS_PATH.'/'.$url).'.';
	echo $path['dirname'].'/'.preg_replace('/\.(css|js)$/', $ver."$1", $path['basename']);
}


########################################################################
// File age in secs
// @param $filepath     => string (mandatory)
//
// Return file age of file in secs, PHP_INT_MAX if file doesn't exist
########################################################################

function file_update_ago($filepath)
{
	if (is_file($filepath)) {
		$filemtime = filemtime($filepath);
		$now = time();
		$diff = $now - $filemtime;
		return $diff;
	}
	// file doesn't exist yet!
	return PHP_INT_MAX;
}


########################################################################
// Only keep data after $timestamp in $array (compared to 'timestamp' key)
// @param $array     => array (mandatory)
// @param $timestamp => int (mandatory)
//
// Return trimmed array
########################################################################

function trim_stats_json($array, $timestamp)
{
	foreach($array as $key => $value) {

		if ($value['timestamp'] < $timestamp) {
			unset($array[$key]);
		}
	}
	return $array;
}


########################################################################
// gym level from prestige value
// @param $prestige => int (mandatory)
//
// Return gym level
########################################################################

function gym_level($prestige)
{
	$gym_level=0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

	if ($prestige < 2000) {
		$gym_level = 1;
	} elseif ($prestige < 4000) {
		$gym_level = 2;
	} elseif ($prestige < 8000) {
		$gym_level = 3;
	} elseif ($prestige < 12000) {
		$gym_level = 4;
	} elseif ($prestige < 16000) {
		$gym_level = 5;
	} elseif ($prestige < 20000) {
		$gym_level = 6;
	} elseif ($prestige < 30000) {
		$gym_level = 7;
	} elseif ($prestige < 40000) {
		$gym_level = 8;
	} elseif ($prestige < 50000) {
		$gym_level = 9;
	} else {
		$gym_level = 10;
	}

        return $gym_level;
}


1			<?php
2
3			########################################################################
4			// Human Time Ago
5			// @param $timestamp => timestamp (mandatory)
6			// @param $locales => locales (mandatory)
7			//
8			// Return time ago at human format (eg: 2 hours ago)
9			########################################################################
10
11			function time_ago($timestamp, $locales)
12			{
13
14			// Set up our variables.
15			$minute_in_seconds = 60;
16			$hour_in_seconds = $minute_in_seconds * 60;
17			$day_in_seconds = $hour_in_seconds * 24;
18			$week_in_seconds = $day_in_seconds * 7;
19			$month_in_seconds = $day_in_seconds * 30;
20			$year_in_seconds = $day_in_seconds * 365;
21
22			// current time
23			$now = time();
24
25			// Calculate the time difference between the current time reference point and the timestamp we're comparing.
26			// The difference is defined negative, when in the future.
27			$time_difference = $now - $timestamp;
28
29			// Calculate the time ago using the smallest applicable unit.
30			if ($time_difference < $hour_in_seconds) {
31			$difference_value = abs(round($time_difference / $minute_in_seconds));
32			$difference_label = 'MINUTE';
33			} elseif ($time_difference < $day_in_seconds) {
34			$difference_value = abs(round($time_difference / $hour_in_seconds));
35			$difference_label = 'HOUR';
36			} elseif ($time_difference < $week_in_seconds) {
37			$difference_value = abs(round($time_difference / $day_in_seconds));
38			$difference_label = 'DAY';
39			} elseif ($time_difference < $month_in_seconds) {
40			$difference_value = abs(round($time_difference / $week_in_seconds));
41			$difference_label = 'WEEK';
42			} elseif ($time_difference < $year_in_seconds) {
43			$difference_value = abs(round($time_difference / $month_in_seconds));
44			$difference_label = 'MONTH';
45			} else {
46			$difference_value = abs(round($time_difference / $year_in_seconds));
47			$difference_label = 'YEAR';
48			}
49
50			// plural
51			if ($difference_value != 1) {
52			$difference_label = $difference_label.'S';
53			}
54
55			if ($time_difference <= 0) {
56			// Present
57			return sprintf($locales->TIME_LEFT, $difference_value.' '.$locales->$difference_label);
58			} else {
59			// Past
60			return sprintf($locales->TIME_AGO, $difference_value.' '.$locales->$difference_label);
61			}
62			}
63
64
65			########################################################################
66			// Percent calculator
67			// @param $val => int (mandatory)
68			// @param $val_total => int (mandatory)
69			//
70			// Return pourcent from total
71			########################################################################
72
73			function percent($val, $val_total)
74			{
75			$count1 = $val_total / $val;
76			$count2 = $count1 * 100;
77
78			$count = number_format($count2, 0);
79
80			return $count;
81			}
82
83
84			########################################################################
85			// File version (unix timestamp)
86			// @param $url => string (mandatory)
87			//
88			// Return $url with last_modified unix timestamp before suffix
89			########################################################################
90
91			function auto_ver($url)
92			{
93			$path = pathinfo($url);
94			$ver = '.'.filemtime(SYS_PATH.'/'.$url).'.';
95			echo $path['dirname'].'/'.preg_replace('/\.(css\|js)$/', $ver."$1", $path['basename']);
96			}
97
98
99			########################################################################
100			// File age in secs
101			// @param $filepath => string (mandatory)
102			//
103			// Return file age of file in secs, PHP_INT_MAX if file doesn't exist
104			########################################################################
105
106			function file_update_ago($filepath)
107			{
108			if (is_file($filepath)) {
109			$filemtime = filemtime($filepath);
110			$now = time();
111			$diff = $now - $filemtime;
112			return $diff;
113			}
114			// file doesn't exist yet!
115			return PHP_INT_MAX;
116			}
117
118
119			########################################################################
120			// Only keep data after $timestamp in $array (compared to 'timestamp' key)
121			// @param $array => array (mandatory)
122			// @param $timestamp => int (mandatory)
123			//
124			// Return trimmed array
125			########################################################################
126
127			function trim_stats_json($array, $timestamp)
128			{
129			foreach($array as $key => $value) {
			0 ignored issues – show Coding Style introduced 2017-04-21 00:42 UTC by Report Bug Copy Issue Report Expected 1 space after FOREACH keyword; 0 found Loading history...
130			if ($value['timestamp'] < $timestamp) {
131			unset($array[$key]);
132			}
133			}
134			return $array;
135			}
136
137
138			########################################################################
139			// gym level from prestige value
140			// @param $prestige => int (mandatory)
141			//
142			// Return gym level
143			########################################################################
144
145			function gym_level($prestige)
146			{
147			$gym_level=0;
			0 ignored issues – show Unused Code introduced 2017-04-23 14:11 UTC by Report Bug Copy Issue Report `$gym_level` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
148
149			if ($prestige < 2000) {
150			$gym_level = 1;
151			} elseif ($prestige < 4000) {
152			$gym_level = 2;
153			} elseif ($prestige < 8000) {
154			$gym_level = 3;
155			} elseif ($prestige < 12000) {
156			$gym_level = 4;
157			} elseif ($prestige < 16000) {
158			$gym_level = 5;
159			} elseif ($prestige < 20000) {
160			$gym_level = 6;
161			} elseif ($prestige < 30000) {
162			$gym_level = 7;
163			} elseif ($prestige < 40000) {
164			$gym_level = 8;
165			} elseif ($prestige < 50000) {
166			$gym_level = 9;
167			} else {
168			$gym_level = 10;
169			}
170
171			return $gym_level;
172			}
173

brusselopole / Worldopole

Pull Request — master (#273)

functions.php ➔ gym_level() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like