Issues in pokemon.page.php - Failed Issues - Inspection of "Combine PR #353 with #363 & Code formatting" - brusselopole/Worldopole - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#371)

unknown

created 2019-02-03 13:25 UTC

pages/pokemon.page.php (46 issues)

Labels

Coding Style 46

Severity

Informational 46

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<!-- Header -->
<header id="single-header">

	<!-- Breadcrumb -->
	<div class="row">
		<div class="col-md-12">
			<ol class="breadcrumb">
				<li><a href="<?= HOST_URL; ?>"><?= $locales->HOME; ?></a></li>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<li><a href="pokemon"><?= $locales->NAV_POKEDEX; ?></a></li>
				<li class="active"><?= $pokemon->name; ?></li>
			</ol>
		</div>
	</div>
	<!-- /Breadcrumb -->

	<div class="row">

		<div class="col-sm-1 hidden-xs">

				<?php if ($pokemon->id - 1 > 0) {

    ?>

				<p class="nav-links"><a href="pokemon/<?= $pokemon->id - 1; ?>"><i class="fa fa-chevron-left"></i></a></p>

				<?php
}?>

		</div>

		<div class="col-sm-10 text-center">

			<h1>#<?= sprintf('%03d <strong>%s</strong>', $pokemon->id, $pokemon->name); ?><br>
			<small>[<?= $pokemon->rarity; ?>]</small></h1>

			<p id="share">
				<a href="https://www.facebook.com/sharer/sharer.php?u=<?= HOST_URL; ?>pokemon/<?= $pokemon->id; ?>" target="_blank" class="btn btn-primary" title="<?php printf($locales->SHARE, 'Facebook'); ?>" ><?php printf($locales->SHARE, ''); ?> <i class="fa fa-facebook" aria-hidden="true"></i></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

				<a href="https://twitter.com/intent/tweet?source=<?= HOST_URL; ?>pokemon/<?= $pokemon_id; ?>&text=Find%20<?= $pokemon->name; ?>%20in:%20<?= $config->infos->city; ?>%20<?= HOST_URL; ?>pokemon/<?= $pokemon->id; ?>" target="_blank" title="<?php printf($locales->SHARE, 'Twitter'); ?>" class="btn btn-info"><?php printf($locales->SHARE, ''); ?> <i class="fa fa-twitter" aria-hidden="true"></i></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</p>

		</div>


		<div class="col-sm-1 hidden-xs">

			<?php if ($pokemon->id + 1 < $config->system->max_pokemon) {
        ?>

			<p class="nav-links"><a href="pokemon/<?= $pokemon->id + 1; ?>"><i class="fa fa-chevron-right"></i></a></p>

			<?php
    } ?>

		</div>

	</div>
<?php
    $form_array = array('Unset', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'W', 'X', 'Y', 'Z');
    $form_array = array_values($form_array);
    ?>

</header>
<!-- /Header -->


<div class="row">
	<div class="col-md-2 col-xs-4">
		<div id="poke-img" style="padding-top:15px;margin-bottom:1em;">
			<img class="media-object img-responsive" src="<?= $pokemon->img; ?>" alt="<?= $pokemon->name; ?> model" >
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
		</div>
	</div>

	<div class="col-md-4 col-xs-8" style="margin-bottom:1em;">

		<div class="media">
			<div class="media-body" style="padding-top:25px;">

				<p><?= $pokemon->description; ?></p>

				<p>
				<?php foreach ($pokemon->types as $type) {
        ?>
					<span class="label label-default" style="background-color:<?= $pokemons->typecolors->$type; ?>"><?= $type; ?></span>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<?php
    }?>

				</p>

			</div>
		</div>

	</div>

	<div class="col-md-6" style="padding-top:10px;">
		<canvas id="spawn_chart" width="100%" height="40"></canvas>
	</div>

</div>



<div class="row">
	<div class="col-md-6" style="padding-top:10px;">
		<div class="table-responsive">
		<table class="table">
            <tr>
                <td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_GEN; ?></strong></td>
                <td class="col-md-4 col-xs-4"><?= $pokemon->gen; ?></td>
            </tr>
			<tr>
				<td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_SEEN; ?></strong></td>
				<td class="col-md-4 col-xs-4">

				<?php
                if (isset($pokemon->last_position)) {
                    ?>

					<a href="https://maps.google.com/?q=<?= $pokemon->last_position->latitude; ?>,<?= $pokemon->last_position->longitude; ?>&ll=<?= $pokemon->last_position->latitude; ?>,<?= $pokemon->last_position->longitude; ?>&z=16" target="_blank"><?= time_ago($pokemon->last_seen, $locales); ?></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

				    <?php
                } else {
                    echo $locales->NEVER;
                }
                ?>

				</td>
			</tr>
			<tr>
				<td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_AMOUNT; ?></strong></td>
				<td class="col-md-4 col-xs-4"><?= $pokemon->spawn_count; ?> <?= $locales->SEEN; ?></td>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</tr>
			<tr>
				<td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_RATE; ?></strong></td>
				<td class="col-md-4 col-xs-4"><?= $pokemon->spawns_per_day; ?> / <?= $locales->DAY; ?></td>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</tr>
			<tr>
				<td class="col-md-8 col-xs-8">
                    <?php
                    if (isset($pokemon->protected_gyms)) {
                        echo '<strong>'.$locales->POKEMON_GYM.$pokemon->name.'</strong>';
                    } ?>
                </td>
				<td class="col-md-4 col-xs-4">
                    <?php
                    if (isset($pokemon->protected_gyms)) {
                        echo $pokemon->protected_gyms;
                    }?>
                </td>
			</tr>
		</table>
		</div>
		</div>

		<div class="col-md-6" style="padding-top:10px;">
		<div class="table-responsive">
		<table class="table">
			<tr>
				<td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_RAID_SEEN; ?></strong></td>
				<td class="col-md-4 col-xs-4">

                    <?php
                    if (isset($pokemon->last_raid_position)) {
                        ?>

					    <a href="https://maps.google.com/?q=<?= $pokemon->last_raid_position->latitude; ?>,<?= $pokemon->last_raid_position->longitude; ?>&ll=<?= $pokemon->last_raid_position->latitude; ?>,<?= $pokemon->last_raid_position->longitude; ?>&z=16" target="_blank"><?= time_ago($pokemon->last_raid_seen, $locales); ?></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

					    <?php
                    } else {
                        echo $locales->NEVER;
                    }
                    ?>

				</td>
			</tr>
			<tr>
				<td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_RAID_AMOUNT; ?></strong></td>
				<td class="col-md-4 col-xs-4"><?= $pokemon->raid_count; ?> <?= $locales->SEEN; ?></td>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</tr>
			<tr>
				<td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_QUICK; ?></strong></td>
				<td class="col-md-4 col-xs-4"><?= $pokemon->quick_move; ?></td>
			</tr>
			<tr>
				<td class="col-md-8 col-xs-8"><strong><?= $locales->POKEMON_SPECIAL; ?></strong> </td>
				<td class="col-md-4 col-xs-4"><?= $pokemon->charge_move; ?></td>
			</tr>

		</table>
		</div>
	</div>
</div>


<div class="row area text-center subnav">
	<div class="btn-group" role="group">
		<a class="btn btn-default page-scroll" href="pokemon/<?= $pokemon->id; ?>#where"><i class="fa fa-map-marker"></i> <?= $locales->POKEMON_MAP; ?></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
		<a class="btn btn-default page-scroll" href="pokemon/<?= $pokemon->id; ?>#stats"><i class="fa fa-pie-chart"></i> <?= $locales->POKEMON_STATS; ?></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
		<a class="btn btn-default page-scroll" href="pokemon/<?= $pokemon->id; ?>#evolve"><i class="fa fa-flash"></i> <?= $locales->POKEMON_EVOLUTIONS; ?></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
		<a class="btn btn-default page-scroll" href="pokemon/<?= $pokemon->id; ?>#family"><i class="fa fa-share-alt"></i> <?= $locales->POKEMON_FAMILY; ?></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
		<a class="btn btn-default page-scroll" href="pokemon/<?= $pokemon->id; ?>#top50"><i class="fa fa-list"></i> Top50</a>
		<a class="btn btn-default page-scroll" href="pokemon/<?= $pokemon->id; ?>#trainer"><i class="fa fa-users"></i> <?= $locales->TRAINERS; ?></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
	</div>
</div>


<div class="row" id="where">
	<div class="col-md-12">
		<h2 class="text-center sub-title"><?= $locales->POKEMON_WHERE; ?> <?= $pokemon->name; ?>?</h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
	</div>
</div>
<div class="row text-center subnav">
	<div class="btn-group" role="group">
		<a class="btn btn-default active" id="heatmapSelector"><i class="fa fa-thermometer-three-quarters"></i> <?= $locales->POKEMON_HEATMAP_BUTTON; ?></a>
		<a class="btn btn-default " id="liveSelector"><i class="fa fa-eye"></i> <?= $locales->POKEMON_LIVE_BUTTON; ?></a>
	</div>
</div>
<div class="row" style="margin-bottom:20px">
	<div class="col-md-12" id="timeFilterContainer">
		<div id="timeSelector">
		</div>
	</div>
	<div class="col-md-12" id="liveFilterContainer">
		<div id="liveFilterSelector">
		</div>
	</div>
	<div class="col-md-12 text-center" id="loaderContainer">
		<h3><?= $locales->LOADING; ?></h3>
	</div>
</div>
<div class="row area">
	<div class="col-md-12">
		<div id="map">
		</div>
	</div>
</div>




<div class="row area" id="stats">

	<h2 class="text-center sub-title"><strong><?= $pokemon->name; ?> </strong><?= $locales->POKEMON_BREAKDOWN; ?></h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

	<!-- Rating -->
	<p class="text-center stats-data"><big><?= $pokemon->rating; ?> / 10</big><br><?= $locales->POKEMON_RATING; ?></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

	<!-- CP Datas -->
	<div class="col-md-3 stats-data">

		<p><big><?= $pokemon->max_cp; ?></big><br/><?= $locales->POKEMON_CP; ?></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

		<div class="progress" style="margin-bottom:0;">
			<div class="progress-bar progress-bar-striped active" role="progressbar" aria-valuenow="<?= $pokemon->max_cp_percent; ?>" aria-valuemin="0" aria-valuemax="100" style="width: <?= $pokemon->max_cp_percent; ?>%;min-width:30%;">
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<?= $pokemon->max_cp_percent; ?> %
			</div>
		</div>

		<?= $locales->POKEMON_COMPGAME; ?>

	</div>

	<!-- Chart -->
	<div class="col-md-6">

		<canvas id="polar_chart" width="100%" height="60"></canvas>

	</div>
	<!-- /Chart -->

	<!-- PV Datas -->
	<div class="col-md-3 stats-data">

		<p><big><?= $pokemon->max_hp; ?></big><br/><?= $locales->POKEMON_HP; ?></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

		<div class="progress" style="margin-bottom:0;">
			<div class="progress-bar progress-bar-success progress-bar-striped active" role="progressbar" aria-valuenow="<?= $pokemon->max_hp_percent; ?>" aria-valuemin="0" aria-valuemax="100" style="width: <?= $pokemon->max_hp_percent; ?>%;min-width:30%;">
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<?= $pokemon->max_hp_percent; ?> %
			</div>
		</div>

		<?= $locales->POKEMON_COMPGAME; ?>

	</div>

</div>

<div class="row area" id="evolve">

	<h2 class="text-center sub-title"><strong><?= $pokemon->name; ?> </strong><?= $locales->POKEMON_EVOLUTIONS; ?></h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

	<div class="col-md-12 flex-container-tree results">

		<?php
        $tree = array($pokemon->tree);
        $depth = get_depth($tree);
        $skip = false;
        for ($i = 0; $i < $depth; ++$i) {
            $i_id = intval(($i + 1) / 2);
            $data = get_tree_at_depth($tree, $i_id, $config->system->max_pokemon); ?>

			<?php
            if (!is_null($data) && 0 != sizeof($data) && !$skip) {
                ?>
				<div class="col-md-12 flex-item-tree">
					<?php
                    foreach ($data as $obj) {
                        $obj_id = $obj->id;
                        $tree_pokemon = $pokemons->pokemon->$obj_id;
                        $link = 'pokemon/'.$obj_id;

                        if (0 == $i % 2) {
                            ?>

							<div>
								<a href="<?= $link; ?>"><img src="<?= $tree_pokemon->img; ?>" alt="<?= $tree_pokemon->name; ?>" class="img"></a>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
								<p class="pkmn-name"><a href="<?= $link; ?>">#<?= sprintf('%03d<br>%s', $tree_pokemon->id, $tree_pokemon->name); ?></a></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							</div>

						<?php
                        } else {
                            ?>

							<div>
								<img src="core/img/arrow<?=$obj->array_sufix; ?>.png" alt="Arrow" class="img">
								<p class="pkmn-name">
									<?php
                                    if (isset($obj->candies)) {
                                        echo $obj->candies.' '.$locales->POKEMON_CANDIES;
                                    } else {
                                        echo '? '.$locales->POKEMON_CANDIES;
                                    }

                            if (isset($obj->item)) {
                                $itemName = 'ITEM_'.$obj->item;
                                echo '<br>+ '.$locales->$itemName;
                            } elseif (isset($obj->info)) {
                                $infoName = 'INFO_'.$obj->info;
                                echo '<br>('.$locales->$infoName.')';
                            } else {
                                echo '<br> </br>';
                            } ?>
								</p>
							</div>
                            <?php
                        }
                    } ?>
                </div>
            <?php
            } elseif ($skip) {
                $skip = false;
            } else {
                $skip = true;
            }
        }
        ?>
	</div>
</div>


<div class="row area" id="family">

	<div class="col-md-12">

		<h2 class="text-center sub-title"><strong><?= $pokemon->name; ?></strong><?= $locales->POKEMON_FAMILYTITLE; ?></h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

		<div class="row">

		<?php

        foreach ($related as $related_mon) {
            ?>

			<div class="col-md-1 col-sm-2 col-xs-3 pokemon-single">

				<a href="pokemon/<?= $related_mon; ?>">
					<img src="<?= $pokemons->pokemon->$related_mon->img; ?>" alt="<?= $pokemons->pokemon->$related_mon->name; ?>" class="img-responsive">
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				</a>

			</div>


			<?php
        }

        ?>

		</div>

	</div>

</div>


<?php if (!empty($top)) {
            ?>
	<div class="row area" id="top50">
		<div class="col-md-12">
			<h2 class="text-center sub-title">Top 50 <strong><?= $pokemon->name; ?></strong></h2>
			<div class="table-responsive">
				<table class="table">
					<thead>
						<tr>
							<th>#</th>
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=cp<?php echo 'cp' == $best_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50">CP <i class="fa fa-sort" aria-hidden="true"></i></a></th>
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=IV<?php echo 'IV' == $top_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50">IV <i class="fa fa-sort" aria-hidden="true"></i></a></th>
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=individual_attack<?php echo 'individual_attack' == $top_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50"><?= $locales->POKEMON_TABLE_ATTACK; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=individual_defense<?php echo 'individual_defense' == $top_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50"><?= $locales->POKEMON_TABLE_DEFENSE; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=individual_stamina<?php echo 'individual_stamina' == $top_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50"><?= $locales->POKEMON_TABLE_STAMINA; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=move_1<?php echo 'move_1' == $top_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50">1. <?= $locales->MOVE; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=move_2<?php echo 'move_2' == $top_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50">2. <?= $locales->MOVE; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=disappear_time<?php echo 'disappear_time' == $top_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#top50"><?= $locales->DATE; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<?php if (201 == $pokemon->id) {
                ?>
								<th>Form</th>
							<?php
            } ?>

						</tr>
					</thead>
				
					<tbody>
						<?php
                        $i = 0;
            foreach ($top as $top50) {
                ++$i;
                $move1 = $top50->move_1;
                $move2 = $top50->move_2; ?>

							<tr>
								<td><?= $i; ?></td>
								<td><?= isset($top50->cp) ? $top50->cp : '???'; ?></td>
								<td><?= $top50->IV; ?> %</td>
								<td><?= $top50->individual_attack; ?></td>
								<td><?= $top50->individual_defense; ?></td>
								<td><?= $top50->individual_stamina; ?></td>
								<td><?php echo $move->$move1->name; ?></td>
								<td><?php echo $move->$move2->name; ?></td>
								<td><a href="https://maps.google.com/?q=<?= $top50->latitude; ?>,<?= $top50->longitude; ?>&ll=<?= $top50->latitude; ?>,<?= $top50->longitude; ?>&z=16"
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
									target="_blank"><?=$top50->distime; ?></a></td>
								<?php if (201 == $pokemon->id && $top50->form) {
                    ?>
									<td><?php echo $form_array[$top50->form]; ?></td>
								<?php
                } else {

                    ?>
									<td></td>
								<?php
                } ?>
							</tr>
							<?php
            } ?>
				</tbody>
			</table>
		</div>
	</div>
</div>

<?php
        } if ($toptrainer) {

            ?>
	<div class="row" id="trainer">
		<div class="col-md-12">
			<h2 class="text-center sub-title"><?= $locales->POKEMON_TOPTRAINER; ?> <strong><?= $pokemon->name; ?></strong></h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			<div class="table-responsive">
				<table class="table">
					<thead>
						<tr>
							<th>#</th>
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=trainer_name<?php echo 'trainer_name' == $best_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#trainer"><?= $locales->NAME; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=cp<?php echo 'cp' == $best_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#trainer">CP <i class="fa fa-sort" aria-hidden="true"></i></a></th>
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=IV<?php echo 'IV' == $best_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#trainer">IV <i class="fa fa-sort" aria-hidden="true"></i></a></th>
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=move_1<?php echo 'move_1' == $best_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#trainer">1. <?= $locales->MOVE; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=move_2<?php echo 'move_2' == $best_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#trainer">2. <?= $locales->MOVE; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
							<th><a href="pokemon/<?= $pokemon->id; ?>?order=last_seen<?php echo 'last_seen' == $best_order && !isset($_GET['direction']) ? '&direction=desc' : ''; ?>#trainer"><?= $locales->POKEMON_TABLE_SEEN; ?> <i class="fa fa-sort" aria-hidden="true"></i></a></th>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
						</tr>
					</thead>
					<tbody>
						<?php
                        $i = 0;
            foreach ($toptrainer as $besttrainer) {
                ++$i;
                $move1 = $besttrainer->move_1;
                $move2 = $besttrainer->move_2; ?>

							<tr>
								<td><?= $i; ?></td>
								<td><a href="trainer?name=<?=$besttrainer->trainer_name; ?>"><?=$besttrainer->trainer_name; ?> </a></td>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
								<td><?= $besttrainer->cp; ?></td>
								<td><?= $besttrainer->IV; ?> %</td>
								<td><?php echo $move->$move1->name; ?></td>
								<td><?php echo $move->$move2->name; ?></td>
								<td><?=$besttrainer->lasttime; ?></td>
							</tr>
							<?php
            } ?>
				</tbody>
			</table>
		</div>
	</div>
</div>
<?php
        } ?>


1			<!-- Header -->
2			<header id="single-header">
3
4			<!-- Breadcrumb -->
5			<div class="row">
6			<div class="col-md-12">
7			<ol class="breadcrumb">
8			<li><a href="<?= HOST_URL; ?>"><?= $locales->HOME; ?></a></li>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
9			<li><a href="pokemon"><?= $locales->NAV_POKEDEX; ?></a></li>
10			<li class="active"><?= $pokemon->name; ?></li>
11			</ol>
12			</div>
13			</div>
14			<!-- /Breadcrumb -->
15
16			<div class="row">
17
18			<div class="col-sm-1 hidden-xs">
19
20			<?php if ($pokemon->id - 1 > 0) {
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The opening PHP tag must be the first content in the file Loading history...
21			?>
22
23			<p class="nav-links"><a href="pokemon/<?= $pokemon->id - 1; ?>"><i class="fa fa-chevron-left"></i></a></p>
24
25			<?php
26			}?>
27
28			</div>
29
30			<div class="col-sm-10 text-center">
31
32			<h1>#<?= sprintf('%03d <strong>%s</strong>', $pokemon->id, $pokemon->name); ?><br>
33			<small>[<?= $pokemon->rarity; ?>]</small></h1>
34
35			<p id="share">
36			<a href="https://www.facebook.com/sharer/sharer.php?u=<?= HOST_URL; ?>pokemon/<?= $pokemon->id; ?>" target="_blank" class="btn btn-primary" title="<?php printf($locales->SHARE, 'Facebook'); ?>" ><?php printf($locales->SHARE, ''); ?> <i class="fa fa-facebook" aria-hidden="true"></i></a>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
37

brusselopole / Worldopole

Pull Request — master (#371)

pages/pokemon.page.php (46 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like