Issues in gym.page.php - Failed Issues - Inspection of "Combine PR #353 with #363 & Code formatting" - brusselopole/Worldopole - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#371)

unknown

created 2019-02-03 13:25 UTC

pages/gym.page.php (9 issues)

Labels

Coding Style 9

Severity

Informational 9

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<header id="single-header">
	<div class="row">
		<div class="col-md-12 text-center">
			<h1>
				<?= $locales->GYMS_TITLE; ?>
			</h1>

		</div>
	</div>
</header>


<div class="row teams">


	<?php

    foreach ($teams as $team_name => $team) {
        // We do not display the team rocket result as it's not a real team

        if ('rocket' != $team_name) {
            $upper_team_name = strtoupper($team_name);
            $lower_team_name = strtolower($team_name); ?>

	<div class="col-md-4 col-sm-4 col-xs-12 big-data"> <!-- <?= $team_name; ?> -->

		<h2 style="margin:0;"><img src="core/img/<?= $lower_team_name; ?>.png" alt="<?= $locales->TEAM; ?> <?= $team_name; ?> logo" width=50 style="display:inline-block;" class="team-logo" /> <?= $locales->TEAM; ?> <?= $locales->$upper_team_name; ?></h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;

		<div class="row" style="margin-top:1em;">
			<div class="col-xs-6">
				<p><big><strong class="gym-<?= $team_name; ?>-js"><span>0</span></strong></big><br><?= $locales->GYMS_OWNED; ?></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</div>

			<div class="col-xs-6">
				<p><big><strong><span class="average-<?= $team_name; ?>-js">0</span></strong></big><br><?= $locales->GYMS_AVERAGE; ?></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</div>
		</div>

		<div class="row">
			<p style="margin-top:1em"><?= $locales->GYMS_GUARDIANS; ?></p>

			<?php foreach ($team->guardians as $guardian) {
                ?>

				<div class="col-xs-4 pokemon-single">
					<a href="pokemon/<?= $guardian; ?>">
					<img src="<?= $pokemons->pokemon->$guardian->img; ?>" alt="<?= $pokemons->pokemon->$guardian->name; ?>" class="img-responsive" width=150>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
					</a>
				</div>


			<?php
            } ?>


		</div>
	</div>

	<?php
        }
    }?>

</div>

<!-- auto hide buttons if no url is set in variables.json -->
<?php if ($config->urls->fb_mystic || $config->urls->fb_valor || $config->urls->fb_instinct) {
        ?>
<div class="row hidden-xs hiddem-sm area">
	<div class="col-md-4">
		<p align="center"><a href="<?= $config->urls->fb_mystic; ?>" target="_blank" class="btn btn-default"><i class="fa fa-facebook"></i> <?= $locales->TEAM; ?> <?= $locales->MYSTIC; ?></a></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
	</div>

	<div class="col-md-4">
		<p align="center"><a href="<?= $config->urls->fb_valor; ?>" target="_blank" class="btn btn-default"><i class="fa fa-facebook"></i> <?= $locales->TEAM; ?> <?= $locales->VALOR; ?></a></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
	</div>

	<div class="col-md-4">
		<p align="center"><a href="<?= $config->urls->fb_instinct; ?>" target="_blank" class="btn btn-default"><i class="fa fa-facebook"></i> <?= $locales->TEAM; ?> <?= $locales->INSTINCT; ?></a></p>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
	</div>
</div>
<?php
    } ?>


<div class="row">
	<div class="col-md-12">
		<div id="map"></div>
	</div>
</div>
<div id="gym_details_template_container">
	<div class="row area gym_details" id="gym_details_template">
		<div id="gymDetail">
			<div id="gymInfos">
				<div id="circleImage"></div>
				<div id="gymName"></div>
				<div id="gymHistory"><a href="#">Show History</a></div>
				<div id="gymPrestige">
					<?= $locales->PRESTIGE; ?>: <span id="gymPrestigeDisplay"></span>
				</div>
				<div id="gymLastScanned">
					<?= $locales->LAST_SCANNED; ?>: <span id="gymLastScannedDisplay"></span>
				</div>
				<div id="gymDefenders" class="pokemon-single">
					<?= $locales->GYMS_NO_DEFENDER; ?>
				</div>
			</div>
		</div>
	</div>
</div>


1			<header id="single-header">
2			<div class="row">
3			<div class="col-md-12 text-center">
4			<h1>
5			<?= $locales->GYMS_TITLE; ?>
6			</h1>
7
8			</div>
9			</div>
10			</header>
11
12
13			<div class="row teams">
14
15
16			<?php
17
18			foreach ($teams as $team_name => $team) {
19			// We do not display the team rocket result as it's not a real team
20
21			if ('rocket' != $team_name) {
22			$upper_team_name = strtoupper($team_name);
23			$lower_team_name = strtolower($team_name); ?>
24
25			<div class="col-md-4 col-sm-4 col-xs-12 big-data"> <!-- <?= $team_name; ?> -->
26
27			<h2 style="margin:0;"><img src="core/img/<?= $lower_team_name; ?>.png" alt="<?= $locales->TEAM; ?> <?= $team_name; ?> logo" width=50 style="display:inline-block;" class="team-logo" /> <?= $locales->TEAM; ?> <?= $locales->$upper_team_name; ?></h2>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
28
29			<div class="row" style="margin-top:1em;">
30			<div class="col-xs-6">
31			<p><big><strong class="gym-<?= $team_name; ?>-js"><span>0</span></strong></big><br><?= $locales->GYMS_OWNED; ?></p>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
32			</div>
33
34			<div class="col-xs-6">
35			<p><big><strong><span class="average-<?= $team_name; ?>-js">0</span></strong></big><br><?= $locales->GYMS_AVERAGE; ?></p>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
36			</div>
37			</div>
38
39			<div class="row">
40			<p style="margin-top:1em"><?= $locales->GYMS_GUARDIANS; ?></p>
41
42			<?php foreach ($team->guardians as $guardian) {
43			?>
44
45			<div class="col-xs-4 pokemon-single">
46			<a href="pokemon/<?= $guardian; ?>">
47			<img src="<?= $pokemons->pokemon->$guardian->img; ?>" alt="<?= $pokemons->pokemon->$guardian->name; ?>" class="img-responsive" width=150>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
48			</a>
49			</div>
50
51
52			<?php
53			} ?>
			0 ignored issues – show Coding Style introduced 2017-11-14 14:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Closing brace indented incorrectly; expected 0 spaces, found 12 Loading history...
54
55			</div>
56			</div>
57
58			<?php
59			}
60			}?>
61
62			</div>
63
64			<!-- auto hide buttons if no url is set in variables.json -->
65			<?php if ($config->urls->fb_mystic \|\| $config->urls->fb_valor \|\| $config->urls->fb_instinct) {
66			?>
67			<div class="row hidden-xs hiddem-sm area">
68			<div class="col-md-4">
69			<p align="center"><a href="<?= $config->urls->fb_mystic; ?>" target="_blank" class="btn btn-default"><i class="fa fa-facebook"></i> <?= $locales->TEAM; ?> <?= $locales->MYSTIC; ?></a></p>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
70			</div>
71
72			<div class="col-md-4">
73			<p align="center"><a href="<?= $config->urls->fb_valor; ?>" target="_blank" class="btn btn-default"><i class="fa fa-facebook"></i> <?= $locales->TEAM; ?> <?= $locales->VALOR; ?></a></p>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
74			</div>
75
76			<div class="col-md-4">
77			<p align="center"><a href="<?= $config->urls->fb_instinct; ?>" target="_blank" class="btn btn-default"><i class="fa fa-facebook"></i> <?= $locales->TEAM; ?> <?= $locales->INSTINCT; ?></a></p>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
78			</div>
79			</div>
80			<?php
81			} ?>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Closing brace indented incorrectly; expected 0 spaces, found 4 Loading history...
82
83			<div class="row">
84			<div class="col-md-12">
85			<div id="map"></div>
86			</div>
87			</div>
88			<div id="gym_details_template_container">
89			<div class="row area gym_details" id="gym_details_template">
90			<div id="gymDetail">
91			<div id="gymInfos">
92			<div id="circleImage"></div>
93			<div id="gymName"></div>
94			<div id="gymHistory"><a href="#">Show History</a></div>
95			<div id="gymPrestige">
96			<?= $locales->PRESTIGE; ?>: <span id="gymPrestigeDisplay"></span>
97			</div>
98			<div id="gymLastScanned">
99			<?= $locales->LAST_SCANNED; ?>: <span id="gymLastScannedDisplay"></span>
100			</div>
101			<div id="gymDefenders" class="pokemon-single">
102			<?= $locales->GYMS_NO_DEFENDER; ?>
103			</div>
104			</div>
105			</div>
106			</div>
107			</div>
108

brusselopole / Worldopole

Pull Request — master (#371)

pages/gym.page.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like