GuardCoverageFileReaderTrait::shouldReadGuardCoverage() - Code Metrics - Inspection of "Fix not execute php tools in pre-commit when don't..." - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — guard_coverage (f2aaf0)

by Pablo

created 2016-07-03 15:19 UTC

shouldReadGuardCoverage() A

↳ Parent: GuardCoverageFileReaderTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
rs	9.4285
cc	1
eloc	5
nc	1
nop	1

<?php

namespace PhpGitHooks\Module\PhpUnit\Tests\Infrastructure;

use PhpGitHooks\Module\PhpUnit\Model\GuardCoverageFileReaderInterface;
use PhpGitHooks\Module\Tests\Infrastructure\UnitTestCase\Mock;

trait GuardCoverageFileReaderTrait
{
    /**
     * @var GuardCoverageFileReaderInterface
     */
    private $guardCoverageFileReader;

    /**
     * @return \Mockery\MockInterface|GuardCoverageFileReaderInterface
     */
    protected function getGuardCoverageFileReader()
    {
        return $this->guardCoverageFileReader = $this->guardCoverageFileReader ?: Mock::get(
            GuardCoverageFileReaderInterface::class
        );
    }

    /**
     * @param float $return
     */
    protected function shouldReadGuardCoverage($return)
    {
        $this->getGuardCoverageFileReader()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->shouldReceive('read')
            ->once()
            ->andReturn($return);
    }
}


1			<?php
2
3			namespace PhpGitHooks\Module\PhpUnit\Tests\Infrastructure;
4
5			use PhpGitHooks\Module\PhpUnit\Model\GuardCoverageFileReaderInterface;
6			use PhpGitHooks\Module\Tests\Infrastructure\UnitTestCase\Mock;
7
8			trait GuardCoverageFileReaderTrait
9			{
10			/**
11			* @var GuardCoverageFileReaderInterface
12			*/
13			private $guardCoverageFileReader;
14
15			/**
16			* @return \Mockery\MockInterface\|GuardCoverageFileReaderInterface
17			*/
18			protected function getGuardCoverageFileReader()
19			{
20			return $this->guardCoverageFileReader = $this->guardCoverageFileReader ?: Mock::get(
21			GuardCoverageFileReaderInterface::class
22			);
23			}
24
25			/**
26			* @param float $return
27			*/
28			protected function shouldReadGuardCoverage($return)
29			{
30			$this->getGuardCoverageFileReader()
			0 ignored issues – show Bug introduced 2016-07-03 15:22 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `PhpGitHooks\Module\PhpUn...rageFileReaderInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31			->shouldReceive('read')
32			->once()
33			->andReturn($return);
34			}
35			}
36

bruli / php-git-hooks

Branch — guard_coverage (f2aaf0)

shouldReadGuardCoverage() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like