PhpCsToolCommandHandlerTest::itShouldWorksFine() - Code Metrics - Inspection of "Fix not execute php tools in pre-commit when don't..." - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — guard_coverage (f2aaf0)

by Pablo

created 2016-07-03 15:19 UTC

PhpCsToolCommandHandlerTest::itShouldWorksFine() A

↳ Parent: PhpCsToolCommandHandlerTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	12

Duplication

Lines	21
Ratio	100 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	21
loc	21
rs	9.3142
cc	2
eloc	12
nc	2
nop	0

<?php

namespace PhpGitHooks\Module\PhpCs\Tests\Behaviour;

use PhpGitHooks\Module\Configuration\Service\HookQuestions;
use PhpGitHooks\Module\Git\Contract\Response\BadJobLogoResponse;
use PhpGitHooks\Module\Git\Service\PreCommitOutputWriter;
use PhpGitHooks\Module\Git\Tests\Stub\FilesCommittedStub;
use PhpGitHooks\Module\PhpCs\Contract\Command\PhpCsToolCommand;
use PhpGitHooks\Module\PhpCs\Contract\CommandHandler\PhpCsToolCommandHandler;
use PhpGitHooks\Module\PhpCs\Contract\Exception\PhpCsViolationException;
use PhpGitHooks\Module\PhpCs\Service\PhpCsTool;
use PhpGitHooks\Module\PhpCs\Tests\Infrastructure\PhpCsUnitTestCase;

class PhpCsToolCommandHandlerTest extends PhpCsUnitTestCase
{
    /**
     * @var PhpCsToolCommandHandler
     */
    private $phpCsToolCommandHandler;

    protected function setUp()
    {
        $this->phpCsToolCommandHandler = new PhpCsToolCommandHandler(
            new PhpCsTool(
                $this->getOutputInterface(),

                $this->getPhpCsToolProcessor()

            )
        );
    }

    /**
     * @test
     */
    public function itShouldThrowsException()
    {
        $this->expectException(PhpCsViolationException::class);

        $output = new PreCommitOutputWriter(PhpCsTool::EXECUTE_MESSAGE);
        $files = FilesCommittedStub::createOnlyPhpFiles();

        $this->shouldWriteOutput($output->getMessage());

        $errorTxt = null;
        foreach ($files as $file) {
            $error = 'ERROR-';
            $this->shouldProcessPhpCsTool($file, 'PSR2', $error);
            $errorTxt .= $error;
        }

        $this->shouldWriteLnOutput($output->getFailMessage());
        $this->shouldWriteLnOutput($output->setError($errorTxt));
        $this->shouldWriteLnOutput(BadJobLogoResponse::paint(HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT));

        $this->phpCsToolCommandHandler->handle(
            new PhpCsToolCommand(
                $files,
                'PSR2',
                HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT
            )
        );
    }

    /**
     * @test
     */
    public function itShouldWorksFine()

    {
        $output = new PreCommitOutputWriter(PhpCsTool::EXECUTE_MESSAGE);
        $files = FilesCommittedStub::createOnlyPhpFiles();

        $this->shouldWriteOutput($output->getMessage());

        foreach ($files as $file) {
            $this->shouldProcessPhpCsTool($file, 'PSR2', null);
        }

        $this->shouldWriteLnOutput($output->getSuccessfulMessage());

        $this->phpCsToolCommandHandler->handle(
            new PhpCsToolCommand(
                $files,
                'PSR2',
                HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT
            )
        );
    }
}


1		<?php
2
3		namespace PhpGitHooks\Module\PhpCs\Tests\Behaviour;
4
5		use PhpGitHooks\Module\Configuration\Service\HookQuestions;
6		use PhpGitHooks\Module\Git\Contract\Response\BadJobLogoResponse;
7		use PhpGitHooks\Module\Git\Service\PreCommitOutputWriter;
8		use PhpGitHooks\Module\Git\Tests\Stub\FilesCommittedStub;
9		use PhpGitHooks\Module\PhpCs\Contract\Command\PhpCsToolCommand;
10		use PhpGitHooks\Module\PhpCs\Contract\CommandHandler\PhpCsToolCommandHandler;
11		use PhpGitHooks\Module\PhpCs\Contract\Exception\PhpCsViolationException;
12		use PhpGitHooks\Module\PhpCs\Service\PhpCsTool;
13		use PhpGitHooks\Module\PhpCs\Tests\Infrastructure\PhpCsUnitTestCase;
14
15		class PhpCsToolCommandHandlerTest extends PhpCsUnitTestCase
16		{
17		/**
18		* @var PhpCsToolCommandHandler
19		*/
20		private $phpCsToolCommandHandler;
21
22		protected function setUp()
23		{
24		$this->phpCsToolCommandHandler = new PhpCsToolCommandHandler(
25		new PhpCsTool(
26		$this->getOutputInterface(),
		0 ignored issues – show Bug introduced 2016-07-03 15:22 UTC by Report Bug Copy Issue Report It seems like `$this->getOutputInterface()` targeting `PhpGitHooks\Module\Git\T...t::getOutputInterface()` can also be of type `object<Mockery\MockInterface>`; however, `PhpGitHooks\Module\PhpCs...hpCsTool::__construct()` does only seem to accept `object<Symfony\Component...Output\OutputInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
27		$this->getPhpCsToolProcessor()
		0 ignored issues – show Bug introduced 2016-07-03 15:22 UTC by Report Bug Copy Issue Report It seems like `$this->getPhpCsToolProcessor()` targeting `PhpGitHooks\Module\PhpCs...getPhpCsToolProcessor()` can also be of type `object<Mockery\MockInterface>`; however, `PhpGitHooks\Module\PhpCs...hpCsTool::__construct()` does only seem to accept `object<PhpGitHooks\Modul...ToolProcessorInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
28		)
29		);
30		}
31
32		/**
33		* @test
34		*/
35		public function itShouldThrowsException()
36		{
37		$this->expectException(PhpCsViolationException::class);
38
39		$output = new PreCommitOutputWriter(PhpCsTool::EXECUTE_MESSAGE);
40		$files = FilesCommittedStub::createOnlyPhpFiles();
41
42		$this->shouldWriteOutput($output->getMessage());
43
44		$errorTxt = null;
45		foreach ($files as $file) {
46		$error = 'ERROR-';
47		$this->shouldProcessPhpCsTool($file, 'PSR2', $error);
48		$errorTxt .= $error;
49		}
50
51		$this->shouldWriteLnOutput($output->getFailMessage());
52		$this->shouldWriteLnOutput($output->setError($errorTxt));
53		$this->shouldWriteLnOutput(BadJobLogoResponse::paint(HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT));
54
55		$this->phpCsToolCommandHandler->handle(
56		new PhpCsToolCommand(
57		$files,
58		'PSR2',
59		HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT
60		)
61		);
62		}
63
64		/**
65		* @test
66		*/
67	View Code Duplication	public function itShouldWorksFine()
		0 ignored issues – show Duplication introduced 2016-07-03 15:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		$output = new PreCommitOutputWriter(PhpCsTool::EXECUTE_MESSAGE);
70		$files = FilesCommittedStub::createOnlyPhpFiles();
71
72		$this->shouldWriteOutput($output->getMessage());
73
74		foreach ($files as $file) {
75		$this->shouldProcessPhpCsTool($file, 'PSR2', null);
76		}
77
78		$this->shouldWriteLnOutput($output->getSuccessfulMessage());
79
80		$this->phpCsToolCommandHandler->handle(
81		new PhpCsToolCommand(
82		$files,
83		'PSR2',
84		HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT
85		)
86		);
87		}
88		}
89

bruli / php-git-hooks

Branch — guard_coverage (f2aaf0)

PhpCsToolCommandHandlerTest::itShouldWorksFine() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like