WriterInterfaceTrait::getWriter() - Code Metrics - Inspection of "Fix not execute php tools in pre-commit when don't..." - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — guard_coverage (f2aaf0)

by Pablo

created 2016-07-03 15:19 UTC

WriterInterfaceTrait::getWriter() A

↳ Parent: WriterInterfaceTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	4
rs	10
cc	2
eloc	2
nc	2
nop	0

<?php

namespace PhpGitHooks\Module\Git\Tests\Infrastructure;

use PhpGitHooks\Module\Git\Model\WriterInterface;
use PhpGitHooks\Module\Tests\Infrastructure\UnitTestCase\Mock;

trait WriterInterfaceTrait
{
    /**
     * @var WriterInterface
     */
    private $writer;

    /**
     * @return \Mockery\MockInterface|WriterInterface
     */
    protected function getWriter()
    {
        return $this->writer = $this->writer ?: Mock::get(WriterInterface::class);
    }

    /**
     * @param string $data
     */
    protected function shouldWriteData($data)
    {
        $this->getWriter()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->shouldReceive('write')
            ->once()
            ->with($data);
    }
}


1			<?php
2
3			namespace PhpGitHooks\Module\Git\Tests\Infrastructure;
4
5			use PhpGitHooks\Module\Git\Model\WriterInterface;
6			use PhpGitHooks\Module\Tests\Infrastructure\UnitTestCase\Mock;
7
8			trait WriterInterfaceTrait
9			{
10			/**
11			* @var WriterInterface
12			*/
13			private $writer;
14
15			/**
16			* @return \Mockery\MockInterface\|WriterInterface
17			*/
18			protected function getWriter()
19			{
20			return $this->writer = $this->writer ?: Mock::get(WriterInterface::class);
21			}
22
23			/**
24			* @param string $data
25			*/
26			protected function shouldWriteData($data)
27			{
28			$this->getWriter()
			0 ignored issues – show Bug introduced 2016-07-03 15:22 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `PhpGitHooks\Module\Git\Model\WriterInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
29			->shouldReceive('write')
30			->once()
31			->with($data);
32			}
33			}
34

bruli / php-git-hooks

Branch — guard_coverage (f2aaf0)

WriterInterfaceTrait::getWriter() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like