PhpGitHooks\Module\PhpLint\Tests\Behaviour\PhpLintToolCommandHandlerTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	26.56 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	3
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
B	itShouldThrowsException()	0	25	2
A	itShouldWorksFine()	17	17	2

<?php

namespace PhpGitHooks\Module\PhpLint\Tests\Behaviour;

use PhpGitHooks\Module\Configuration\Service\HookQuestions;
use PhpGitHooks\Module\Configuration\Tests\Stub\PreCommitResponseStub;
use PhpGitHooks\Module\Git\Contract\Response\BadJobLogoResponse;
use PhpGitHooks\Module\Git\Service\PreCommitOutputWriter;
use PhpGitHooks\Module\Git\Tests\Stub\FilesCommittedStub;
use PhpGitHooks\Module\PhpLint\Contract\Command\PhpLintToolCommand;
use PhpGitHooks\Module\PhpLint\Contract\CommandHandler\PhpLintToolCommandHandler;
use PhpGitHooks\Module\PhpLint\Contract\Exception\PhpLintViolationsException;
use PhpGitHooks\Module\PhpLint\Service\PhpLintTool;
use PhpGitHooks\Module\PhpLint\Tests\Infrastructure\PhpLintUnitTestCase;

class PhpLintToolCommandHandlerTest extends PhpLintUnitTestCase
{
    /**
     * @var PhpLintToolCommandHandler
     */
    private $phpLintToolCommandHandler;

    protected function setUp()
    {
        $this->phpLintToolCommandHandler = new PhpLintToolCommandHandler(
            new PhpLintTool($this->getPhpLintToolProcessor(), $this->getOutputInterface())

It seems like $this->getPhpLintToolProcessor() targeting PhpGitHooks\Module\PhpLint\Tests\Infrastructure\PhpLintToolProcessorTrait::getPhpLintToolProcessor() can also be of type object<Mockery\MockInterface>; however, PhpGitHooks\Module\PhpLint\Service\PhpLintTool::__construct() does only seem to accept object<PhpGitHooks\Module\PhpLint\Model\PhpLintToolProcessorInterface>, maybe add an additional type check?

It seems like $this->getOutputInterface() targeting PhpGitHooks\Module\Git\Tests\Infrastructure\OutputInterfaceTrait::getOutputInterface() can also be of type object<Mockery\MockInterface>; however, PhpGitHooks\Module\PhpLint\Service\PhpLintTool::__construct() does only seem to accept object<Symfony\Component\Console\Output\OutputInterface>, maybe add an additional type check?

        );
    }

    /**
     * @test
     */
    public function itShouldThrowsException()
    {
        $this->expectException(PhpLintViolationsException::class);

        $phpFiles = FilesCommittedStub::createOnlyPhpFiles();
        $outputMessage = new PreCommitOutputWriter(PhpLintTool::RUNNING_PHPLINT);
        $errorMessage = PreCommitResponseStub::FIX_YOUR_CODE;

        $this->shouldWriteOutput($outputMessage->getMessage());

        $errors = null;
        foreach ($phpFiles as $file) {
            $error = 'ERROR';
            $this->shouldProcessPhpLintTool($file, $error);
            $errors .= $error;
        }

        $this->shouldWriteLnOutput($outputMessage->getFailMessage());
        $this->shouldWriteLnOutput($outputMessage->setError($errors));
        $this->shouldWriteLnOutput(BadJobLogoResponse::paint($errorMessage));

        $this->phpLintToolCommandHandler->handle(
            new PhpLintToolCommand($phpFiles, $errorMessage)
        );
    }

    /**
     * @test
     */
    public function itShouldWorksFine()

This method seems to be duplicated in your project.

    {
        $phpFiles = FilesCommittedStub::createOnlyPhpFiles();
        $outputMessage = new PreCommitOutputWriter(PhpLintTool::RUNNING_PHPLINT);

        $this->shouldWriteOutput($outputMessage->getMessage());

        foreach ($phpFiles as $file) {
            $this->shouldProcessPhpLintTool($file, null);
        }

        $this->shouldWriteLnOutput($outputMessage->getSuccessfulMessage());

        $this->phpLintToolCommandHandler->handle(
            new PhpLintToolCommand($phpFiles, HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT)
        );
    }
}