1
|
|
|
<?php |
2
|
|
|
|
3
|
|
|
namespace PhpGitHooks\Module\Composer\Contract\Command; |
4
|
|
|
|
5
|
|
|
use Bruli\EventBusBundle\CommandBus\CommandHandlerInterface; |
6
|
|
|
use Bruli\EventBusBundle\CommandBus\CommandInterface; |
7
|
|
|
use Bruli\EventBusBundle\QueryBus\QueryBus; |
8
|
|
|
use PhpGitHooks\Module\Composer\Contract\Exception\ComposerFilesNotFoundException; |
9
|
|
|
use PhpGitHooks\Module\Files\Contract\Query\ComposerFilesExtractor; |
10
|
|
|
use PhpGitHooks\Module\Files\Contract\Response\ComposerFilesResponse; |
11
|
|
|
use PhpGitHooks\Module\Git\Contract\Response\BadJobLogoResponse; |
12
|
|
|
use PhpGitHooks\Module\Git\Service\PreCommitOutputWriter; |
13
|
|
|
use Symfony\Component\Console\Output\OutputInterface; |
14
|
|
|
|
15
|
|
|
class ComposerToolHandler implements CommandHandlerInterface |
16
|
|
|
{ |
17
|
|
|
const CHECKING_MESSAGE = 'Checking composer files'; |
18
|
|
|
/** |
19
|
|
|
* @var PreCommitOutputWriter |
20
|
|
|
*/ |
21
|
|
|
private $outputMessage; |
22
|
|
|
/** |
23
|
|
|
* @var OutputInterface |
24
|
|
|
*/ |
25
|
|
|
private $output; |
26
|
|
|
/** |
27
|
|
|
* @var QueryBus |
28
|
|
|
*/ |
29
|
|
|
private $queryBus; |
30
|
|
|
/** |
31
|
|
|
* ComposerTool constructor. |
32
|
|
|
* |
33
|
|
|
* @param QueryBus $queryBus |
34
|
|
|
* @param OutputInterface $output |
35
|
|
|
*/ |
36
|
3 |
|
public function __construct( |
37
|
|
|
QueryBus $queryBus, |
38
|
|
|
OutputInterface $output |
39
|
|
|
) { |
40
|
3 |
|
$this->output = $output; |
41
|
3 |
|
$this->queryBus = $queryBus; |
42
|
3 |
|
} |
43
|
|
|
|
44
|
|
|
/** |
45
|
|
|
* @param CommandInterface|ComposerTool $command |
46
|
|
|
*/ |
47
|
3 |
|
public function handle(CommandInterface $command) |
48
|
|
|
{ |
49
|
3 |
|
$this->execute($command->getFiles(), $command->getErrorMessage()); |
|
|
|
|
50
|
2 |
|
} |
51
|
|
|
|
52
|
|
|
/** |
53
|
|
|
* @param array $files |
54
|
|
|
* @param string $errorMessage |
55
|
|
|
* |
56
|
|
|
* @throws ComposerFilesNotFoundException |
57
|
|
|
*/ |
58
|
3 |
|
private function execute(array $files, $errorMessage) |
59
|
|
|
{ |
60
|
3 |
|
$composerFilesResponse = $this->getComposerFilesResponse($files); |
61
|
|
|
|
62
|
3 |
|
$this->outputMessage = new PreCommitOutputWriter(self::CHECKING_MESSAGE); |
63
|
3 |
|
if (true === $composerFilesResponse->isExists()) { |
64
|
2 |
|
$this->output->write($this->outputMessage->getMessage()); |
65
|
|
|
|
66
|
2 |
|
$this->executeTool( |
67
|
2 |
|
$composerFilesResponse->isJsonFile(), |
68
|
2 |
|
$composerFilesResponse->isLockFile(), |
69
|
2 |
|
$errorMessage |
70
|
|
|
); |
71
|
1 |
|
$this->output->writeln($this->outputMessage->getSuccessfulMessage()); |
72
|
|
|
} |
73
|
2 |
|
} |
74
|
|
|
|
75
|
|
|
/** |
76
|
|
|
* @param bool $jsonFile |
77
|
|
|
* @param bool $lockFile |
78
|
|
|
* @param string $errorMessage |
79
|
|
|
* |
80
|
|
|
* @throws ComposerFilesNotFoundException * |
81
|
|
|
*/ |
82
|
2 |
|
private function executeTool($jsonFile, $lockFile, $errorMessage) |
83
|
|
|
{ |
84
|
2 |
|
if (true === $jsonFile && false === $lockFile) { |
85
|
1 |
|
$this->output->writeln($this->outputMessage->getFailMessage()); |
86
|
1 |
|
$this->output->writeln(BadJobLogoResponse::paint($errorMessage)); |
87
|
1 |
|
throw new ComposerFilesNotFoundException(); |
88
|
|
|
} |
89
|
1 |
|
} |
90
|
|
|
|
91
|
|
|
/** |
92
|
|
|
* @param array $files |
93
|
|
|
* |
94
|
|
|
* @return ComposerFilesResponse |
95
|
|
|
*/ |
96
|
3 |
|
private function getComposerFilesResponse(array $files) |
97
|
|
|
{ |
98
|
3 |
|
return $this->queryBus->handle(new ComposerFilesExtractor($files)); |
99
|
|
|
} |
100
|
|
|
} |
101
|
|
|
|
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: