PhpGitHooks\Infrastructure\PhpCsFixer\PhpCsFixerHandler

Complexity

Total Complexity

14

Size/Duplication

Total Lines	125
Duplicated Lines	20.8 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	11
Bugs	1	Features	2

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
C	run()	26	49	8
A	setFiles()	0	4	1
A	setFilesToAnalyze()	0	4	1
A	setLevels()	0	4	1
A	getErrors()	0	10	2

<?php

namespace PhpGitHooks\Infrastructure\PhpCsFixer;

use IgnoreFiles\IgnoreFiles;
use PhpGitHooks\Application\Message\MessageConfigData;
use PhpGitHooks\Command\BadJobLogo;
use PhpGitHooks\Command\OutputHandlerInterface;
use PhpGitHooks\Infrastructure\Common\InteractiveToolInterface;
use PhpGitHooks\Infrastructure\Common\ToolHandler;
use Symfony\Component\Process\ProcessBuilder;

class PhpCsFixerHandler extends ToolHandler implements InteractiveToolInterface, PhpCsFixerHandlerInterface
{
    /** @var array */
    private $files;
    /** @var string */
    private $filesToAnalyze;
    /** @var  array */
    private $levels = [];
    /**
     * @var IgnoreFiles
     */
    private $ignoreFiles;

    /**
     * PhpCsFixerHandler constructor.
     *
     * @param OutputHandlerInterface $outputHandler
     * @param IgnoreFiles            $ignoreFiles
     */
    public function __construct(OutputHandlerInterface $outputHandler, IgnoreFiles $ignoreFiles)
    {
        parent::__construct($outputHandler);
        $this->ignoreFiles = $ignoreFiles;
    }

    /**
     * @throws PhpCsFixerException
     */
    public function run(array $messages)
    {
        foreach ($this->levels as $level => $value) {
            if (true === $value) {
                $this->outputHandler->setTitle('Checking '.strtoupper($level).' code style with PHP-CS-FIXER');
                $this->output->write($this->outputHandler->getTitle());

                $errors = array();

                foreach ($this->files as $file) {
                    $srcFile = preg_match($this->filesToAnalyze, $file);

                    if (!$srcFile) {
                        continue;
                    }

                    if (false === $this->ignoreFiles->isIgnored($file)) {

This code seems to be duplicated across your project.

                        $processBuilder = new ProcessBuilder(
                            array(
                                'php',
                                'bin/php-cs-fixer',
                                '--dry-run',
                                'fix',
                                $file,
                                '--level='.$level,
                            )
                        );

                        $phpCsFixer = $processBuilder->getProcess();
                        $phpCsFixer->run();

                        if (false === $phpCsFixer->isSuccessful()) {
                            $errors[] = $phpCsFixer->getOutput();
                        }
                    }
                }

                if ($errors) {

The expression $errors of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This code seems to be duplicated across your project.

                    $this->outputHandler->setError($this->getErrors($errors));
                    $this->output->writeln($this->outputHandler->getError());
                    $this->output->writeln(BadJobLogo::paint($messages[MessageConfigData::KEY_ERROR_MESSAGE]));

                    throw  new PhpCsFixerException();
                }

                $this->output->writeln($this->outputHandler->getSuccessfulStepMessage());
            }
        }
    }

    /**
     * throw new PhpCsFixerException(implode('', $errors));
     * }.
     *
     * $this->output->writeln($this->outputHandler->getSuccessfulStepMessage());
     * }
     *
     * /**
     * @param array $files
     */
    public function setFiles(array $files)
    {
        $this->files = $files;
    }

    /**
     * @param string $filesToAnalyze
     */
    public function setFilesToAnalyze($filesToAnalyze)
    {
        $this->filesToAnalyze = $filesToAnalyze;
    }

    /**
     * @param array $levels
     */
    public function setLevels(array $levels)
    {
        $this->levels = $levels;
    }

    /**
     * @param array $errors
     *
     * @return null|string
     */
    private function getErrors(array $errors)
    {
        $errorText = null;

        foreach ($errors as $error) {
            $errorText .= trim($error)."\n";
        }

        return $errorText;
    }
}