PreCommitTool::isPhpFiles() - Code Metrics - Inspection of "Remove unnecesary method" - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 77f843...549cd1 )

by Pablo

created 2016-07-03 15:53 UTC

PreCommitTool::isPhpFiles() A

↳ Parent: PreCommitTool::getPhpFiles()

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace PhpGitHooks\Module\Git\Service;

use PhpGitHooks\Infrastructure\CommandBus\CommandBus\CommandBus;
use PhpGitHooks\Infrastructure\CommandBus\QueryBus\QueryBus;
use PhpGitHooks\Module\Composer\Contract\Command\ComposerToolCommand;
use PhpGitHooks\Module\Configuration\Contract\Query\ConfigurationDataFinderQuery;
use PhpGitHooks\Module\Configuration\Contract\Response\ConfigurationDataResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PreCommitResponse;
use PhpGitHooks\Module\Files\Contract\Query\PhpFilesExtractorQuery;
use PhpGitHooks\Module\Files\Contract\Response\PhpFilesResponse;
use PhpGitHooks\Module\Git\Contract\Response\GoodJobLogoResponse;
use PhpGitHooks\Module\Git\Infrastructure\Files\FilesCommittedExtractor;
use PhpGitHooks\Module\Git\Infrastructure\OutputWriter\ToolTittleOutputWriter;
use PhpGitHooks\Module\JsonLint\Contract\Command\JsonLintToolCommand;
use PhpGitHooks\Module\PhpCs\Contract\Command\PhpCsToolCommand;
use PhpGitHooks\Module\PhpCsFixer\Contract\Command\PhpCsFixerToolCommand;
use PhpGitHooks\Module\PhpLint\Contract\Command\PhpLintToolCommand;
use PhpGitHooks\Module\PhpMd\Contract\Command\PhpMdToolCommand;
use PhpGitHooks\Module\PhpUnit\Contract\Command\GuardCoverageCommand;
use PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitToolCommand;
use PhpGitHooks\Module\PhpUnit\Contract\Command\StrictCoverageCommand;
use Symfony\Component\Console\Output\OutputInterface;

class PreCommitTool
{
    const NO_FILES_CHANGED_MESSAGE = '<comment>-\_(ö)_/- No files changed.</comment>';
    const TITLE = 'Pre-Commit tool';
    /**
     * @var OutputInterface
     */
    private $output;
    /**
     * @var FilesCommittedExtractor
     */
    private $filesCommittedExtractor;
    /**
     * @var CommandBus
     */
    private $commandBus;
    /**
     * @var QueryBus
     */
    private $queryBus;
    /**
     * @var ToolTittleOutputWriter
     */
    private $tittleOutputWriter;

    /**
     * PreCommitTool constructor.
     *
     *
     * @param OutputInterface         $output
     * @param FilesCommittedExtractor $filesCommittedExtractor
     * @param QueryBus                $queryBus
     * @param CommandBus              $commandBus
     * @param ToolTittleOutputWriter  $tittleOutputWriter
     */
    public function __construct(
        OutputInterface $output,
        FilesCommittedExtractor $filesCommittedExtractor,
        QueryBus $queryBus,
        CommandBus $commandBus,
        ToolTittleOutputWriter $tittleOutputWriter
    ) {
        $this->filesCommittedExtractor = $filesCommittedExtractor;
        $this->output = $output;
        $this->commandBus = $commandBus;
        $this->queryBus = $queryBus;
        $this->tittleOutputWriter = $tittleOutputWriter;
    }

    public function execute()
    {
        $this->tittleOutputWriter->writeTitle(self::TITLE);
        $committedFiles = $this->filesCommittedExtractor->getFiles();

        if (1 === count($committedFiles)) {
            $this->output->writeln(static::NO_FILES_CHANGED_MESSAGE);

            return;
        }

        /** @var ConfigurationDataResponse $configurationData */
        $configurationData = $this->queryBus->handle(new ConfigurationDataFinderQuery());
        $preCommit = $configurationData->getPreCommit();

        if (true === $preCommit->isPreCommit()) {
            $this->executeTools($preCommit, $committedFiles);
        }

        $this->output->writeln(GoodJobLogoResponse::paint($preCommit->getRightMessage()));
    }

    /**
     * @param PreCommitResponse $preCommitResponse
     * @param array             $committedFiles
     */
    private function executeTools(PreCommitResponse $preCommitResponse, array $committedFiles)
    {
        if (true === $preCommitResponse->isComposer()) {
            $this->commandBus->handle(
                new ComposerToolCommand($committedFiles, $preCommitResponse->getErrorMessage())
            );
        }

        if (true === $preCommitResponse->isJsonLint()) {
            $this->commandBus->handle(
                new JsonLintToolCommand($committedFiles, $preCommitResponse->getErrorMessage())
            );
        }

        $phpFiles = $this->getPhpFiles($committedFiles);

        if ($phpFiles) {

            if (true === $preCommitResponse->isPhpLint()) {
                $this->commandBus->handle(
                    new PhpLintToolCommand($phpFiles, $preCommitResponse->getErrorMessage())
                );
            }

            $phpCsResponse = $preCommitResponse->getPhpCs();

            if (true === $phpCsResponse->isPhpCs()) {
                $this->commandBus->handle(
                    new PhpCsToolCommand(
                        $phpFiles,
                        $phpCsResponse->getPhpCsStandard(),
                        $preCommitResponse->getErrorMessage()
                    )
                );
            }

            $phpCsFixerResponse = $preCommitResponse->getPhpCsFixer();

            if (true === $phpCsFixerResponse->isPhpCsFixer()) {
                $this->commandBus->handle(
                    new PhpCsFixerToolCommand(
                        $phpFiles,
                        $phpCsFixerResponse->isPhpCsFixerPsr0(),
                        $phpCsFixerResponse->isPhpCsFixerPsr1(),
                        $phpCsFixerResponse->isPhpCsFixerPsr2(),
                        $phpCsFixerResponse->isPhpCsFixerSymfony(),
                        $preCommitResponse->getErrorMessage()
                    )
                );
            }

            $phpMdResponse = $preCommitResponse->getPhpMd();

            if (true === $phpMdResponse->isPhpMd()) {
                $this->commandBus->handle(
                    new PhpMdToolCommand(
                        $phpFiles,
                        $phpMdResponse->getPhpMdOptions(),
                        $preCommitResponse->getErrorMessage()
                    )
                );
            }

            $phpunitResponse = $preCommitResponse->getPhpUnit();

            if (true === $phpunitResponse->isPhpunit()) {

                $this->commandBus->handle(
                    new PhpUnitToolCommand(
                        $phpunitResponse->isPhpunitRandomMode(),
                        $phpunitResponse->getPhpunitOptions(),
                        $preCommitResponse->getErrorMessage()
                    )
                );

                $phpunitStrictCoverageResponse = $preCommitResponse->getPhpUnitStrictCoverage();

                if (true === $phpunitStrictCoverageResponse->isPhpunitStrictCoverage()) {
                    $this->commandBus->handle(
                        new StrictCoverageCommand(
                            $phpunitStrictCoverageResponse->getMinimum(),
                            $preCommitResponse->getErrorMessage()
                        )
                    );
                }

                $phpunitGuardCoverageResponse = $preCommitResponse->getPhpUnitGuardCoverage();

                if (true === $phpunitGuardCoverageResponse->isEnabled()) {
                    $this->commandBus->handle(
                        new GuardCoverageCommand(
                            $phpunitGuardCoverageResponse->getWarningMessage()
                        )
                    );
                }
            }
        }
    }

    /**
     * @param array $committedFiles
     *
     * @return array
     */
    private function getPhpFiles(array $committedFiles)
    {
        /** @var PhpFilesResponse $phpFilesResponse */
        $phpFilesResponse = $this->queryBus->handle(new PhpFilesExtractorQuery($committedFiles));

        return $phpFilesResponse->getFiles();
    }
}


1			<?php
2
3			namespace PhpGitHooks\Module\Git\Service;
4
5			use PhpGitHooks\Infrastructure\CommandBus\CommandBus\CommandBus;
6			use PhpGitHooks\Infrastructure\CommandBus\QueryBus\QueryBus;
7			use PhpGitHooks\Module\Composer\Contract\Command\ComposerToolCommand;
8			use PhpGitHooks\Module\Configuration\Contract\Query\ConfigurationDataFinderQuery;
9			use PhpGitHooks\Module\Configuration\Contract\Response\ConfigurationDataResponse;
10			use PhpGitHooks\Module\Configuration\Contract\Response\PreCommitResponse;
11			use PhpGitHooks\Module\Files\Contract\Query\PhpFilesExtractorQuery;
12			use PhpGitHooks\Module\Files\Contract\Response\PhpFilesResponse;
13			use PhpGitHooks\Module\Git\Contract\Response\GoodJobLogoResponse;
14			use PhpGitHooks\Module\Git\Infrastructure\Files\FilesCommittedExtractor;
15			use PhpGitHooks\Module\Git\Infrastructure\OutputWriter\ToolTittleOutputWriter;
16			use PhpGitHooks\Module\JsonLint\Contract\Command\JsonLintToolCommand;
17			use PhpGitHooks\Module\PhpCs\Contract\Command\PhpCsToolCommand;
18			use PhpGitHooks\Module\PhpCsFixer\Contract\Command\PhpCsFixerToolCommand;
19			use PhpGitHooks\Module\PhpLint\Contract\Command\PhpLintToolCommand;
20			use PhpGitHooks\Module\PhpMd\Contract\Command\PhpMdToolCommand;
21			use PhpGitHooks\Module\PhpUnit\Contract\Command\GuardCoverageCommand;
22			use PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitToolCommand;
23			use PhpGitHooks\Module\PhpUnit\Contract\Command\StrictCoverageCommand;
24			use Symfony\Component\Console\Output\OutputInterface;
25
26			class PreCommitTool
27			{
28			const NO_FILES_CHANGED_MESSAGE = '<comment>-\_(ö)_/- No files changed.</comment>';
29			const TITLE = 'Pre-Commit tool';
30			/**
31			* @var OutputInterface
32			*/
33			private $output;
34			/**
35			* @var FilesCommittedExtractor
36			*/
37			private $filesCommittedExtractor;
38			/**
39			* @var CommandBus
40			*/
41			private $commandBus;
42			/**
43			* @var QueryBus
44			*/
45			private $queryBus;
46			/**
47			* @var ToolTittleOutputWriter
48			*/
49			private $tittleOutputWriter;
50
51			/**
52			* PreCommitTool constructor.
53			*
54			*
55			* @param OutputInterface $output
56			* @param FilesCommittedExtractor $filesCommittedExtractor
57			* @param QueryBus $queryBus
58			* @param CommandBus $commandBus
59			* @param ToolTittleOutputWriter $tittleOutputWriter
60			*/
61	2		public function __construct(
62			OutputInterface $output,
63			FilesCommittedExtractor $filesCommittedExtractor,
64			QueryBus $queryBus,
65			CommandBus $commandBus,
66			ToolTittleOutputWriter $tittleOutputWriter
67			) {
68	2		$this->filesCommittedExtractor = $filesCommittedExtractor;
69	2		$this->output = $output;
70	2		$this->commandBus = $commandBus;
71	2		$this->queryBus = $queryBus;
72	2		$this->tittleOutputWriter = $tittleOutputWriter;
73	2		}
74
75	2		public function execute()
76			{
77	2		$this->tittleOutputWriter->writeTitle(self::TITLE);
78	2		$committedFiles = $this->filesCommittedExtractor->getFiles();
79
80	2		if (1 === count($committedFiles)) {
81	1		$this->output->writeln(static::NO_FILES_CHANGED_MESSAGE);
82
83	1		return;
84			}
85
86			/** @var ConfigurationDataResponse $configurationData */
87	1		$configurationData = $this->queryBus->handle(new ConfigurationDataFinderQuery());
88	1		$preCommit = $configurationData->getPreCommit();
89
90	1		if (true === $preCommit->isPreCommit()) {
91	1		$this->executeTools($preCommit, $committedFiles);
92	1		}
93
94	1		$this->output->writeln(GoodJobLogoResponse::paint($preCommit->getRightMessage()));
95	1		}
96
97			/**
98			* @param PreCommitResponse $preCommitResponse
99			* @param array $committedFiles
100			*/
101	1		private function executeTools(PreCommitResponse $preCommitResponse, array $committedFiles)
102			{
103	1		if (true === $preCommitResponse->isComposer()) {
104	1		$this->commandBus->handle(
105	1		new ComposerToolCommand($committedFiles, $preCommitResponse->getErrorMessage())
106	1		);
107	1		}
108
109	1		if (true === $preCommitResponse->isJsonLint()) {
110	1		$this->commandBus->handle(
111	1		new JsonLintToolCommand($committedFiles, $preCommitResponse->getErrorMessage())
112	1		);
113	1		}
114
115	1		$phpFiles = $this->getPhpFiles($committedFiles);
116
117	1		if ($phpFiles) {
			0 ignored issues – show Bug Best Practice introduced 2016-07-03 15:56 UTC by Report Bug Copy Issue Report The expression `$phpFiles` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
118	1		if (true === $preCommitResponse->isPhpLint()) {
119	1		$this->commandBus->handle(
120	1		new PhpLintToolCommand($phpFiles, $preCommitResponse->getErrorMessage())
121	1		);
122	1		}
123
124	1		$phpCsResponse = $preCommitResponse->getPhpCs();
125
126	1		if (true === $phpCsResponse->isPhpCs()) {
127	1		$this->commandBus->handle(
128	1		new PhpCsToolCommand(
129	1		$phpFiles,
130	1		$phpCsResponse->getPhpCsStandard(),
131	1		$preCommitResponse->getErrorMessage()
132	1		)
133	1		);
134	1		}
135
136	1		$phpCsFixerResponse = $preCommitResponse->getPhpCsFixer();
137
138	1		if (true === $phpCsFixerResponse->isPhpCsFixer()) {
139	1		$this->commandBus->handle(
140	1		new PhpCsFixerToolCommand(
141	1		$phpFiles,
142	1		$phpCsFixerResponse->isPhpCsFixerPsr0(),
143	1		$phpCsFixerResponse->isPhpCsFixerPsr1(),
144	1		$phpCsFixerResponse->isPhpCsFixerPsr2(),
145	1		$phpCsFixerResponse->isPhpCsFixerSymfony(),
146	1		$preCommitResponse->getErrorMessage()
147	1		)
148	1		);
149	1		}
150
151	1		$phpMdResponse = $preCommitResponse->getPhpMd();
152
153	1		if (true === $phpMdResponse->isPhpMd()) {
154	1		$this->commandBus->handle(
155	1		new PhpMdToolCommand(
156	1		$phpFiles,
157	1		$phpMdResponse->getPhpMdOptions(),
158	1		$preCommitResponse->getErrorMessage()
159	1		)
160	1		);
161	1		}
162
163	1		$phpunitResponse = $preCommitResponse->getPhpUnit();
164
165	1	View Code Duplication	if (true === $phpunitResponse->isPhpunit()) {
			0 ignored issues – show Duplication introduced 2016-06-24 18:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
166	1		$this->commandBus->handle(
167	1		new PhpUnitToolCommand(
168	1		$phpunitResponse->isPhpunitRandomMode(),
169	1		$phpunitResponse->getPhpunitOptions(),
170	1		$preCommitResponse->getErrorMessage()
171	1		)
172	1		);
173
174	1		$phpunitStrictCoverageResponse = $preCommitResponse->getPhpUnitStrictCoverage();
175
176	1		if (true === $phpunitStrictCoverageResponse->isPhpunitStrictCoverage()) {
177	1		$this->commandBus->handle(
178	1		new StrictCoverageCommand(
179	1		$phpunitStrictCoverageResponse->getMinimum(),
180	1		$preCommitResponse->getErrorMessage()
181	1		)
182	1		);
183	1		}
184
185	1		$phpunitGuardCoverageResponse = $preCommitResponse->getPhpUnitGuardCoverage();
186
187	1		if (true === $phpunitGuardCoverageResponse->isEnabled()) {
188	1		$this->commandBus->handle(
189	1		new GuardCoverageCommand(
190	1		$phpunitGuardCoverageResponse->getWarningMessage()
191	1		)
192	1		);
193	1		}
194	1		}
195	1		}
196	1		}
197
198			/**
199			* @param array $committedFiles
200			*
201			* @return array
202			*/
203	1		private function getPhpFiles(array $committedFiles)
204			{
205			/** @var PhpFilesResponse $phpFilesResponse */
206	1		$phpFilesResponse = $this->queryBus->handle(new PhpFilesExtractorQuery($committedFiles));
207
208	1		return $phpFilesResponse->getFiles();
209			}
210			}
211

bruli / php-git-hooks

Push — master ( 77f843...549cd1 )

PreCommitTool::isPhpFiles() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like