PhpGitHooks\Infrastructure\PhpMD\PhpMDHandler

Complexity

Total Complexity

9

Size/Duplication

Total Lines	91
Duplicated Lines	20.88 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	9
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	run()	19	46	6
A	setNeedle()	0	4	1
A	setFiles()	0	4	1

<?php

namespace PhpGitHooks\Infrastructure\PhpMD;

use IgnoreFiles\IgnoreFiles;
use PhpGitHooks\Application\Message\MessageConfigData;
use PhpGitHooks\Command\OutputHandlerInterface;
use PhpGitHooks\Infrastructure\Common\RecursiveToolInterface;
use PhpGitHooks\Infrastructure\Common\ToolHandler;
use Symfony\Component\Process\ProcessBuilder;

/**
 * Class PhpMDHandler.
 */
class PhpMDHandler extends ToolHandler implements RecursiveToolInterface
{
    /** @var  array */
    private $files;
    /** @var  string */
    private $needle;
    /**
     * @var IgnoreFiles
     */
    private $ignoreFiles;

    /**
     * PhpMDHandler constructor.
     *
     * @param OutputHandlerInterface $outputHandler
     * @param IgnoreFiles            $ignoreFiles
     */
    public function __construct(OutputHandlerInterface $outputHandler, IgnoreFiles $ignoreFiles)
    {
        parent::__construct($outputHandler);
        $this->ignoreFiles = $ignoreFiles;
    }

    /**
     * @param array $messages
     *
     * @throws PHPMDViolationsException
     */
    public function run(array $messages)
    {
        $this->outputHandler->setTitle('Checking code mess with PHPMD');
        $this->output->write($this->outputHandler->getTitle());

        $errors = [];

        foreach ($this->files as $file) {
            if (!preg_match($this->needle, $file)) {
                continue;
            }

            if (false === $this->ignoreFiles->isIgnored($file)) {

This code seems to be duplicated across your project.

                $processBuilder = new ProcessBuilder(
                    array(
                        'php',
                        'bin/phpmd',
                        $file,
                        'text',
                        'PmdRules.xml',
                        '--minimumpriority',
                        1,
                    )
                );
                $process = $processBuilder->getProcess();
                $process->run();

                if (false === $process->isSuccessful()) {
                    $errors[] = $process->getOutput();
                }
            }
        }

        $errors = array_filter($errors, function ($var) {
            return !is_null($var);
        });

        if ($errors) {

The expression $errors of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->writeOutputError(
                new PHPMDViolationsException(implode('', $errors)),
                MessageConfigData::KEY_ERROR_MESSAGE
            );
        }

        $this->output->writeln($this->outputHandler->getSuccessfulStepMessage());
    }

    /**
     * @param string $needle
     */
    public function setNeedle($needle)
    {
        $this->needle = $needle;
    }

    /**
     * @param array $files
     */
    public function setFiles($files)
    {
        $this->files = $files;
    }
}