These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace PhpGitHooks\Module\Git\Contract\Command; |
||
4 | |||
5 | use Bruli\EventBusBundle\CommandBus\CommandHandlerInterface; |
||
6 | use Bruli\EventBusBundle\CommandBus\CommandInterface; |
||
7 | use PhpGitHooks\Module\Git\Model\WriterInterface; |
||
8 | |||
9 | class GitIgnoreWriterHandler implements CommandHandlerInterface |
||
10 | { |
||
11 | /** |
||
12 | * @var WriterInterface |
||
13 | */ |
||
14 | private $gitIgnoreWriter; |
||
15 | |||
16 | /** |
||
17 | * GitIgnoreWriter constructor. |
||
18 | * |
||
19 | * @param WriterInterface $gitIgnoreWriter |
||
20 | */ |
||
21 | 1 | public function __construct(WriterInterface $gitIgnoreWriter) |
|
22 | { |
||
23 | 1 | $this->gitIgnoreWriter = $gitIgnoreWriter; |
|
24 | 1 | } |
|
25 | |||
26 | /** |
||
27 | * @param string $content |
||
28 | */ |
||
29 | 1 | private function write($content) |
|
30 | { |
||
31 | 1 | $this->gitIgnoreWriter->write($content); |
|
32 | 1 | } |
|
33 | |||
34 | /** |
||
35 | * @param CommandInterface|GitIgnoreWriter $command |
||
36 | */ |
||
37 | 1 | public function handle(CommandInterface $command) |
|
38 | { |
||
39 | 1 | $this->write($command->getContent()); |
|
0 ignored issues
–
show
|
|||
40 | 1 | } |
|
41 | } |
||
42 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: