PreCommitToolHandlerTest::itShouldExecuteAllTools() - Code Metrics - Inspection of "Remove pre push tool service and rename command an..." - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( efc44e...835840 )

by Pablo

created 2017-06-17 19:36 UTC

itShouldExecuteAllTools() A

↳ Parent: PreCommitToolHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	74
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	74
rs	9.0335
cc	1
eloc	50
nc	1
nop	0

How to fix Long Method

<?php

namespace PhpGitHooks\Module\Git\Tests\Behaviour;

use PhpGitHooks\Module\Composer\Contract\Command\ComposerTool;
use PhpGitHooks\Module\Configuration\Contract\Query\ConfigurationDataFinder;
use PhpGitHooks\Module\Configuration\Service\HookQuestions;
use PhpGitHooks\Module\Configuration\Tests\Stub\ConfigurationDataResponseStub;
use PhpGitHooks\Module\Files\Contract\Query\PhpFilesExtractor;
use PhpGitHooks\Module\Files\Tests\Stub\PhpFilesResponseStub;
use PhpGitHooks\Module\Git\Contract\Command\PreCommitTool;
use PhpGitHooks\Module\Git\Contract\Command\PreCommitToolHandler;
use PhpGitHooks\Module\Git\Contract\Response\GoodJobLogoResponse;
use PhpGitHooks\Module\Git\Tests\Infrastructure\GitUnitTestCase;
use PhpGitHooks\Module\Git\Tests\Stub\FilesCommittedStub;
use PhpGitHooks\Module\JsonLint\Contract\Command\JsonLintToolCommand;
use PhpGitHooks\Module\PhpCs\Contract\Command\PhpCsToolCommand;
use PhpGitHooks\Module\PhpCsFixer\Contract\Command\PhpCsFixerToolCommand;
use PhpGitHooks\Module\PhpLint\Contract\Command\PhpLintToolCommand;
use PhpGitHooks\Module\PhpMd\Contract\Command\PhpMdToolCommand;
use PhpGitHooks\Module\PhpUnit\Contract\Command\GuardCoverageCommand;
use PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitToolCommand;
use PhpGitHooks\Module\PhpUnit\Contract\Command\StrictCoverageCommand;
use PhpGitHooks\Module\Tests\Infrastructure\Stub\StubCreator;

class PreCommitToolHandlerTest extends GitUnitTestCase
{
    /**
     * @var PreCommitToolHandler
     */
    private $preCommitToolCommandHandler;

    protected function setUp()
    {
        $this->preCommitToolCommandHandler = new PreCommitToolHandler(
            $this->getOutputInterface(),
            $this->getFilesCommittedExtractor(),

            $this->getQueryBus(),

            $this->getCommandBus(),

            $this->getToolTitleOutputWriter()

        );
    }

    /**
     * @test
     */
    public function itShouldNotExecuteTools()
    {
        $this->shouldWriteTitle(PreCommitToolHandler::TITLE, 'title');
        $this->shouldGetFilesCommitted([StubCreator::faker()->sha1]);
        $this->shouldWriteLnOutput(PreCommitToolHandler::NO_FILES_CHANGED_MESSAGE);

        $this->preCommitToolCommandHandler->handle(new PreCommitTool());
    }

    /**
     * @test
     */
    public function itShouldExecuteAllTools()
    {
        $files = FilesCommittedStub::createAllFiles();
        $configurationDataResponse = ConfigurationDataResponseStub::createAllEnabled();

        $this->shouldWriteTitle(PreCommitToolHandler::TITLE, 'title');
        $this->shouldGetFilesCommitted($files);
        $this->shouldHandleQuery(new ConfigurationDataFinder(), $configurationDataResponse);
        $this->shouldHandleCommand(
            new ComposerTool($files, $configurationDataResponse->getPreCommit()->getErrorMessage())
        );
        $this->shouldHandleCommand(
            new JsonLintToolCommand($files, $configurationDataResponse->getPreCommit()->getErrorMessage())
        );
        $this->shouldHandleQuery(
            new PhpFilesExtractor($files),
            PhpFilesResponseStub::create(FilesCommittedStub::createWithoutPhpFiles())
        );
        $this->shouldHandleCommand(
            new PhpLintToolCommand($files, $configurationDataResponse->getPreCommit()->getErrorMessage())
        );
        $this->shouldHandleCommand(
            new PhpCsToolCommand(
                $files,
                $configurationDataResponse->getPreCommit()->getPhpCs()->getPhpCsStandard(),
                HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT,
                $configurationDataResponse->getPreCommit()->getPhpCs()->getIgnore()
            )
        );
        $this->shouldHandleCommand(
            new PhpCsFixerToolCommand(
                $files,
                $configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerPsr0(),
                $configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerPsr1(),
                $configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerPsr2(),
                $configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerSymfony(),
                $configurationDataResponse->getPreCommit()->getPhpCsFixer()->getPhpCsFixerOptions(),
                $configurationDataResponse->getPreCommit()->getErrorMessage()
            )
        );
        $this->shouldHandleCommand(
            new PhpMdToolCommand(
                $files,
                $configurationDataResponse->getPreCommit()->getPhpMd()->getPhpMdOptions(),
                $configurationDataResponse->getPreCommit()->getErrorMessage()
            )
        );
        $this->shouldHandleCommand(
            new PhpUnitToolCommand(
                $configurationDataResponse->getPreCommit()->getPhpUnit()->isPhpunitRandomMode(),
                $configurationDataResponse->getPreCommit()->getPhpUnit()->getPhpunitOptions(),
                $configurationDataResponse->getPreCommit()->getErrorMessage()
            )
        );

        $this->shouldHandleCommand(
            new StrictCoverageCommand(
                $configurationDataResponse->getPreCommit()->getPhpUnitStrictCoverage()->getMinimum(),
                $configurationDataResponse->getPreCommit()->getErrorMessage()
            )
        );

        $this->shouldHandleCommand(
            new GuardCoverageCommand(
                $configurationDataResponse->getPreCommit()->getPhpUnitGuardCoverage()->getWarningMessage()
            )
        );

        $this->shouldWriteLnOutput(
            GoodJobLogoResponse::paint($configurationDataResponse->getPreCommit()->getRightMessage())
        );

        $this->preCommitToolCommandHandler->handle(new PreCommitTool());
    }
}


1			<?php
2
3			namespace PhpGitHooks\Module\Git\Tests\Behaviour;
4
5			use PhpGitHooks\Module\Composer\Contract\Command\ComposerTool;
6			use PhpGitHooks\Module\Configuration\Contract\Query\ConfigurationDataFinder;
7			use PhpGitHooks\Module\Configuration\Service\HookQuestions;
8			use PhpGitHooks\Module\Configuration\Tests\Stub\ConfigurationDataResponseStub;
9			use PhpGitHooks\Module\Files\Contract\Query\PhpFilesExtractor;
10			use PhpGitHooks\Module\Files\Tests\Stub\PhpFilesResponseStub;
11			use PhpGitHooks\Module\Git\Contract\Command\PreCommitTool;
12			use PhpGitHooks\Module\Git\Contract\Command\PreCommitToolHandler;
13			use PhpGitHooks\Module\Git\Contract\Response\GoodJobLogoResponse;
14			use PhpGitHooks\Module\Git\Tests\Infrastructure\GitUnitTestCase;
15			use PhpGitHooks\Module\Git\Tests\Stub\FilesCommittedStub;
16			use PhpGitHooks\Module\JsonLint\Contract\Command\JsonLintToolCommand;
17			use PhpGitHooks\Module\PhpCs\Contract\Command\PhpCsToolCommand;
18			use PhpGitHooks\Module\PhpCsFixer\Contract\Command\PhpCsFixerToolCommand;
19			use PhpGitHooks\Module\PhpLint\Contract\Command\PhpLintToolCommand;
20			use PhpGitHooks\Module\PhpMd\Contract\Command\PhpMdToolCommand;
21			use PhpGitHooks\Module\PhpUnit\Contract\Command\GuardCoverageCommand;
22			use PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitToolCommand;
23			use PhpGitHooks\Module\PhpUnit\Contract\Command\StrictCoverageCommand;
24			use PhpGitHooks\Module\Tests\Infrastructure\Stub\StubCreator;
25
26			class PreCommitToolHandlerTest extends GitUnitTestCase
27			{
28			/**
29			* @var PreCommitToolHandler
30			*/
31			private $preCommitToolCommandHandler;
32
33			protected function setUp()
34			{
35			$this->preCommitToolCommandHandler = new PreCommitToolHandler(
36			$this->getOutputInterface(),
37			$this->getFilesCommittedExtractor(),
			0 ignored issues – show Bug introduced 2017-06-17 19:39 UTC by Report Bug Copy Issue Report It seems like `$this->getFilesCommittedExtractor()` targeting `PhpGitHooks\Module\Git\T...lesCommittedExtractor()` can also be of type `object<Mockery\MockInterface>`; however, `PhpGitHooks\Module\Git\C...lHandler::__construct()` does only seem to accept `object<PhpGitHooks\Modul...ilesCommittedExtractor>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
38			$this->getQueryBus(),
			0 ignored issues – show Bug introduced 2017-06-17 19:39 UTC by Report Bug Copy Issue Report It seems like `$this->getQueryBus()` targeting `PhpGitHooks\Module\Share...BusTrait::getQueryBus()` can also be of type `object<Mockery\MockInterface>`; however, `PhpGitHooks\Module\Git\C...lHandler::__construct()` does only seem to accept `object<Bruli\EventBusBundle\QueryBus\QueryBus>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
39			$this->getCommandBus(),
			0 ignored issues – show Bug introduced 2017-06-17 19:39 UTC by Report Bug Copy Issue Report It seems like `$this->getCommandBus()` targeting `PhpGitHooks\Module\Share...sTrait::getCommandBus()` can also be of type `object<Mockery\MockInterface>`; however, `PhpGitHooks\Module\Git\C...lHandler::__construct()` does only seem to accept `object<Bruli\EventBusBun...\CommandBus\CommandBus>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
40			$this->getToolTitleOutputWriter()
			0 ignored issues – show Bug introduced 2017-06-17 19:39 UTC by Report Bug Copy Issue Report It seems like `$this->getToolTitleOutputWriter()` targeting `PhpGitHooks\Module\Git\T...ToolTitleOutputWriter()` can also be of type `object<Mockery\MockInterface>`; however, `PhpGitHooks\Module\Git\C...lHandler::__construct()` does only seem to accept `object<PhpGitHooks\Modul...ToolTittleOutputWriter>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
41			);
42			}
43
44			/**
45			* @test
46			*/
47			public function itShouldNotExecuteTools()
48			{
49			$this->shouldWriteTitle(PreCommitToolHandler::TITLE, 'title');
50			$this->shouldGetFilesCommitted([StubCreator::faker()->sha1]);
51			$this->shouldWriteLnOutput(PreCommitToolHandler::NO_FILES_CHANGED_MESSAGE);
52
53			$this->preCommitToolCommandHandler->handle(new PreCommitTool());
54			}
55
56			/**
57			* @test
58			*/
59			public function itShouldExecuteAllTools()
60			{
61			$files = FilesCommittedStub::createAllFiles();
62			$configurationDataResponse = ConfigurationDataResponseStub::createAllEnabled();
63
64			$this->shouldWriteTitle(PreCommitToolHandler::TITLE, 'title');
65			$this->shouldGetFilesCommitted($files);
66			$this->shouldHandleQuery(new ConfigurationDataFinder(), $configurationDataResponse);
67			$this->shouldHandleCommand(
68			new ComposerTool($files, $configurationDataResponse->getPreCommit()->getErrorMessage())
69			);
70			$this->shouldHandleCommand(
71			new JsonLintToolCommand($files, $configurationDataResponse->getPreCommit()->getErrorMessage())
72			);
73			$this->shouldHandleQuery(
74			new PhpFilesExtractor($files),
75			PhpFilesResponseStub::create(FilesCommittedStub::createWithoutPhpFiles())
76			);
77			$this->shouldHandleCommand(
78			new PhpLintToolCommand($files, $configurationDataResponse->getPreCommit()->getErrorMessage())
79			);
80			$this->shouldHandleCommand(
81			new PhpCsToolCommand(
82			$files,
83			$configurationDataResponse->getPreCommit()->getPhpCs()->getPhpCsStandard(),
84			HookQuestions::PRE_COMMIT_ERROR_MESSAGE_DEFAULT,
85			$configurationDataResponse->getPreCommit()->getPhpCs()->getIgnore()
86			)
87			);
88			$this->shouldHandleCommand(
89			new PhpCsFixerToolCommand(
90			$files,
91			$configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerPsr0(),
92			$configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerPsr1(),
93			$configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerPsr2(),
94			$configurationDataResponse->getPreCommit()->getPhpCsFixer()->isPhpCsFixerSymfony(),
95			$configurationDataResponse->getPreCommit()->getPhpCsFixer()->getPhpCsFixerOptions(),
96			$configurationDataResponse->getPreCommit()->getErrorMessage()
97			)
98			);
99			$this->shouldHandleCommand(
100			new PhpMdToolCommand(
101			$files,
102			$configurationDataResponse->getPreCommit()->getPhpMd()->getPhpMdOptions(),
103			$configurationDataResponse->getPreCommit()->getErrorMessage()
104			)
105			);
106			$this->shouldHandleCommand(
107			new PhpUnitToolCommand(
108			$configurationDataResponse->getPreCommit()->getPhpUnit()->isPhpunitRandomMode(),
109			$configurationDataResponse->getPreCommit()->getPhpUnit()->getPhpunitOptions(),
110			$configurationDataResponse->getPreCommit()->getErrorMessage()
111			)
112			);
113
114			$this->shouldHandleCommand(
115			new StrictCoverageCommand(
116			$configurationDataResponse->getPreCommit()->getPhpUnitStrictCoverage()->getMinimum(),
117			$configurationDataResponse->getPreCommit()->getErrorMessage()
118			)
119			);
120
121			$this->shouldHandleCommand(
122			new GuardCoverageCommand(
123			$configurationDataResponse->getPreCommit()->getPhpUnitGuardCoverage()->getWarningMessage()
124			)
125			);
126
127			$this->shouldWriteLnOutput(
128			GoodJobLogoResponse::paint($configurationDataResponse->getPreCommit()->getRightMessage())
129			);
130
131			$this->preCommitToolCommandHandler->handle(new PreCommitTool());
132			}
133			}
134

bruli / php-git-hooks

Push — master ( efc44e...835840 )

itShouldExecuteAllTools() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like