These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace PhpGitHooks\Module\PhpUnit\Contract\CommandHandler; |
||
4 | |||
5 | use PhpGitHooks\Infrastructure\CommandBus\CommandBus\CommandHandlerInterface; |
||
6 | use PhpGitHooks\Infrastructure\CommandBus\CommandBus\CommandInterface; |
||
7 | use PhpGitHooks\Module\Configuration\Domain\MinimumStrictCoverage; |
||
8 | use PhpGitHooks\Module\PhpUnit\Contract\Command\StrictCoverageCommand; |
||
9 | use PhpGitHooks\Module\PhpUnit\Service\StrictCoverageToolExecutor; |
||
10 | |||
11 | class StrictCoverageToolCommandHandler implements CommandHandlerInterface |
||
12 | { |
||
13 | /** |
||
14 | * @var StrictCoverageToolExecutor |
||
15 | */ |
||
16 | private $strictCoverageToolExecutor; |
||
17 | |||
18 | /** |
||
19 | * StrictCoverageToolCommandHandler constructor. |
||
20 | * |
||
21 | * @param StrictCoverageToolExecutor $strictCoverageToolExecutor |
||
22 | */ |
||
23 | 2 | public function __construct(StrictCoverageToolExecutor $strictCoverageToolExecutor) |
|
24 | { |
||
25 | 2 | $this->strictCoverageToolExecutor = $strictCoverageToolExecutor; |
|
26 | 2 | } |
|
27 | |||
28 | /** |
||
29 | * @param CommandInterface|StrictCoverageCommand $command |
||
30 | */ |
||
31 | 2 | public function handle(CommandInterface $command) |
|
32 | { |
||
33 | 2 | $this->strictCoverageToolExecutor->execute( |
|
34 | 2 | new MinimumStrictCoverage($command->getMinimumCoverage()), |
|
0 ignored issues
–
show
|
|||
35 | 2 | $command->getErrorMessage() |
|
0 ignored issues
–
show
It seems like you code against a concrete implementation and not the interface
PhpGitHooks\Infrastructu...andBus\CommandInterface as the method getErrorMessage() does only exist in the following implementations of said interface: PhpGitHooks\Module\Compo...and\ComposerToolCommand , PhpGitHooks\Module\JsonL...and\JsonLintToolCommand , PhpGitHooks\Module\PhpCs...d\PhpCsFixerToolCommand , PhpGitHooks\Module\PhpCs...ommand\PhpCsToolCommand , PhpGitHooks\Module\PhpLi...mand\PhpLintToolCommand , PhpGitHooks\Module\PhpMd...ommand\PhpMdToolCommand , PhpGitHooks\Module\PhpUn...mand\PhpUnitToolCommand , PhpGitHooks\Module\PhpUn...d\StrictCoverageCommand .
Let’s take a look at an example: interface User
{
/** @return string */
public function getPassword();
}
class MyUser implements User
{
public function getPassword()
{
// return something
}
public function getDisplayName()
{
// return some name.
}
}
class AuthSystem
{
public function authenticate(User $user)
{
$this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
// do something.
}
}
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types
inside the if block in such a case.
Loading history...
|
|||
36 | ); |
||
37 | 1 | } |
|
38 | } |
||
39 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: