These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | namespace PhpGitHooks\Module\Files\Contract\QueryHandler; |
||
4 | |||
5 | use PhpGitHooks\Infrastructure\CommandBus\QueryBus\QueryHandlerInterface; |
||
6 | use PhpGitHooks\Infrastructure\CommandBus\QueryBus\QueryInterface; |
||
7 | use PhpGitHooks\Module\Files\Contract\Query\JsonFilesExtractorQuery; |
||
8 | use PhpGitHooks\Module\Files\Contract\Response\JsonFilesResponse; |
||
9 | use PhpGitHooks\Module\Files\Domain\FilesCollection; |
||
10 | use PhpGitHooks\Module\Files\Service\JsonFilesExtractor; |
||
11 | |||
12 | View Code Duplication | class JsonFilesExtractorQueryHandler extends AbstractFilesExtractorQueryHandler implements QueryHandlerInterface |
|
13 | { |
||
14 | /** |
||
15 | * @var JsonFilesExtractor |
||
16 | */ |
||
17 | private $jsonFilesExtractor; |
||
18 | |||
19 | /** |
||
20 | * JsonFilesExtractorQueryHandler constructor. |
||
21 | * |
||
22 | * @param JsonFilesExtractor $jsonFilesExtractor |
||
23 | */ |
||
24 | 1 | public function __construct(JsonFilesExtractor $jsonFilesExtractor) |
|
25 | { |
||
26 | 1 | $this->jsonFilesExtractor = $jsonFilesExtractor; |
|
27 | 1 | } |
|
28 | |||
29 | /** |
||
30 | * @param QueryInterface|JsonFilesExtractorQuery $query |
||
31 | * |
||
32 | * @return JsonFilesResponse |
||
33 | */ |
||
34 | 1 | public function handle(QueryInterface $query) |
|
35 | { |
||
36 | 1 | $files = $query->getFiles(); |
|
0 ignored issues
–
show
|
|||
37 | |||
38 | 1 | return $this->jsonFilesExtractor->extract(new FilesCollection($this->getFiles($files))); |
|
39 | } |
||
40 | } |
||
41 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: