ConfigurationDataResponseFactory::build() - Code Metrics - Inspection of "Implement support for PHP CS ignore option" - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#85)

unknown

created 2016-12-20 20:00 UTC

ConfigurationDataResponseFactory::build() A

↳ Parent: ConfigurationDataResponseFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	75
Code Lines	60

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	75
ccs	0
cts	72
cp	0
rs	9
c	0
b	0
f	0
cc	1
eloc	60
nc	1
nop	15
crap	2

How to fix Long Method Many Parameters

<?php

namespace PhpGitHooks\Module\Configuration\Service;

use PhpGitHooks\Module\Configuration\Contract\Response\CommitMsgResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\ConfigurationDataResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PhpCsFixerResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PhpCsResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PhpUnitGuardCoverageResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PhpUnitResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PhpUnitStrictCoverageResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PhpMdResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PreCommitResponse;
use PhpGitHooks\Module\Configuration\Contract\Response\PrePushResponse;
use PhpGitHooks\Module\Configuration\Domain\CommitMsg;
use PhpGitHooks\Module\Configuration\Domain\Composer;
use PhpGitHooks\Module\Configuration\Domain\JsonLint;
use PhpGitHooks\Module\Configuration\Domain\PhpCs;
use PhpGitHooks\Module\Configuration\Domain\PhpCsFixer;
use PhpGitHooks\Module\Configuration\Domain\PhpLint;
use PhpGitHooks\Module\Configuration\Domain\PhpMd;
use PhpGitHooks\Module\Configuration\Domain\PhpUnit;
use PhpGitHooks\Module\Configuration\Domain\PhpUnitGuardCoverage;
use PhpGitHooks\Module\Configuration\Domain\PhpUnitStrictCoverage;
use PhpGitHooks\Module\Configuration\Domain\PreCommit;
use PhpGitHooks\Module\Configuration\Domain\PrePush;

class ConfigurationDataResponseFactory
{
    /**
     * @param PreCommit             $preCommit
     * @param Composer              $composer
     * @param JsonLint              $jsonLint
     * @param PhpLint               $phpLint
     * @param PhpMd                 $phpMd
     * @param PhpCs                 $phpCs
     * @param PhpCsFixer            $phpCsFixer
     * @param PhpUnit               $phpUnit
     * @param PhpUnitStrictCoverage $phpUnitStrictCoverage
     * @param PhpUnitGuardCoverage  $phpUnitGuardCoverage
     * @param CommitMsg             $commitMsg
     * @param PrePush               $prePush
     * @param PhpUnit               $prePushPhpUnit
     * @param PhpUnitStrictCoverage $prePushStrictCoverage
     * @param PhpUnitGuardCoverage  $prePushGuardCoverage
     *
     * @return ConfigurationDataResponse
     */
    public static function build(
        PreCommit $preCommit,
        Composer $composer,
        JsonLint $jsonLint,
        PhpLint $phpLint,
        PhpMd $phpMd,
        PhpCs $phpCs,
        PhpCsFixer $phpCsFixer,
        PhpUnit $phpUnit,
        PhpUnitStrictCoverage $phpUnitStrictCoverage,
        PhpUnitGuardCoverage $phpUnitGuardCoverage,
        CommitMsg $commitMsg,
        PrePush $prePush,
        PhpUnit $prePushPhpUnit,
        PhpUnitStrictCoverage $prePushStrictCoverage,
        PhpUnitGuardCoverage $prePushGuardCoverage
    ) {
        $commitMsgResponse = new CommitMsgResponse(
            $commitMsg->isEnabled(),
            $commitMsg->getRegularExpression()->value()
        );

        $prePushResponse = new PrePushResponse(
            $prePush->isEnabled(),
            $prePush->getMessages()->getRightMessage(),
            $prePush->getMessages()->getErrorMessage(),
            new PhpUnitResponse(
                $prePushPhpUnit->isEnabled(),
                $prePushPhpUnit->getRandomMode()->value(),
                $prePushPhpUnit->getOptions()->value()
            ),
            new PhpUnitStrictCoverageResponse(
                $prePushStrictCoverage->isEnabled(),
                $prePushStrictCoverage->getMinimumStrictCoverage()->value()
            ),
            new PhpUnitGuardCoverageResponse(
                $prePushGuardCoverage->isEnabled(),
                $prePushGuardCoverage->getWarningMessage()->value()
            )
        );

        $preCommitResponse = new PreCommitResponse(
            $preCommit->isEnabled(),
            $preCommit->getMessages()->getRightMessage()->value(),
            $preCommit->getMessages()->getErrorMessage()->value(),
            $composer->isEnabled(),
            $jsonLint->isEnabled(),
            $phpLint->isEnabled(),
            new PhpMdResponse($phpMd->isEnabled(), $phpMd->getOptions()->value()),
            new PhpCsResponse($phpCs->isEnabled(), $phpCs->getStandard()->value(), $phpCs->getIgnore()->value()),
            new PhpCsFixerResponse(
                $phpCsFixer->isEnabled(),
                $phpCsFixer->getLevels()->getPsr0()->value(),
                $phpCsFixer->getLevels()->getPsr1()->value(),
                $phpCsFixer->getLevels()->getPsr2()->value(),
                $phpCsFixer->getLevels()->getSymfony()->value(),
                $phpCsFixer->getOptions()->value()
            ),
            new PhpUnitResponse(
                $phpUnit->isEnabled(),
                $phpUnit->getRandomMode()->value(),
                $phpUnit->getOptions()->value()
            ),
            new PhpUnitStrictCoverageResponse(
                $phpUnitStrictCoverage->isEnabled(),
                $phpUnitStrictCoverage->getMinimumStrictCoverage()->value()
            ),
            new PhpUnitGuardCoverageResponse(
                $phpUnitGuardCoverage->isEnabled(),
                $phpUnitGuardCoverage->getWarningMessage()->value()
            )
        );

        return new ConfigurationDataResponse($preCommitResponse, $commitMsgResponse, $prePushResponse);
    }
}


1			<?php
2
3			namespace PhpGitHooks\Module\Configuration\Service;
4
5			use PhpGitHooks\Module\Configuration\Contract\Response\CommitMsgResponse;
6			use PhpGitHooks\Module\Configuration\Contract\Response\ConfigurationDataResponse;
7			use PhpGitHooks\Module\Configuration\Contract\Response\PhpCsFixerResponse;
8			use PhpGitHooks\Module\Configuration\Contract\Response\PhpCsResponse;
9			use PhpGitHooks\Module\Configuration\Contract\Response\PhpUnitGuardCoverageResponse;
10			use PhpGitHooks\Module\Configuration\Contract\Response\PhpUnitResponse;
11			use PhpGitHooks\Module\Configuration\Contract\Response\PhpUnitStrictCoverageResponse;
12			use PhpGitHooks\Module\Configuration\Contract\Response\PhpMdResponse;
13			use PhpGitHooks\Module\Configuration\Contract\Response\PreCommitResponse;
14			use PhpGitHooks\Module\Configuration\Contract\Response\PrePushResponse;
15			use PhpGitHooks\Module\Configuration\Domain\CommitMsg;
16			use PhpGitHooks\Module\Configuration\Domain\Composer;
17			use PhpGitHooks\Module\Configuration\Domain\JsonLint;
18			use PhpGitHooks\Module\Configuration\Domain\PhpCs;
19			use PhpGitHooks\Module\Configuration\Domain\PhpCsFixer;
20			use PhpGitHooks\Module\Configuration\Domain\PhpLint;
21			use PhpGitHooks\Module\Configuration\Domain\PhpMd;
22			use PhpGitHooks\Module\Configuration\Domain\PhpUnit;
23			use PhpGitHooks\Module\Configuration\Domain\PhpUnitGuardCoverage;
24			use PhpGitHooks\Module\Configuration\Domain\PhpUnitStrictCoverage;
25			use PhpGitHooks\Module\Configuration\Domain\PreCommit;
26			use PhpGitHooks\Module\Configuration\Domain\PrePush;
27
28			class ConfigurationDataResponseFactory
29			{
30			/**
31			* @param PreCommit $preCommit
32			* @param Composer $composer
33			* @param JsonLint $jsonLint
34			* @param PhpLint $phpLint
35			* @param PhpMd $phpMd
36			* @param PhpCs $phpCs
37			* @param PhpCsFixer $phpCsFixer
38			* @param PhpUnit $phpUnit
39			* @param PhpUnitStrictCoverage $phpUnitStrictCoverage
40			* @param PhpUnitGuardCoverage $phpUnitGuardCoverage
41			* @param CommitMsg $commitMsg
42			* @param PrePush $prePush
43			* @param PhpUnit $prePushPhpUnit
44			* @param PhpUnitStrictCoverage $prePushStrictCoverage
45			* @param PhpUnitGuardCoverage $prePushGuardCoverage
46			*
47			* @return ConfigurationDataResponse
48			*/
49			public static function build(
50			PreCommit $preCommit,
51			Composer $composer,
52			JsonLint $jsonLint,
53			PhpLint $phpLint,
54			PhpMd $phpMd,
55			PhpCs $phpCs,
56			PhpCsFixer $phpCsFixer,
57			PhpUnit $phpUnit,
58			PhpUnitStrictCoverage $phpUnitStrictCoverage,
59			PhpUnitGuardCoverage $phpUnitGuardCoverage,
60			CommitMsg $commitMsg,
61			PrePush $prePush,
62			PhpUnit $prePushPhpUnit,
63			PhpUnitStrictCoverage $prePushStrictCoverage,
64			PhpUnitGuardCoverage $prePushGuardCoverage
65			) {
66			$commitMsgResponse = new CommitMsgResponse(
67			$commitMsg->isEnabled(),
68			$commitMsg->getRegularExpression()->value()
69			);
70
71			$prePushResponse = new PrePushResponse(
72			$prePush->isEnabled(),
73			$prePush->getMessages()->getRightMessage(),
74			$prePush->getMessages()->getErrorMessage(),
75			new PhpUnitResponse(
76			$prePushPhpUnit->isEnabled(),
77			$prePushPhpUnit->getRandomMode()->value(),
78			$prePushPhpUnit->getOptions()->value()
79			),
80			new PhpUnitStrictCoverageResponse(
81			$prePushStrictCoverage->isEnabled(),
82			$prePushStrictCoverage->getMinimumStrictCoverage()->value()
83			),
84			new PhpUnitGuardCoverageResponse(
85			$prePushGuardCoverage->isEnabled(),
86			$prePushGuardCoverage->getWarningMessage()->value()
87			)
88			);
89
90			$preCommitResponse = new PreCommitResponse(
91			$preCommit->isEnabled(),
92			$preCommit->getMessages()->getRightMessage()->value(),
93			$preCommit->getMessages()->getErrorMessage()->value(),
94			$composer->isEnabled(),
95			$jsonLint->isEnabled(),
96			$phpLint->isEnabled(),
97			new PhpMdResponse($phpMd->isEnabled(), $phpMd->getOptions()->value()),
98			new PhpCsResponse($phpCs->isEnabled(), $phpCs->getStandard()->value(), $phpCs->getIgnore()->value()),
99			new PhpCsFixerResponse(
100			$phpCsFixer->isEnabled(),
101			$phpCsFixer->getLevels()->getPsr0()->value(),
102			$phpCsFixer->getLevels()->getPsr1()->value(),
103			$phpCsFixer->getLevels()->getPsr2()->value(),
104			$phpCsFixer->getLevels()->getSymfony()->value(),
105			$phpCsFixer->getOptions()->value()
106			),
107			new PhpUnitResponse(
108			$phpUnit->isEnabled(),
109			$phpUnit->getRandomMode()->value(),
110			$phpUnit->getOptions()->value()
111			),
112			new PhpUnitStrictCoverageResponse(
113			$phpUnitStrictCoverage->isEnabled(),
114			$phpUnitStrictCoverage->getMinimumStrictCoverage()->value()
115			),
116			new PhpUnitGuardCoverageResponse(
117			$phpUnitGuardCoverage->isEnabled(),
118			$phpUnitGuardCoverage->getWarningMessage()->value()
119			)
120			);
121
122			return new ConfigurationDataResponse($preCommitResponse, $commitMsgResponse, $prePushResponse);
123			}
124			}
125

bruli / php-git-hooks

Pull Request — master (#85)

ConfigurationDataResponseFactory::build() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like