PhpMDHandler::run() - Code Metrics - Inspection of "Adding more config params to MessDetector" - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#64)

unknown

created 2016-06-15 21:15 UTC

PhpMDHandler::run() B

↳ Parent: PhpMDHandler

Complexity

Conditions	8
Paths	17

Size

Total Lines	54
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes	10
Bugs	2	Features	1

Metric	Value
c	10
b	2
f	1
dl	0
loc	54
rs	7.4119
cc	8
eloc	32
nc	17
nop	1

How to fix Long Method

<?php

namespace PhpGitHooks\Infrastructure\PhpMD;

use IgnoreFiles\IgnoreFiles;
use PhpGitHooks\Command\OutputHandlerInterface;
use PhpGitHooks\Infrastructure\Common\RecursiveToolInterface;
use PhpGitHooks\Infrastructure\Common\ToolHandler;
use Symfony\Component\Process\ProcessBuilder;

/**
 * Class PhpMDHandler.
 */
class PhpMDHandler extends ToolHandler implements RecursiveToolInterface
{
    /** @var  array */
    private $files;
    /** @var  string */
    private $needle;
    /** @var  int */
    private $minimumPriority;
    /**
     * @var IgnoreFiles
     */
    private $ignoreFiles;

    /**
     * PhpMDHandler constructor.
     *
     * @param OutputHandlerInterface $outputHandler
     * @param IgnoreFiles            $ignoreFiles
     */
    public function __construct(OutputHandlerInterface $outputHandler, IgnoreFiles $ignoreFiles)
    {
        parent::__construct($outputHandler);
        $this->ignoreFiles = $ignoreFiles;
    }

    /**
     * @param array $messages
     *
     * @throws PHPMDViolationsException
     */
    public function run(array $messages)
    {
        $this->outputHandler->setTitle('Checking code mess with PHPMD');
        $this->output->write($this->outputHandler->getTitle());

        $errors = [];

        foreach ($this->files as $file) {
            if (!preg_match($this->needle, $file)) {
                continue;
            }

            $pmdRulesXml = realpath(__DIR__.self::COMPOSER_VENDOR_DIR).'/../PmdRules.xml';
            if (!file_exists($pmdRulesXml)) {
                throw new PHPMDViolationsException('You don\'t have specific PmdRules.xml in the root of your project. See Readme.md to create it');
            }

            $command = array(
                'php',
                $this->getBinPath('phpmd'),
                $file,
                'text',
                '/PmdRules.xml',
            );

            if ($this->getMinimumPriority() > -1) {
                array_push($command, '--minimumpriority');
                array_push($command, $this->getMinimumPriority());
            }

            if (false === $this->ignoreFiles->isIgnored($file)) {
                $processBuilder = new ProcessBuilder($command);
                $process = $processBuilder->getProcess();
                $process->run();

                if (false === $process->isSuccessful()) {
                    $errors[] = $process->getOutput();
                }
            }
        }

        $errors = array_filter($errors, function ($var) {
            return trim($var);
        });

        if (!empty($errors)) {
            $this->writeOutputError(
                new PHPMDViolationsException("Check MD errors listed above"),
                implode("\n", $errors)
            );
        }

        $this->output->writeln($this->outputHandler->getSuccessfulStepMessage());
    }

    /**
     * @param string $needle
     */
    public function setNeedle($needle)
    {
        $this->needle = $needle;
    }

    /**
     * @param array $files
     */
    public function setFiles($files)
    {
        $this->files = $files;
    }

    /**
     * @return int
     */
    public function getMinimumPriority()
    {
        return $this->minimumPriority;
    }

    /**
     * @param int $minimumPriority
     */
    public function setMinimumPriority($minimumPriority)
    {
        $this->minimumPriority = $minimumPriority;
    }
}


1			<?php
2
3			namespace PhpGitHooks\Infrastructure\PhpMD;
4
5			use IgnoreFiles\IgnoreFiles;
6			use PhpGitHooks\Command\OutputHandlerInterface;
7			use PhpGitHooks\Infrastructure\Common\RecursiveToolInterface;
8			use PhpGitHooks\Infrastructure\Common\ToolHandler;
9			use Symfony\Component\Process\ProcessBuilder;
10
11			/**
12			* Class PhpMDHandler.
13			*/
14			class PhpMDHandler extends ToolHandler implements RecursiveToolInterface
15			{
16			/** @var array */
17			private $files;
18			/** @var string */
19			private $needle;
20			/** @var int */
21			private $minimumPriority;
22			/**
23			* @var IgnoreFiles
24			*/
25			private $ignoreFiles;
26
27			/**
28			* PhpMDHandler constructor.
29			*
30			* @param OutputHandlerInterface $outputHandler
31			* @param IgnoreFiles $ignoreFiles
32			*/
33			public function __construct(OutputHandlerInterface $outputHandler, IgnoreFiles $ignoreFiles)
34			{
35			parent::__construct($outputHandler);
36			$this->ignoreFiles = $ignoreFiles;
37			}
38
39			/**
40			* @param array $messages
41			*
42			* @throws PHPMDViolationsException
43			*/
44			public function run(array $messages)
45			{
46			$this->outputHandler->setTitle('Checking code mess with PHPMD');
47			$this->output->write($this->outputHandler->getTitle());
48
49			$errors = [];
50
51			foreach ($this->files as $file) {
52			if (!preg_match($this->needle, $file)) {
53			continue;
54			}
55
56			$pmdRulesXml = realpath(__DIR__.self::COMPOSER_VENDOR_DIR).'/../PmdRules.xml';
57			if (!file_exists($pmdRulesXml)) {
58			throw new PHPMDViolationsException('You don\'t have specific PmdRules.xml in the root of your project. See Readme.md to create it');
59			}
60
61			$command = array(
62			'php',
63			$this->getBinPath('phpmd'),
64			$file,
65			'text',
66			'/PmdRules.xml',
67			);
68
69			if ($this->getMinimumPriority() > -1) {
70			array_push($command, '--minimumpriority');
71			array_push($command, $this->getMinimumPriority());
72			}
73
74			if (false === $this->ignoreFiles->isIgnored($file)) {
75			$processBuilder = new ProcessBuilder($command);
76			$process = $processBuilder->getProcess();
77			$process->run();
78
79			if (false === $process->isSuccessful()) {
80			$errors[] = $process->getOutput();
81			}
82			}
83			}
84
85			$errors = array_filter($errors, function ($var) {
86			return trim($var);
87			});
88
89			if (!empty($errors)) {
90			$this->writeOutputError(
91			new PHPMDViolationsException("Check MD errors listed above"),
92			implode("\n", $errors)
93			);
94			}
95
96			$this->output->writeln($this->outputHandler->getSuccessfulStepMessage());
97			}
98
99			/**
100			* @param string $needle
101			*/
102			public function setNeedle($needle)
103			{
104			$this->needle = $needle;
105			}
106
107			/**
108			* @param array $files
109			*/
110			public function setFiles($files)
111			{
112			$this->files = $files;
113			}
114
115			/**
116			* @return int
117			*/
118			public function getMinimumPriority()
119			{
120			return $this->minimumPriority;
121			}
122
123			/**
124			* @param int $minimumPriority
125			*/
126			public function setMinimumPriority($minimumPriority)
127			{
128			$this->minimumPriority = $minimumPriority;
129			}
130			}
131

bruli / php-git-hooks

Pull Request — master (#64)

PhpMDHandler::run() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like