PhpGitHooks\Application\PhpMD\CheckPhpMessDetectionPreCommitExecutor

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

56.25%

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	commandName()	0	4	1
A	run()	0	12	3

<?php

namespace PhpGitHooks\Application\PhpMD;

use PhpGitHooks\Application\Config\HookConfigExtraToolInterface;
use PhpGitHooks\Application\Config\HookConfigInterface;
use PhpGitHooks\Infrastructure\Common\PreCommitExecutor;
use PhpGitHooks\Infrastructure\Common\RecursiveToolInterface;
use PhpGitHooks\Infrastructure\PhpMD\PhpMDHandler;
use PhpGitHooks\Infrastructure\PhpMD\PHPMDViolationsException;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class CheckPhpMessDetectionPreCommitExecutor.
 */
class CheckPhpMessDetectionPreCommitExecutor extends PreCommitExecutor
{
    /** @var PhpMDHandler */
    private $phpMDHandler;

    /**
     * @param HookConfigExtraToolInterface    $hookConfigInterface
     * @param RecursiveToolInterface $recursiveToolInterface
     */
    public function __construct(
        HookConfigExtraToolInterface $hookConfigInterface,
        RecursiveToolInterface $recursiveToolInterface
    ) {
        $this->phpMDHandler = $recursiveToolInterface;

$recursiveToolInterface is of type object<PhpGitHooks\Infrastructure\Common\RecursiveToolInterface>, but the property $phpMDHandler was declared to be of type object<PhpGitHooks\Infrastructure\PhpMD\PhpMDHandler>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->preCommitConfig = $hookConfigInterface;

It seems like $hookConfigInterface of type object<PhpGitHooks\Application\Config\HookConfigExtraToolInterface> is incompatible with the declared type object<PhpGitHooks\Application\Config\HookConfigInterface> of property $preCommitConfig.

    }

    /**
     * @return string
     */
    protected function commandName()
    {
        return 'phpmd';
    }

    /**
     * @param OutputInterface $output
     * @param array           $files
     * @param string          $needle
     *
     * @throws PHPMDViolationsException
     */
    public function run(OutputInterface $output, array $files, $needle)
    {
        $data = $this->preCommitConfig->extraOptions($this->commandName());

        if (true === $data['enabled']) {
            $this->phpMDHandler->setOutput($output);
            $this->phpMDHandler->setMinimumPriority(isset($data['minimum-priority']) ? intval($data['minimum-priority']) : 1);
            $this->phpMDHandler->setFiles($files);
            $this->phpMDHandler->setNeedle($needle);
            $this->phpMDHandler->run($this->getMessages());
        }
    }
}