PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitToolHandler

Complexity

Total Complexity

6

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	execute()	0	13	2
A	executeTool()	0	6	2
A	handle()	0	8	1

<?php

namespace PhpGitHooks\Module\PhpUnit\Contract\Command;

use Bruli\EventBusBundle\CommandBus\CommandHandlerInterface;
use Bruli\EventBusBundle\CommandBus\CommandInterface;
use PhpGitHooks\Module\Git\Contract\Response\BadJobLogoResponse;
use PhpGitHooks\Module\Git\Service\PreCommitOutputWriter;
use PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitTool;
use PhpGitHooks\Module\PhpUnit\Contract\Exception\PhpUnitViolationException;
use PhpGitHooks\Module\PhpUnit\Model\PhpUnitProcessorInterface;
use Symfony\Component\Console\Output\OutputInterface;

class PhpUnitToolHandler implements CommandHandlerInterface
{
    const EXECUTING_MESSAGE = 'Running unit tests';
    /**
     * @var OutputInterface
     */
    private $output;
    /**
     * @var PhpUnitProcessorInterface
     */
    private $phpUnitProcessor;
    /**
     * @var PhpUnitProcessorInterface
     */
    private $phpUnitRandomizerProcessor;

    /**
     * PhpUnitTool constructor.
     *
     * @param OutputInterface $output
     * @param PhpUnitProcessorInterface $phpUnitProcessor
     * @param PhpUnitProcessorInterface $phpUnitRandomizerProcessor
     */
    public function __construct(
        OutputInterface $output,
        PhpUnitProcessorInterface $phpUnitProcessor,
        PhpUnitProcessorInterface $phpUnitRandomizerProcessor
    ) {
        $this->output = $output;
        $this->phpUnitProcessor = $phpUnitProcessor;
        $this->phpUnitRandomizerProcessor = $phpUnitRandomizerProcessor;
    }

    /**
     * @param string $randomMode
     * @param string $options
     * @param string $errorMessage
     *
     * @throws PhpUnitViolationException
     */
    private function execute($randomMode, $options, $errorMessage)
    {
        $outputMessage = new PreCommitOutputWriter(self::EXECUTING_MESSAGE);
        $this->output->writeln($outputMessage->getMessage());

        $testResult = $this->executeTool($randomMode, $options);

$randomMode is of type string, but the function expects a boolean.

        if (false === $testResult) {
            $this->output->writeln(BadJobLogoResponse::paint($errorMessage));

            throw new PhpUnitViolationException();
        }
    }

    /**
     * @param bool $randomMode
     * @param string $options
     *
     * @return bool
     */
    protected function executeTool($randomMode, $options)
    {
        return true === $randomMode ? $this->phpUnitRandomizerProcessor->process(
            $options
        ) : $this->phpUnitProcessor->process($options);
    }

    /**
     * @param CommandInterface|PhpUnitTool $command
     */
    public function handle(CommandInterface $command)
    {
        $this->execute(
            $command->isRandomMode(),

It seems like you code against a concrete implementation and not the interface Bruli\EventBusBundle\CommandBus\CommandInterface as the method isRandomMode() does only exist in the following implementations of said interface: PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitTool.

            $command->getOptions(),

It seems like you code against a concrete implementation and not the interface Bruli\EventBusBundle\CommandBus\CommandInterface as the method getOptions() does only exist in the following implementations of said interface: PhpGitHooks\Module\PhpCsFixer\Contract\Command\PhpCsFixerTool, PhpGitHooks\Module\PhpMd\Contract\Command\PhpMdTool, PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitTool.

            $command->getErrorMessage()

It seems like you code against a concrete implementation and not the interface Bruli\EventBusBundle\CommandBus\CommandInterface as the method getErrorMessage() does only exist in the following implementations of said interface: PhpGitHooks\Module\Composer\Contract\Command\ComposerTool, PhpGitHooks\Module\JsonLint\Contract\Command\JsonLintTool, PhpGitHooks\Module\PhpCsFixer\Contract\Command\PhpCsFixerTool, PhpGitHooks\Module\PhpCs\Contract\Command\PhpCsTool, PhpGitHooks\Module\PhpLint\Contract\Command\PhpLintTool, PhpGitHooks\Module\PhpMd\Contract\Command\PhpMdTool, PhpGitHooks\Module\PhpUnit\Contract\Command\PhpUnitTool, PhpGitHooks\Module\PhpUnit\Contract\Command\StrictCoverage.

        );
    }
}