PhpMdToolProcessor::setError() - Code Metrics - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

PhpMdToolProcessor::setError() A
last analyzed 2019-12-13 13:07 UTC

↳ Parent: PhpMdToolProcessor

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
dl	8
loc	8
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php

namespace PhpGitHooks\Module\PhpMd\Infrastructure\Tool;

use PhpGitHooks\Infrastructure\Tool\ToolPathFinder;
use PhpGitHooks\Module\PhpMd\Model\PhpMdToolProcessorInterface;
use Symfony\Component\Process\Process;

class PhpMdToolProcessor implements PhpMdToolProcessorInterface
{
    /**
     * @var ToolPathFinder
     */
    private $toolPathFinder;

    /**
     * PhpMdToolProcessor constructor.
     *
     * @param ToolPathFinder $toolPathFinder
     */
    public function __construct(ToolPathFinder $toolPathFinder)
    {
        $this->toolPathFinder = $toolPathFinder;
    }

    /**
     * @param string $file
     * @param string $options
     *
     * @return string
     */
    public function process($file, $options)
    {
        $process = $this->execute($file, $options);

        return $this->setError($process);
    }

    /**
     * @param string $file
     * @param string $options
     *
     * @return Process
     */
    private function execute($file, $options)
    {
        $command = sprintf('php %s %s text ./PmdRules.xml %s', $this->toolPathFinder->find('phpmd'), $file, $options);

        $process = new Process($command);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $process->run();

        return $process;
    }

    /**
     * @param Process $process
     *
     * @return null|string
     *
     * @throws \Symfony\Component\Process\Exception\LogicException
     */
    private function setError(Process $process)

    {
        if (false === $process->isSuccessful()) {
            return $process->getErrorOutput() ?: $process->getOutput();
        }

        return null;
    }
}


1		<?php
2
3		namespace PhpGitHooks\Module\PhpMd\Infrastructure\Tool;
4
5		use PhpGitHooks\Infrastructure\Tool\ToolPathFinder;
6		use PhpGitHooks\Module\PhpMd\Model\PhpMdToolProcessorInterface;
7		use Symfony\Component\Process\Process;
8
9		class PhpMdToolProcessor implements PhpMdToolProcessorInterface
10		{
11		/**
12		* @var ToolPathFinder
13		*/
14		private $toolPathFinder;
15
16		/**
17		* PhpMdToolProcessor constructor.
18		*
19		* @param ToolPathFinder $toolPathFinder
20		*/
21		public function __construct(ToolPathFinder $toolPathFinder)
22		{
23		$this->toolPathFinder = $toolPathFinder;
24		}
25
26		/**
27		* @param string $file
28		* @param string $options
29		*
30		* @return string
31		*/
32		public function process($file, $options)
33		{
34		$process = $this->execute($file, $options);
35
36		return $this->setError($process);
37		}
38
39		/**
40		* @param string $file
41		* @param string $options
42		*
43		* @return Process
44		*/
45		private function execute($file, $options)
46		{
47		$command = sprintf('php %s %s text ./PmdRules.xml %s', $this->toolPathFinder->find('phpmd'), $file, $options);
48
49		$process = new Process($command);
		0 ignored issues – show Documentation introduced 2019-07-29 14:45 UTC by Report Bug Copy Issue Report `$command` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50		$process->run();
51
52		return $process;
53		}
54
55		/**
56		* @param Process $process
57		*
58		* @return null\|string
59		*
60		* @throws \Symfony\Component\Process\Exception\LogicException
61		*/
62	View Code Duplication	private function setError(Process $process)
		0 ignored issues – show Duplication introduced 2018-10-23 07:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		if (false === $process->isSuccessful()) {
65		return $process->getErrorOutput() ?: $process->getOutput();
66		}
67
68		return null;
69		}
70		}
71

bruli / php-git-hooks

PhpMdToolProcessor::setError() A last analyzed 2019-12-13 13:07 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PhpMdToolProcessor::setError() A
last analyzed 2019-12-13 13:07 UTC