MergeValidatorTrait::getMergeValidator() - Code Metrics - bruli/php-git-hooks - Measure and Improve Code Quality continuously with Scrutinizer

MergeValidatorTrait::getMergeValidator() A
last analyzed 2019-12-13 13:07 UTC

↳ Parent: MergeValidatorTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace PhpGitHooks\Module\Git\Tests\Infrastructure;

use PhpGitHooks\Module\Git\Model\MergeValidatorInterface;
use PhpGitHooks\Module\Tests\Infrastructure\UnitTestCase\Mock;

trait MergeValidatorTrait
{
    /**
     * @var MergeValidatorInterface
     */
    private $mergeValidator;

    /**
     * @return \Mockery\MockInterface|MergeValidatorInterface
     */
    protected function getMergeValidator()
    {
        return $this->mergeValidator = $this->mergeValidator ?: Mock::get(MergeValidatorInterface::class);
    }

    /**
     * @param bool $return
     */
    protected function shouldCallIsMerge($return)
    {
        $this->getMergeValidator()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->shouldReceive('isMerge')
            ->once()
            ->andReturn($return);
    }
}


1			<?php
2
3			namespace PhpGitHooks\Module\Git\Tests\Infrastructure;
4
5			use PhpGitHooks\Module\Git\Model\MergeValidatorInterface;
6			use PhpGitHooks\Module\Tests\Infrastructure\UnitTestCase\Mock;
7
8			trait MergeValidatorTrait
9			{
10			/**
11			* @var MergeValidatorInterface
12			*/
13			private $mergeValidator;
14
15			/**
16			* @return \Mockery\MockInterface\|MergeValidatorInterface
17			*/
18			protected function getMergeValidator()
19			{
20			return $this->mergeValidator = $this->mergeValidator ?: Mock::get(MergeValidatorInterface::class);
21			}
22
23			/**
24			* @param bool $return
25			*/
26			protected function shouldCallIsMerge($return)
27			{
28			$this->getMergeValidator()
			0 ignored issues – show Bug introduced 2016-06-20 10:27 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `PhpGitHooks\Module\Git\M...MergeValidatorInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
29			->shouldReceive('isMerge')
30			->once()
31			->andReturn($return);
32			}
33			}
34

bruli / php-git-hooks

MergeValidatorTrait::getMergeValidator() A last analyzed 2019-12-13 13:07 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

MergeValidatorTrait::getMergeValidator() A
last analyzed 2019-12-13 13:07 UTC