GitIgnoreFileReaderTrait   A
last analyzed

Complexity

Total Complexity 3

Size/Duplication

Total Lines 26
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 1

Importance

Changes 0
Metric Value
wmc 3
lcom 1
cbo 1
dl 0
loc 26
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A getGitIgnoreFileReader() 0 4 2
A shouldReadGitIgnoreFile() 0 7 1
1
<?php
2
3
namespace PhpGitHooks\Module\Git\Tests\Infrastructure;
4
5
use PhpGitHooks\Module\Git\Model\ReaderInterface;
6
use PhpGitHooks\Module\Tests\Infrastructure\UnitTestCase\Mock;
7
8
trait GitIgnoreFileReaderTrait
9
{
10
    /**
11
     * @var ReaderInterface
12
     */
13
    private $gitIgnoreFileReader;
14
15
    /**
16
     * @return \Mockery\MockInterface|ReaderInterface
17
     */
18
    protected function getGitIgnoreFileReader()
19
    {
20
        return $this->gitIgnoreFileReader = $this->gitIgnoreFileReader ?: Mock::get(ReaderInterface::class);
21
    }
22
23
    /**
24
     * @param string|null $return
25
     */
26
    protected function shouldReadGitIgnoreFile($return)
27
    {
28
        $this->getGitIgnoreFileReader()
0 ignored issues
show
Bug introduced by
The method shouldReceive does only exist in Mockery\MockInterface, but not in PhpGitHooks\Module\Git\Model\ReaderInterface.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
29
            ->shouldReceive('read')
30
            ->once()
31
            ->andReturn($return);
32
    }
33
}
34