CheckProperties::check() - Code Metrics - Inspection of "strong typing, refactoring" - browscap/browscap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1596)

by Thomas

created 2017-10-04 14:31 UTC

CheckProperties::check() C

↳ Parent: CheckProperties

Complexity

Conditions	21
Paths	32

Size

Total Lines	76
Code Lines	48

Duplication

Lines	45
Ratio	59.21 %

Importance

Changes

Metric	Value
dl	45
loc	76
rs	5.2051
c	0
b	0
f	0
cc	21
eloc	48
nc	32
nop	2

How to fix Long Method Complexity

<?php
declare(strict_types = 1);
namespace Browscap\Data\Helper;

/**
 * Class DataCollection
 */
class CheckProperties
{
    /**
     * @param string $key
     * @param array  $properties
     *
     * @throws \LogicException
     *
     * @return void
     */
    public function check($key, array $properties) : void
    {
        if (!array_key_exists('Version', $properties)) {
            throw new \LogicException('Version property not found for key "' . $key . '"');
        }

        if (!array_key_exists('Parent', $properties) && !in_array($key, ['DefaultProperties', '*'])) {
            throw new \LogicException('Parent property is missing for key "' . $key . '"');
        }

        if (!array_key_exists('Device_Type', $properties)) {
            throw new \LogicException('property "Device_Type" is missing for key "' . $key . '"');
        }

        if (!array_key_exists('isTablet', $properties)) {
            throw new \LogicException('property "isTablet" is missing for key "' . $key . '"');
        }

        if (!array_key_exists('isMobileDevice', $properties)) {
            throw new \LogicException('property "isMobileDevice" is missing for key "' . $key . '"');
        }

        switch ($properties['Device_Type']) {
            case 'Tablet':

                if (true !== $properties['isTablet']) {
                    throw new \LogicException(
                        'the device of type "' . $properties['Device_Type'] . '" is NOT marked as Tablet for key "'
                        . $key . '"'
                    );
                }
                if (true !== $properties['isMobileDevice']) {
                    throw new \LogicException(
                        'the device of type "' . $properties['Device_Type']
                        . '" is NOT marked as Mobile Device for key "' . $key . '"'
                    );
                }

                break;
            case 'Mobile Phone':
            case 'Mobile Device':
            case 'Ebook Reader':
            case 'Console':
            case 'Digital Camera':

                if (true === $properties['isTablet']) {
                    throw new \LogicException(
                        'the device of type "' . $properties['Device_Type'] . '" is marked as Tablet for key "'
                        . $key . '"'
                    );
                }
                if (true !== $properties['isMobileDevice']) {
                    throw new \LogicException(
                        'the device of type "' . $properties['Device_Type']
                        . '" is NOT marked as Mobile Device for key "' . $key . '"'
                    );
                }

                break;
            case 'TV Device':
            case 'Desktop':
            default:

                if (true === $properties['isTablet']) {
                    throw new \LogicException(
                        'the device of type "' . $properties['Device_Type'] . '" is marked as Tablet for key "'
                        . $key . '"'
                    );
                }
                if (true === $properties['isMobileDevice']) {
                    throw new \LogicException(
                        'the device of type "' . $properties['Device_Type'] . '" is marked as Mobile Device for key "'
                        . $key . '"'
                    );
                }

                break;
        }
    }
}


1		<?php
2		declare(strict_types = 1);
3		namespace Browscap\Data\Helper;
4
5		/**
6		* Class DataCollection
7		*/
8		class CheckProperties
9		{
10		/**
11		* @param string $key
12		* @param array $properties
13		*
14		* @throws \LogicException
15		*
16		* @return void
17		*/
18		public function check($key, array $properties) : void
19		{
20		if (!array_key_exists('Version', $properties)) {
21		throw new \LogicException('Version property not found for key "' . $key . '"');
22		}
23
24		if (!array_key_exists('Parent', $properties) && !in_array($key, ['DefaultProperties', '*'])) {
25		throw new \LogicException('Parent property is missing for key "' . $key . '"');
26		}
27
28		if (!array_key_exists('Device_Type', $properties)) {
29		throw new \LogicException('property "Device_Type" is missing for key "' . $key . '"');
30		}
31
32		if (!array_key_exists('isTablet', $properties)) {
33		throw new \LogicException('property "isTablet" is missing for key "' . $key . '"');
34		}
35
36		if (!array_key_exists('isMobileDevice', $properties)) {
37		throw new \LogicException('property "isMobileDevice" is missing for key "' . $key . '"');
38		}
39
40		switch ($properties['Device_Type']) {
41	View Code Duplication	case 'Tablet':
		0 ignored issues – show Duplication introduced 2015-11-20 22:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		if (true !== $properties['isTablet']) {
43		throw new \LogicException(
44		'the device of type "' . $properties['Device_Type'] . '" is NOT marked as Tablet for key "'
45		. $key . '"'
46		);
47		}
48		if (true !== $properties['isMobileDevice']) {
49		throw new \LogicException(
50		'the device of type "' . $properties['Device_Type']
51		. '" is NOT marked as Mobile Device for key "' . $key . '"'
52		);
53		}
54
55		break;
56		case 'Mobile Phone':
57		case 'Mobile Device':
58		case 'Ebook Reader':
59		case 'Console':
60	View Code Duplication	case 'Digital Camera':
		0 ignored issues – show Duplication introduced 2015-11-20 22:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		if (true === $properties['isTablet']) {
62		throw new \LogicException(
63		'the device of type "' . $properties['Device_Type'] . '" is marked as Tablet for key "'
64		. $key . '"'
65		);
66		}
67		if (true !== $properties['isMobileDevice']) {
68		throw new \LogicException(
69		'the device of type "' . $properties['Device_Type']
70		. '" is NOT marked as Mobile Device for key "' . $key . '"'
71		);
72		}
73
74		break;
75		case 'TV Device':
76		case 'Desktop':
77	View Code Duplication	default:
		0 ignored issues – show Duplication introduced 2015-11-20 22:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		if (true === $properties['isTablet']) {
79		throw new \LogicException(
80		'the device of type "' . $properties['Device_Type'] . '" is marked as Tablet for key "'
81		. $key . '"'
82		);
83		}
84		if (true === $properties['isMobileDevice']) {
85		throw new \LogicException(
86		'the device of type "' . $properties['Device_Type'] . '" is marked as Mobile Device for key "'
87		. $key . '"'
88		);
89		}
90
91		break;
92		}
93		}
94		}
95

browscap / browscap

Pull Request — master (#1596)

CheckProperties::check() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like