Expander::parseUserAgent() - Code Metrics - Inspection of "strong typing, refactoring" - browscap/browscap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1596)

by Thomas

created 2017-10-07 19:51 UTC

Expander::parseUserAgent() C

↳ Parent: Expander

Complexity

Conditions	11
Paths	90

Size

Total Lines	85
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	38
CRAP Score	13.0039

Importance

Changes

Metric	Value
dl	0
loc	85
ccs	38
cts	51
cp	0.7451
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	56
nc	90
nop	5
crap	13.0039

How to fix Long Method Complexity

<?php
declare(strict_types = 1);
namespace Browscap\Data;

use Browscap\Data\Helper\TrimProperty;
use Psr\Log\LoggerInterface;

class Expander
{
    /**
     * @var DataCollection
     */
    private $collection;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * This store the components of the pattern id that are later merged into a string. Format for this
     * can be seen in the {@see resetPatternId} method.
     *
     * @var array
     */
    private $patternId = [];

    /**
     * @var TrimProperty
     */
    private $trimProperty;

    /**
     * Create a new data expander
     *
     * @param LoggerInterface $logger
     * @param DataCollection  $collection
     */
    public function __construct(LoggerInterface $logger, DataCollection $collection)
    {
        $this->logger       = $logger;
        $this->collection   = $collection;
        $this->trimProperty = new TrimProperty();
    }

    /**
     * @param Division $division
     * @param string   $divisionName
     *
     * @throws \UnexpectedValueException
     *
     * @return array[]
     */
    public function expand(Division $division, string $divisionName) : array
    {
        $allInputDivisions = $this->parseDivision(
            $division,
            $divisionName
        );

        return $this->expandProperties($allInputDivisions);
    }

    /**
     * Resets the pattern id
     *
     * @return void
     */
    private function resetPatternId() : void
    {
        $this->patternId = [
            'division' => '',
            'useragent' => '',
            'platform' => '',
            'device' => '',
            'child' => '',
        ];
    }

    /**
     * parses and expands a single division
     *
     * @param Division $division
     * @param string   $divisionName
     *
     * @return array[]
     */
    private function parseDivision(Division $division, string $divisionName) : array
    {
        $output = [];

        $i = 0;
        foreach ($division->getUserAgents() as $uaData) {
            $this->resetPatternId();
            $this->patternId['division']  = $division->getFileName();
            $this->patternId['useragent'] = $i;

            $output = array_merge(
                $output,
                $this->parseUserAgent(
                    $uaData,
                    $division->isLite(),
                    $division->isStandard(),
                    $division->getSortIndex(),
                    $divisionName
                )
            );
            ++$i;
        }

        return $output;
    }

    /**
     * parses and expands a single User Agent block
     *
     * @param UserAgent $uaData
     * @param bool      $lite
     * @param bool      $standard
     * @param int       $sortIndex
     * @param string    $divisionName
     *
     * @return array[]
     */
    private function parseUserAgent(UserAgent $uaData, bool $lite, bool $standard, int $sortIndex, string $divisionName) : array
    {
        $uaProperties = $uaData->getProperties();

        if (null !== $uaData->getPlatform()) {
            $this->patternId['platform'] = $uaData->getPlatform();
            $platform                    = $this->collection->getPlatform($uaData->getPlatform());

            if (!$platform->isLite()) {
                $lite = false;
            }

            if (!$platform->isStandard()) {
                $standard = false;
            }

            $platformProperties = $platform->getProperties();
        } else {
            $this->patternId['platform'] = '';
            $platformProperties          = [];
        }

        if (null !== $uaData->getEngine()) {
            $engine           = $this->collection->getEngine($uaData->getEngine());
            $engineProperties = $engine->getProperties();
        } else {
            $engineProperties = [];
        }

        if (null !== $uaData->getDevice()) {
            $device           = $this->collection->getDevice($uaData->getDevice());
            $deviceProperties = $device->getProperties();

            if (!$device->isStandard()) {
                $standard = false;
            }
        } else {
            $deviceProperties = [];
        }

        $ua = $uaData->getUserAgent();

        $output = [
            $ua => array_merge(
                [
                    'lite' => $lite,
                    'standard' => $standard,
                    'sortIndex' => $sortIndex,
                    'division' => $divisionName,
                ],
                $platformProperties,
                $engineProperties,
                $deviceProperties,
                $uaProperties
            ),
        ];

        $i = 0;
        foreach ($uaData->getChildren() as $child) {
            $this->patternId['child'] = $i;
            if (isset($child['devices']) && is_array($child['devices'])) {
                // Replace our device array with a single device property with our #DEVICE# token replaced
                foreach ($child['devices'] as $deviceMatch => $deviceName) {
                    $this->patternId['device'] = $deviceMatch;
                    $subChild                  = $child;
                    $subChild['match']         = str_replace('#DEVICE#', $deviceMatch, $subChild['match']);
                    $subChild['device']        = $deviceName;
                    unset($subChild['devices']);
                    $output = array_merge(
                        $output,
                        $this->parseChildren($ua, $subChild, $lite, $standard)
                    );
                }
            } else {
                $this->patternId['device'] = '';
                $output                    = array_merge(
                    $output,
                    $this->parseChildren($ua, $child, $lite, $standard)
                );
            }
            ++$i;
        }

        return $output;
    }

    /**
     * parses and expands the children section in a single User Agent block
     *
     * @param string $ua
     * @param array  $uaDataChild
     * @param bool   $lite
     * @param bool   $standard
     *
     * @return array[]
     */
    private function parseChildren(string $ua, array $uaDataChild, bool $lite = true, bool $standard = true) : array
    {
        $output = [];

        if (isset($uaDataChild['platforms']) && is_array($uaDataChild['platforms'])) {
            foreach ($uaDataChild['platforms'] as $platform) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $this->patternId['platform'] = $platform;
                $properties                  = ['Parent' => $ua, 'lite' => $lite, 'standard' => $standard];
                $platformProperties          = $this->collection->getPlatform($platform);

                if (!$platformProperties->isLite()) {
                    $properties['lite'] = false;
                }

                if (!$platformProperties->isStandard()) {
                    $properties['standard'] = false;
                }

                $uaBase = str_replace('#PLATFORM#', $platformProperties->getMatch(), $uaDataChild['match']);

                if (array_key_exists('engine', $uaDataChild)) {

                    $engine           = $this->collection->getEngine($uaDataChild['engine']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $engineProperties = $engine->getProperties();
                } else {
                    $engineProperties = [];
                }

                if (array_key_exists('device', $uaDataChild)) {

                    $device           = $this->collection->getDevice($uaDataChild['device']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $deviceProperties = $device->getProperties();

                    if (!$device->isStandard()) {
                        $properties['standard'] = false;
                    }
                } else {
                    $deviceProperties = [];
                }

                $properties = array_merge(
                    $properties,
                    $engineProperties,
                    $deviceProperties,
                    $platformProperties->getProperties()
                );

                if (isset($uaDataChild['properties'])
                    && is_array($uaDataChild['properties'])
                ) {
                    $childProperties = $uaDataChild['properties'];

                    $properties = array_merge($properties, $childProperties);
                }

                $properties['PatternId'] = $this->getPatternId();

                $output[$uaBase] = $properties;
            }
        } else {
            $properties = ['Parent' => $ua, 'lite' => $lite, 'standard' => $standard];

            if (array_key_exists('engine', $uaDataChild)) {

                $engine           = $this->collection->getEngine($uaDataChild['engine']);
                $engineProperties = $engine->getProperties();
            } else {
                $engineProperties = [];
            }

            if (array_key_exists('device', $uaDataChild)) {

                $device           = $this->collection->getDevice($uaDataChild['device']);
                $deviceProperties = $device->getProperties();

                if (!$device->isStandard()) {
                    $properties['standard'] = false;
                }
            } else {
                $deviceProperties = [];
            }

            $properties = array_merge($properties, $engineProperties, $deviceProperties);

            if (isset($uaDataChild['properties'])
                && is_array($uaDataChild['properties'])
            ) {
                $properties = array_merge($properties, $uaDataChild['properties']);
            }

            $uaBase                      = str_replace('#PLATFORM#', '', $uaDataChild['match']);
            $this->patternId['platform'] = '';

            $properties['PatternId'] = $this->getPatternId();

            $output[$uaBase] = $properties;
        }

        return $output;
    }

    /**
     * Builds and returns the string pattern id from the array components
     *
     * @return string
     */
    private function getPatternId() : string
    {
        return sprintf(
            '%s::u%d::c%d::d%s::p%s',
            $this->patternId['division'],
            $this->patternId['useragent'],
            $this->patternId['child'],
            $this->patternId['device'],
            $this->patternId['platform']
        );
    }

    /**
     * expands all properties for all useragents to make sure all properties are set and make it possible to skip
     * incomplete properties and remove duplicate definitions
     *
     * @param array[] $allInputDivisions
     *
     * @throws \UnexpectedValueException
     *
     * @return array[]
     */
    private function expandProperties(array $allInputDivisions) : array
    {
        $this->logger->debug('expand all properties');
        $allDivisions = [];

        $ua                = $this->collection->getDefaultProperties()->getUserAgents()[0];
        $defaultproperties = $ua->getProperties();

        foreach (array_keys($allInputDivisions) as $key) {
            $this->logger->debug('expand all properties for key "' . $key . '"');

            $userAgent = $key;
            $parents   = [$userAgent];

            while (isset($allInputDivisions[$userAgent]['Parent'])) {
                if ($allInputDivisions[$userAgent]['Parent'] === $userAgent) {
                    break;
                }

                $parents[] = $allInputDivisions[$userAgent]['Parent'];
                $userAgent = $allInputDivisions[$userAgent]['Parent'];
            }
            unset($userAgent);

            $parents     = array_reverse($parents);
            $browserData = $defaultproperties;
            $properties  = $allInputDivisions[$key];

            foreach ($parents as $parent) {
                if (!isset($allInputDivisions[$parent])) {
                    continue;
                }

                if (!is_array($allInputDivisions[$parent])) {
                    throw new \UnexpectedValueException(
                        'Parent "' . $parent . '" is not an array for key "' . $key . '"'
                    );
                }

                if ($key !== $parent
                    && isset($allInputDivisions[$parent]['sortIndex'], $properties['sortIndex'])

                    && ($allInputDivisions[$parent]['division'] !== $properties['division'])
                ) {
                    if ($allInputDivisions[$parent]['sortIndex'] >= $properties['sortIndex']) {
                        throw new \UnexpectedValueException(
                            'sorting not ready for key "'
                            . $key . '"'
                        );
                    }
                }

                $browserData = array_merge($browserData, $allInputDivisions[$parent]);
            }

            array_pop($parents);
            $browserData['Parents'] = implode(',', $parents);
            unset($parents);

            foreach (array_keys($browserData) as $propertyName) {
                if (is_bool($browserData[$propertyName])) {
                    $properties[$propertyName] = $browserData[$propertyName];
                } else {
                    $properties[$propertyName] = $this->trimProperty->trimProperty((string) $browserData[$propertyName]);
                }
            }

            unset($browserData);

            $allDivisions[$key] = $properties;

            if (!isset($properties['Version'])) {
                throw new \UnexpectedValueException('Version property not found for key "' . $key . '"');
            }

            $completeVersions = explode('.', $properties['Version'], 2);

            $properties['MajorVer'] = (string) $completeVersions[0];

            if (isset($completeVersions[1])) {
                $minorVersion = (string) $completeVersions[1];
            } else {
                $minorVersion = '0';
            }

            $properties['MinorVer'] = $minorVersion;

            $allDivisions[$key] = $properties;
        }

        return $allDivisions;
    }
}


1			<?php
2			declare(strict_types = 1);
3			namespace Browscap\Data;
4
5			use Browscap\Data\Helper\TrimProperty;
6			use Psr\Log\LoggerInterface;
7
8			class Expander
9			{
10			/**
11			* @var DataCollection
12			*/
13			private $collection;
14
15			/**
16			* @var LoggerInterface
17			*/
18			private $logger;
19
20			/**
21			* This store the components of the pattern id that are later merged into a string. Format for this
22			* can be seen in the {@see resetPatternId} method.
23			*
24			* @var array
25			*/
26			private $patternId = [];
27
28			/**
29			* @var TrimProperty
30			*/
31			private $trimProperty;
32
33			/**
34			* Create a new data expander
35			*
36			* @param LoggerInterface $logger
37			* @param DataCollection $collection
38			*/
39	13		public function __construct(LoggerInterface $logger, DataCollection $collection)
40			{
41	13		$this->logger = $logger;
42	13		$this->collection = $collection;
43	13		$this->trimProperty = new TrimProperty();
44	13		}
45
46			/**
47			* @param Division $division
48			* @param string $divisionName
49			*
50			* @throws \UnexpectedValueException
51			*
52			* @return array[]
53			*/
54	13		public function expand(Division $division, string $divisionName) : array
55			{
56	13		$allInputDivisions = $this->parseDivision(
57	13		$division,
58	13		$divisionName
59			);
60
61	13		return $this->expandProperties($allInputDivisions);
62			}
63
64			/**
65			* Resets the pattern id
66			*
67			* @return void
68			*/
69	12		private function resetPatternId() : void
70			{
71	12		$this->patternId = [
72			'division' => '',
73			'useragent' => '',
74			'platform' => '',
75			'device' => '',
76			'child' => '',
77			];
78	12		}
79
80			/**
81			* parses and expands a single division
82			*
83			* @param Division $division
84			* @param string $divisionName
85			*
86			* @return array[]
87			*/
88	13		private function parseDivision(Division $division, string $divisionName) : array
89			{
90	13		$output = [];
91
92	13		$i = 0;
93	13		foreach ($division->getUserAgents() as $uaData) {
94	12		$this->resetPatternId();
95	12		$this->patternId['division'] = $division->getFileName();
96	12		$this->patternId['useragent'] = $i;
97
98	12		$output = array_merge(
99	12		$output,
100	12		$this->parseUserAgent(
101	12		$uaData,
102	12		$division->isLite(),
103	12		$division->isStandard(),
104	12		$division->getSortIndex(),
105	12		$divisionName
106			)
107			);
108	12		++$i;
109			}
110
111	13		return $output;
112			}
113
114			/**
115			* parses and expands a single User Agent block
116			*
117			* @param UserAgent $uaData
118			* @param bool $lite
119			* @param bool $standard
120			* @param int $sortIndex
121			* @param string $divisionName
122			*
123			* @return array[]
124			*/
125	12		private function parseUserAgent(UserAgent $uaData, bool $lite, bool $standard, int $sortIndex, string $divisionName) : array
126			{
127	12		$uaProperties = $uaData->getProperties();
128
129	12		if (null !== $uaData->getPlatform()) {
130			$this->patternId['platform'] = $uaData->getPlatform();
131			$platform = $this->collection->getPlatform($uaData->getPlatform());
132
133			if (!$platform->isLite()) {
134			$lite = false;
135			}
136
137			if (!$platform->isStandard()) {
138			$standard = false;
139			}
140
141			$platformProperties = $platform->getProperties();
142			} else {
143	12		$this->patternId['platform'] = '';
144	12		$platformProperties = [];
145			}
146
147	12		if (null !== $uaData->getEngine()) {
148			$engine = $this->collection->getEngine($uaData->getEngine());
149			$engineProperties = $engine->getProperties();
150			} else {
151	12		$engineProperties = [];
152			}
153
154	12		if (null !== $uaData->getDevice()) {
155			$device = $this->collection->getDevice($uaData->getDevice());
156			$deviceProperties = $device->getProperties();
157
158			if (!$device->isStandard()) {
159			$standard = false;
160			}
161			} else {
162	12		$deviceProperties = [];
163			}
164
165	12		$ua = $uaData->getUserAgent();
166
167			$output = [
168	12		$ua => array_merge(
169			[
170	12		'lite' => $lite,
171	12		'standard' => $standard,
172	12		'sortIndex' => $sortIndex,
173	12		'division' => $divisionName,
174			],
175	12		$platformProperties,
176	12		$engineProperties,
177	12		$deviceProperties,
178	12		$uaProperties
179			),
180			];
181
182	12		$i = 0;
183	12		foreach ($uaData->getChildren() as $child) {
184	6		$this->patternId['child'] = $i;
185	6		if (isset($child['devices']) && is_array($child['devices'])) {
186			// Replace our device array with a single device property with our #DEVICE# token replaced
187	3		foreach ($child['devices'] as $deviceMatch => $deviceName) {
188	3		$this->patternId['device'] = $deviceMatch;
189	3		$subChild = $child;
190	3		$subChild['match'] = str_replace('#DEVICE#', $deviceMatch, $subChild['match']);
191	3		$subChild['device'] = $deviceName;
192	3		unset($subChild['devices']);
193	3		$output = array_merge(
194	3		$output,
195	3		$this->parseChildren($ua, $subChild, $lite, $standard)
196			);
197			}
198			} else {
199	3		$this->patternId['device'] = '';
200	3		$output = array_merge(
201	3		$output,
202	3		$this->parseChildren($ua, $child, $lite, $standard)
203			);
204			}
205	6		++$i;
206			}
207
208	12		return $output;
209			}
210
211			/**
212			* parses and expands the children section in a single User Agent block
213			*
214			* @param string $ua
215			* @param array $uaDataChild
216			* @param bool $lite
217			* @param bool $standard
218			*
219			* @return array[]
220			*/
221	6		private function parseChildren(string $ua, array $uaDataChild, bool $lite = true, bool $standard = true) : array
222			{
223	6		$output = [];
224
225	6		if (isset($uaDataChild['platforms']) && is_array($uaDataChild['platforms'])) {
226	2		foreach ($uaDataChild['platforms'] as $platform) {
			0 ignored issues – show Bug introduced 2015-11-20 22:11 UTC by Report Bug Copy Issue Report The expression `$uaDataChild['platforms']` of type `array\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
227	2		$this->patternId['platform'] = $platform;
228	2		$properties = ['Parent' => $ua, 'lite' => $lite, 'standard' => $standard];
229	2		$platformProperties = $this->collection->getPlatform($platform);
230
231	2		if (!$platformProperties->isLite()) {
232	2		$properties['lite'] = false;
233			}
234
235	2		if (!$platformProperties->isStandard()) {
236	2		$properties['standard'] = false;
237			}
238
239	2		$uaBase = str_replace('#PLATFORM#', $platformProperties->getMatch(), $uaDataChild['match']);
240
241	2	View Code Duplication	if (array_key_exists('engine', $uaDataChild)) {
			0 ignored issues – show Duplication introduced 2017-03-24 21:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
242			$engine = $this->collection->getEngine($uaDataChild['engine']);
			0 ignored issues – show Documentation introduced 2017-09-23 09:24 UTC by Report Bug Copy Issue Report `$uaDataChild['engine']` is of type `array\|null`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
243			$engineProperties = $engine->getProperties();
244			} else {
245	2		$engineProperties = [];
246			}
247
248	2	View Code Duplication	if (array_key_exists('device', $uaDataChild)) {
			0 ignored issues – show Duplication introduced 2017-03-24 21:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
249	1		$device = $this->collection->getDevice($uaDataChild['device']);
			0 ignored issues – show Documentation introduced 2017-09-23 09:24 UTC by Report Bug Copy Issue Report `$uaDataChild['device']` is of type `array\|null`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
250	1		$deviceProperties = $device->getProperties();
251
252	1		if (!$device->isStandard()) {
253	1		$properties['standard'] = false;
254			}
255			} else {
256	1		$deviceProperties = [];
257			}
258
259	2		$properties = array_merge(
260	2		$properties,
261	2		$engineProperties,
262	2		$deviceProperties,
263	2		$platformProperties->getProperties()
264			);
265
266	2		if (isset($uaDataChild['properties'])
267	2		&& is_array($uaDataChild['properties'])
268			) {
269	2		$childProperties = $uaDataChild['properties'];
270
271	2		$properties = array_merge($properties, $childProperties);
272			}
273
274	2		$properties['PatternId'] = $this->getPatternId();
275
276	2		$output[$uaBase] = $properties;
277			}
278			} else {
279	4		$properties = ['Parent' => $ua, 'lite' => $lite, 'standard' => $standard];
280
281	4	View Code Duplication	if (array_key_exists('engine', $uaDataChild)) {
			0 ignored issues – show Duplication introduced 2017-03-24 21:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
282			$engine = $this->collection->getEngine($uaDataChild['engine']);
283			$engineProperties = $engine->getProperties();
284			} else {
285	4		$engineProperties = [];
286			}
287
288	4	View Code Duplication	if (array_key_exists('device', $uaDataChild)) {
			0 ignored issues – show Duplication introduced 2017-03-24 21:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
289	2		$device = $this->collection->getDevice($uaDataChild['device']);
290	2		$deviceProperties = $device->getProperties();
291
292	2		if (!$device->isStandard()) {
293	2		$properties['standard'] = false;
294			}
295			} else {
296	2		$deviceProperties = [];
297			}
298
299	4		$properties = array_merge($properties, $engineProperties, $deviceProperties);
300
301	4		if (isset($uaDataChild['properties'])
302	4		&& is_array($uaDataChild['properties'])
303			) {
304	4		$properties = array_merge($properties, $uaDataChild['properties']);
305			}
306
307	4		$uaBase = str_replace('#PLATFORM#', '', $uaDataChild['match']);
308	4		$this->patternId['platform'] = '';
309
310	4		$properties['PatternId'] = $this->getPatternId();
311
312	4		$output[$uaBase] = $properties;
313			}
314
315	6		return $output;
316			}
317
318			/**
319			* Builds and returns the string pattern id from the array components
320			*
321			* @return string
322			*/
323	6		private function getPatternId() : string
324			{
325	6		return sprintf(
326	6		'%s::u%d::c%d::d%s::p%s',
327	6		$this->patternId['division'],
328	6		$this->patternId['useragent'],
329	6		$this->patternId['child'],
330	6		$this->patternId['device'],
331	6		$this->patternId['platform']
332			);
333			}
334
335			/**
336			* expands all properties for all useragents to make sure all properties are set and make it possible to skip
337			* incomplete properties and remove duplicate definitions
338			*
339			* @param array[] $allInputDivisions
340			*
341			* @throws \UnexpectedValueException
342			*
343			* @return array[]
344			*/
345	13		private function expandProperties(array $allInputDivisions) : array
346			{
347	13		$this->logger->debug('expand all properties');
348	13		$allDivisions = [];
349
350	13		$ua = $this->collection->getDefaultProperties()->getUserAgents()[0];
351	13		$defaultproperties = $ua->getProperties();
352
353	13		foreach (array_keys($allInputDivisions) as $key) {
354	12		$this->logger->debug('expand all properties for key "' . $key . '"');
355
356	12		$userAgent = $key;
357	12		$parents = [$userAgent];
358
359	12		while (isset($allInputDivisions[$userAgent]['Parent'])) {
360	12		if ($allInputDivisions[$userAgent]['Parent'] === $userAgent) {
361			break;
362			}
363
364	12		$parents[] = $allInputDivisions[$userAgent]['Parent'];
365	12		$userAgent = $allInputDivisions[$userAgent]['Parent'];
366			}
367	12		unset($userAgent);
368
369	12		$parents = array_reverse($parents);
370	12		$browserData = $defaultproperties;
371	12		$properties = $allInputDivisions[$key];
372
373	12		foreach ($parents as $parent) {
374	12		if (!isset($allInputDivisions[$parent])) {
375	12		continue;
376			}
377
378	12		if (!is_array($allInputDivisions[$parent])) {
379			throw new \UnexpectedValueException(
380			'Parent "' . $parent . '" is not an array for key "' . $key . '"'
381			);
382			}
383
384	12		if ($key !== $parent
385	6		&& isset($allInputDivisions[$parent]['sortIndex'], $properties['sortIndex'])
386
387			&& ($allInputDivisions[$parent]['division'] !== $properties['division'])
388			) {
389			if ($allInputDivisions[$parent]['sortIndex'] >= $properties['sortIndex']) {
390			throw new \UnexpectedValueException(
391			'sorting not ready for key "'
392			. $key . '"'
393			);
394			}
395			}
396
397	12		$browserData = array_merge($browserData, $allInputDivisions[$parent]);
398			}
399
400	12		array_pop($parents);
401	12		$browserData['Parents'] = implode(',', $parents);
402	12		unset($parents);
403
404	12		foreach (array_keys($browserData) as $propertyName) {
405	12		if (is_bool($browserData[$propertyName])) {
406	12		$properties[$propertyName] = $browserData[$propertyName];
407			} else {
408	12		$properties[$propertyName] = $this->trimProperty->trimProperty((string) $browserData[$propertyName]);
409			}
410			}
411
412	12		unset($browserData);
413
414	12		$allDivisions[$key] = $properties;
415
416	12		if (!isset($properties['Version'])) {
417			throw new \UnexpectedValueException('Version property not found for key "' . $key . '"');
418			}
419
420	12		$completeVersions = explode('.', $properties['Version'], 2);
421
422	12		$properties['MajorVer'] = (string) $completeVersions[0];
423
424	12		if (isset($completeVersions[1])) {
425	12		$minorVersion = (string) $completeVersions[1];
426			} else {
427			$minorVersion = '0';
428			}
429
430	12		$properties['MinorVer'] = $minorVersion;
431
432	12		$allDivisions[$key] = $properties;
433			}
434
435	13		return $allDivisions;
436			}
437			}
438

browscap / browscap

Pull Request — master (#1596)

Expander::parseUserAgent() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like